From nobody Mon Feb 9 03:19:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676887270; cv=none; d=zohomail.com; s=zohoarc; b=Q3xNEyyF0NBtiFNg5m6/eQueeQ0bW4ke5FgtOnj/tnw8PxqYtZgG53hqRBw0YNYm/3x3tq3hqoqnIfC+VWwKiiBCJNKSKsLqgoEhPnWVhPRxx2ADFInhpRpsIpnbRchm3vi4p0/PvhQ0jNtI1hhocGhuUHl5swjlOg7Ndlk6L2k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676887270; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8dEXa6i/nkqJEtyLBAinV/qxrkWiFvN4lSXCeIz2izA=; b=X63H1VTBgsGglaQ/VJ5Dqj4lWMRg0oH3H0XZ42UFwYQNf09PhRNEFDUoOKBDULGiE9N7+mtbgWEPy/8kPgubuJNHeWPltM8sh9YUaJA1ZBbRUtftYqjNXK63DuDc4cjof9K39/Pl4wpuwlgMURStT3PxPvPlmih5fA+ZQwVvPgc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1676887270520751.7523874854321; Mon, 20 Feb 2023 02:01:10 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-481-_NUzxAxwMOeXPSEK-56-zg-1; Mon, 20 Feb 2023 05:01:06 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D376C803D7A; Mon, 20 Feb 2023 10:01:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D46A1121319; Mon, 20 Feb 2023 10:01:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AF1A519465B1; Mon, 20 Feb 2023 10:01:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C7CF61946587 for ; Mon, 20 Feb 2023 10:01:00 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A9D6F1415113; Mon, 20 Feb 2023 10:01:00 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E65D140EBF6 for ; Mon, 20 Feb 2023 10:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676887269; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8dEXa6i/nkqJEtyLBAinV/qxrkWiFvN4lSXCeIz2izA=; b=XcJ+ZOdeTxwxUaBfG/kTX4B/W7UAy+3kZlkxv2xb0oM8DVeSsd5BvBmo7RCeL42jAmgnaO OakkduGMamgr1povlY4NdqWO3gRDfHrEGnU4MAOR2P/fyoUXLnGAuyTifN1qrSZJIMhX23 /YpmoGSf5oYCg1WrsEUhStinaWywWU8= X-MC-Unique: _NUzxAxwMOeXPSEK-56-zg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/4] qemu_slirp: Don't set errfd when starting slirp helper Date: Mon, 20 Feb 2023 11:00:55 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676887271855100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Way back, in v6.2.0-rc1~67 we removed the code that reads slip's stderr on failed startup. However, we forgot to remove corresponding virCommandSetErrorFD() call and variable declaration. Do that now. While this may seem like a step in wrong direction (we should be reading stderr as it may contain reason for failed start), this is going to be handled in more general way in next commits. Signed-off-by: Michal Privoznik --- src/qemu/qemu_slirp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c index 3f83db03bf..faf58b0394 100644 --- a/src/qemu/qemu_slirp.c +++ b/src/qemu/qemu_slirp.c @@ -249,7 +249,6 @@ qemuSlirpStart(virDomainObj *vm, int rc; int exitstatus =3D 0; int cmdret =3D 0; - VIR_AUTOCLOSE errfd =3D -1; bool killDBusDaemon =3D false; g_autofree char *fdname =3D g_strdup_printf("slirpfd-%s", net->info.al= ias); =20 @@ -272,7 +271,6 @@ qemuSlirpStart(virDomainObj *vm, =20 virCommandClearCaps(cmd); virCommandSetPidFile(cmd, pidfile); - virCommandSetErrorFD(cmd, &errfd); virCommandDaemonize(cmd); =20 virCommandAddArgFormat(cmd, "--fd=3D%d", slirp->fd[1]); --=20 2.39.2