From nobody Mon Feb 9 01:22:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636993566; cv=none; d=zohomail.com; s=zohoarc; b=Ik4qgTrNqUauR1Y9rf88Vqt+Im6LbglGElzmlghMIHcd83woug0P1sur4DgJY0M3k0zhVnFKU9sRvsgWBmQtBTTZHDfT3Kb4QfTP80lZe4jrNs1A8GI8aBTNVgwHJNhsnm+jT0kRLHcYqgo5VXKk3BjoVQrot3iXVcgkkjOWgJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636993566; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NvVn/xEpjJshz+g6DVJXhC7Ee0HXh2u+wORmie/h2GA=; b=g3Wdvumv/5ltvBj/ZI7t73Wsfati3YspnQ1mu9TXSk+4MjtWQ60ufpwsMjK5qh7FXLtnd4BN5rOdWYRtMxiDb1zKI5y9TEbt+Rk8BVi19eye2UF23NVd3Jb0e5lBa6Bgn53AjmHFOyOwQVIk5JX9Z2UMDbKyCgyK2tmM3mhRNZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1636993566624978.9513061139917; Mon, 15 Nov 2021 08:26:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-cQheXRtoN5SZdQPWCG1rAw-1; Mon, 15 Nov 2021 11:24:09 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C8741018734; Mon, 15 Nov 2021 16:24:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBB7019730; Mon, 15 Nov 2021 16:24:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9D9E71832DD7; Mon, 15 Nov 2021 16:24:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AFGNGJm028315 for ; Mon, 15 Nov 2021 11:23:16 -0500 Received: by smtp.corp.redhat.com (Postfix) id 93F0919EF9; Mon, 15 Nov 2021 16:23:16 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F6EC60657 for ; Mon, 15 Nov 2021 16:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636993565; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NvVn/xEpjJshz+g6DVJXhC7Ee0HXh2u+wORmie/h2GA=; b=ZROymy72Ap4g0MShray+0/s2mxKN6qasTfzRSNUaTe72KO9W4Pmhx+G4QD3RSDHzIzWDzk ItO8BJuj1WMXu5J3vyeSCRHCcQtayePsyG425aLepvcTjJ/KQun0D/6PfqimI4oGQC1Gej WlbukgwpGTiyy1FPWNzTv3CQcUIGSR0= X-MC-Unique: cQheXRtoN5SZdQPWCG1rAw-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 11/11] domain_snapshot: update virDomainRevertToSnapshot description Date: Mon, 15 Nov 2021 17:22:54 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636993574881100001 Content-Type: text/plain; charset="utf-8" We've changed the behavior of this API that from now on it will always restart the VM process and we are no longer able to revert to snapshots created by libvirt older then 0.9.5. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/libvirt-domain-snapshot.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index 4a79e95704..99316460aa 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -960,6 +960,11 @@ virDomainSnapshotHasMetadata(virDomainSnapshotPtr snap= shot, * implies the intent to roll back state, no additional confirmation is * normally required for these lossy effects. * + * Since libvirt 7.10.0 the VM process is always restarted so the following + * paragraph is no longer valid. In case that the snapshot metadata lacks + * full VM XML we will error out as it is no longer possible to revert to + * these old snapshots. + * * However, there are two particular situations where reverting will * be refused by default, and where @flags must include * VIR_DOMAIN_SNAPSHOT_REVERT_FORCE to acknowledge the risks. 1) Any --=20 2.31.1