From nobody Mon Feb 9 20:55:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679673274; cv=none; d=zohomail.com; s=zohoarc; b=QxoMdsnGHdOCFE5sN2fE9JMOI6PozD6t5wUnBsMCsrVT1fA2haizRi4ZbfmtZDE2EkJifyXdd+qdR6b2DKm46BZ6vGcAg0W35SZcPXMGFcY30fp8JVjaKJUS3K/ZEeUMbRihkQug9hkXikOB08TpLRSq3PhRqzPy9gAYp5olLCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679673274; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=N0yEI5WiPz+Ded46za9KTqU7pDUKB0NZ21P0k4JR/Wk=; b=Nr27vPkbGcSxCc1tc6PB5+6LprCvRq9ns8O8cG6k8vuFX+2N6WgL+R+Gkvil/NW8ZQjZqH15mjtX1tIYbweFny2ExdP56OpyIvtufjWt7ttFHUTVNine3Xid1Tw5zHp19UIrTaHmPn2LONHMPY3FjO18Qu9CBE38Q8W14xgg2do= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679673274290528.3057414124636; Fri, 24 Mar 2023 08:54:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-462-yOwC-N8ZOeSDiYn1T6_uEw-1; Fri, 24 Mar 2023 11:54:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C04AA3C0F385; Fri, 24 Mar 2023 15:54:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5C8E140EBF4; Fri, 24 Mar 2023 15:54:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7E99D1946A5E; Fri, 24 Mar 2023 15:54:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 09DEF1946A5A for ; Fri, 24 Mar 2023 15:54:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F0D292027041; Fri, 24 Mar 2023 15:54:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E95552027040 for ; Fri, 24 Mar 2023 15:54:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CAA18185A791 for ; Fri, 24 Mar 2023 15:54:23 +0000 (UTC) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-WPpf_ZFKN5SV31HI5z3X8A-1; Fri, 24 Mar 2023 11:54:22 -0400 Received: by mail-ed1-f69.google.com with SMTP id a27-20020a50c31b000000b0050047ecf4bfso3795180edb.19 for ; Fri, 24 Mar 2023 08:54:22 -0700 (PDT) Received: from carol.localdomain (cst-prg-234-228.cust.vodafone.cz. [46.135.234.228]) by smtp.gmail.com with ESMTPSA id t27-20020a50ab5b000000b004c0c5864cc5sm10994968edc.25.2023.03.24.08.54.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 08:54:20 -0700 (PDT) Received: from carol.localdomain (carol.k8r.cz [127.0.0.1]) by carol.localdomain (Postfix) with ESMTP id 42AAF95C6599 for ; Fri, 24 Mar 2023 16:54:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679673273; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=N0yEI5WiPz+Ded46za9KTqU7pDUKB0NZ21P0k4JR/Wk=; b=MTC+uwE2F47FMDEv1URpFeWY8LIWaT9HBbjgJAM6zBC9YvW3Ldskhmq0EmTNQ/LyUaJa4c tyrR79gmbE7XBrwI3s4CYjVhub33nRx+HbMY6hF3mNMRH2sqO6pkJrc5xuSFNeSurwnDXy yS6jSQcgzkn+EyBOG/BG1PBSdF4T6wc= X-MC-Unique: yOwC-N8ZOeSDiYn1T6_uEw-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: WPpf_ZFKN5SV31HI5z3X8A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679673261; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N0yEI5WiPz+Ded46za9KTqU7pDUKB0NZ21P0k4JR/Wk=; b=eUUgR+p+iKenToOvIanJCkcPLwSm2B26Z5KyFekO0KvNIerCRrthb1zpIZ70MByiv2 AucSBHXC0Iqv0x7NrsgM/YSpJithE6aXFfFN5ultYTT8pJC3/UQafLmnrZk7nDKdJQSD 4Abla6KXFxNbnQGMQgekejb75vLIBszJOUcatI6BS0u/KLB28pR4M+vk1AT6usuxX5kx 0e4acqFugXQb4972ZHtZ9vhL5bU6l1QB7Aqa+LCIfqDjo/qTPVMGF3vaEbVk1h8AGftT L0OI6WO0Q0KsCAoTDqmcPcdCJVECLF4DPZJlb5ooFEpcgRazzFJk5U06Lr71A5iUZ3Ls 8FMw== X-Gm-Message-State: AAQBX9dkNucmgPfFAEfFa8WWH/YtiJbrGXOsofQDE2S4AXhCOh6aGDdP gkzijjC2P2OnrH7WSeWGLTI2cgZko1pmhoUCIJpxHMVS5m8/NDQC8cf1k7uGp/3N3sWUnsXaz6k OERvm3+JBp+BGHO2k19SXdHCUgGAcdGrx/v/YaFhLkLawqvemJnOdUhTkzb3tkNQNWN0c2dOmb1 KFexVl3A== X-Received: by 2002:a17:906:448e:b0:933:3cd8:a16f with SMTP id y14-20020a170906448e00b009333cd8a16fmr3277645ejo.75.1679673261323; Fri, 24 Mar 2023 08:54:21 -0700 (PDT) X-Google-Smtp-Source: AKy350b0MHyXOQ4FxfrkI1n2Abhf8acXJChzpRWCuTvy7Tw4UweWcl5AgfyFmacOf11tU/l1ys1KDA== X-Received: by 2002:a17:906:448e:b0:933:3cd8:a16f with SMTP id y14-20020a170906448e00b009333cd8a16fmr3277625ejo.75.1679673261036; Fri, 24 Mar 2023 08:54:21 -0700 (PDT) From: Martin Kletzander To: libvir-list@redhat.com Subject: [PATCH] Revert "ci: Disable optimization on macos-12" Date: Fri, 24 Mar 2023 16:54:01 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679673276311100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This reverts commit 1f76b5365ec78b1e9a36038db8e13ec0025bbe7a. There were two issues with this commit. First is the missing propagation of CFLAGS into the build environment and second is the fact that this is not enough to disable the check for -fsemantic-interposition. The proper fix would require setting MESON_OPTS or similar and also add the propagation of such variable into the cirrus builds etc., but at this point I burned so much time on this trivial piece of rubbish that I think it's easier to just wait for macos to gain a newer clang =3DD Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- ci/gitlab/builds.yml | 1 - ci/manifest.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index f070db637c80..545478d3516d 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -865,7 +865,6 @@ aarch64-macos-12: needs: [] allow_failure: false variables: - CFLAGS: -O0 CIRRUS_VM_IMAGE_NAME: ghcr.io/cirruslabs/macos-monterey-base:latest CIRRUS_VM_IMAGE_SELECTOR: image CIRRUS_VM_INSTANCE_TYPE: macos_instance diff --git a/ci/manifest.yml b/ci/manifest.yml index 2f631376b24b..b68c7361abb4 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -179,8 +179,6 @@ targets: variables: PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext= /bin:/usr/local/opt/libpcap/bin:/usr/local/opt/libxslt/bin:/usr/local/opt/r= pcgen/bin PKG_CONFIG_PATH: /usr/local/opt/curl/lib/pkgconfig:/usr/local/op= t/libpcap/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt= /ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig - # Remove once macos has clang with -fsemantic-interposition - CFLAGS: -O0 =20 ubuntu-2004: jobs: --=20 2.40.0