From nobody Mon Feb 9 00:06:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614696629; cv=none; d=zohomail.com; s=zohoarc; b=QLIhq/kAo9kgaptZN/WXFVWaEQGXFJSSDnqGZwKSQFrDScgAygfDCb0Ru3pf/OdHQOSlrTQP4SVATIHGx1HlTa/q78d4+Fm+lg1nDS/7SmuVeWMfEs4OSBV40mVqOKlhF9XzoBT+QXVmsekTkwZgH33MZRyBzM0aROefQteeHqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614696629; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AgKGgDdPtQd+hZzzmg2gRiPFXpEBQmuwxfzS9RPgb8E=; b=BJsb1oXJTKMIV39ED4Rc41GgF51K7T2ciuEJ65l1XR7JQ2qG4kB2ysFfHjJK7n2TIZBJcnGZgU5q5oqiVCbhj4fsqqNSUuBsoSgW91Lo4JccxjMotQF2Xt1tg4yt9AMD7UIa8KUynSiX8OHlck8FdcnzisKMucuiDBm9vvizzww= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1614696629766533.6749460890576; Tue, 2 Mar 2021 06:50:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-xxwGksXtN_y8VvmqeYICHQ-1; Tue, 02 Mar 2021 09:50:26 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0B7918BA28A; Tue, 2 Mar 2021 14:50:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BC0660C05; Tue, 2 Mar 2021 14:50:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A95D58089; Tue, 2 Mar 2021 14:50:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 122Envdp014583 for ; Tue, 2 Mar 2021 09:49:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id BC7305D722; Tue, 2 Mar 2021 14:49:57 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 217EB5D766 for ; Tue, 2 Mar 2021 14:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614696628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AgKGgDdPtQd+hZzzmg2gRiPFXpEBQmuwxfzS9RPgb8E=; b=JjQss9mahWOhNhdjtYio07OIhiYMZDCPHOcW9WpDTMBNw87euliusU5QFkXnzvfaS/FJD0 V9RZDnNDzPlYeP942ftRxlpxDMjQcfWmnPnr57xVcKb6pQRIU6ZZL2rd8po34OtpNghOY8 H3BZBH8mHasH750E08F68Io+wm3GnW4= X-MC-Unique: xxwGksXtN_y8VvmqeYICHQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 15/16] virNetLibsshAuthenticatePrivkeyCb: Use virStrcpy instead of virStrncpy Date: Tue, 2 Mar 2021 15:49:32 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We already assume that 'retr_passphrase.result' is a string, thus we can use virStrcpy instead. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/rpc/virnetlibsshsession.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c index 0fc1f66706..2dc8cc8911 100644 --- a/src/rpc/virnetlibsshsession.c +++ b/src/rpc/virnetlibsshsession.c @@ -437,8 +437,7 @@ virNetLibsshAuthenticatePrivkeyCb(const char *prompt, return -1; } - p =3D virStrncpy(buf, retr_passphrase.result, - retr_passphrase.resultlen, len); + p =3D virStrcpy(buf, retr_passphrase.result, len); virSecureEraseString(retr_passphrase.result); g_free(retr_passphrase.result); if (p < 0) { --=20 2.29.2