From nobody Tue Feb 10 02:28:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1689688694; cv=none; d=zohomail.com; s=zohoarc; b=ZU+B43FjCFaW4GJ7ENM9t69CAVCICB8WzoXwg6IpQcUfLAcPW23CxI6kXKqaAFWqmqKAdKlc8w5+wu3ZvTFuUUhDvngZp/iGOLPKpWql7VVCxdfR7C9fgJ/gnjZEUT7wrgr0gRaSkqB3ekVreEt6Ra7Uvp9ivR9DdqZ2L6mVl1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689688694; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9lQotGdMH4vp8RCMTipXSi3JkGMe27gUKb3/RHwbook=; b=V628m5eDttfZtwMmtmQI5Q/3wJlzCLO8CPjfZPbdqJSICmvdmnUGxqhkNzPGLGlw8hduQmjKpAt/zyINYBpzOQDDylcfPPfYdy5FkVngXpLz89P0l4ehBdOa7vkQ7n9489tSdij3ppgA5J1CHqxW2mQqEq1uaVGf7fftVTqynB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1689688694002266.53143328703845; Tue, 18 Jul 2023 06:58:14 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-8srkEFBbP0qYUnV5OXrqIA-1; Tue, 18 Jul 2023 09:58:07 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89F26101A54E; Tue, 18 Jul 2023 13:58:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76C82492B01; Tue, 18 Jul 2023 13:58:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A2C5819465B6; Tue, 18 Jul 2023 13:57:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 24DE319465B5 for ; Tue, 18 Jul 2023 13:57:21 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 09BB22166B25; Tue, 18 Jul 2023 13:57:11 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81C2A2166B28 for ; Tue, 18 Jul 2023 13:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689688692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9lQotGdMH4vp8RCMTipXSi3JkGMe27gUKb3/RHwbook=; b=LAQmF5ktaAnlILpJMHJP0esDD/JTBny1J1rq39M4QHny912NsFi6/KarRBanyijZbhHaiw oaFUEektq1OeSKJmKieCeGrzc/BtlbF5kc+Ajgxp50YHG21tQOJ7QqeEtpYAl92inbIWR6 0kqwOdnEfnrDbSOO9tQB+D0ysCmM1jg= X-MC-Unique: 8srkEFBbP0qYUnV5OXrqIA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/3] qemu: Always assume support for QEMU_CAPS_IDE_DRIVE_WWN Date: Tue, 18 Jul 2023 15:57:06 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1689688694478100001 Content-Type: text/plain; charset="utf-8" The support for configuring the 'wwn' of a IDE disk was added in qemu commit 95ebda85e09 (v1.0-1869-g95ebda85e0) and can't be compiled out. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 56fd562b70..03a35bbef6 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2852,14 +2852,6 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDom= ainDiskDef *disk, _("Only ide and scsi disk support wwn")); return -1; } - - if (disk->bus =3D=3D VIR_DOMAIN_DISK_BUS_IDE && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_IDE_DRIVE_WWN)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Setting wwn for ide disk is not supported " - "by this QEMU")); - return -1; - } } if (disk->vendor || disk->product) { --=20 2.41.0