From nobody Sun Feb 8 19:59:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573728204; cv=none; d=zoho.com; s=zohoarc; b=DL7W+FZFBYdwmm28m5HfTR8e5Yh3Coxd022u6P9DfMvZtp0f84LW6R1U6I765em4ywPCYtkAa4MFzDkMMxd6e8ds6Le7Wy/1oWkfQBf9a3K9JQ1TwVWBoov1jYZkD9xsw2n/LaMqkrzg6biXzSz8xNnc+JiDp+NN25mEmQqHU/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573728204; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kumqJEA4BQ/Q3U/WY+hi0QPR479u202WxKgo9ZIbxtk=; b=XHqSFxIwd3qLFIsTONHvyzY1zJPs66VoR/L3q9Wty5Zbop2dgntuVaVH6M8Mir5tiUR4nn4cIvIb/eBDUt1Dt7lYi7oP6doSpnic2yR1TwHPkFcRDFu+BoTvxAgc6btNJV4vZIBHK4chuo2Y9yMc8fcW7Od97qhoSV13cAKFALU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1573728204128474.5153908913694; Thu, 14 Nov 2019 02:43:24 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-RwD42GAeMou6jUZN0pcB8A-1; Thu, 14 Nov 2019 05:43:21 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BAEAD8C5EE0; Thu, 14 Nov 2019 10:43:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 944615C548; Thu, 14 Nov 2019 10:43:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3AD8D18089D5; Thu, 14 Nov 2019 10:43:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAEAgcU8005425 for ; Thu, 14 Nov 2019 05:42:38 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3A03660303; Thu, 14 Nov 2019 10:42:38 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-40.brq.redhat.com [10.40.200.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9BC2A601B8 for ; Thu, 14 Nov 2019 10:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573728203; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kumqJEA4BQ/Q3U/WY+hi0QPR479u202WxKgo9ZIbxtk=; b=b8PVGso+5XS2P+CDljJnBdt7ROOfgBBcZwItrLQKKrEm/BceimFOB39yrrwFX4e7Gvrxx1 EDDj1QbMMoPc49QhoNNYeuKMY3dGXHpk6CzByUrlupnlrpdjdyhgwqF4IfdrsVtvWJhvji f7J39V+18zAjKAVC8vFoHPAmOdi28dw= From: Pavel Hrdina To: libvir-list@redhat.com Date: Thu, 14 Nov 2019 11:42:29 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] syntax-check: forbid usage of setenv and unsetenv X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: RwD42GAeMou6jUZN0pcB8A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" --- build-aux/syntax-check.mk | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 1c46928ac7..710ac1c949 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1169,6 +1169,14 @@ sc_prohibit_dirent_d_type: halt=3D'do not use the d_type field in "struct dirent"' \ $(_sc_search_regexp) =20 +sc_prohibit_setenv: + @prohibit=3D'\' \ + halt=3D'use g_setenv instead of setenv' \ + $(_sc_search_regexp) + @prohibit=3D'\' \ + halt=3D'use g_unsetenv instead of unsetenv' \ + $(_sc_search_regexp) + =20 # _sc_search_regexp # @@ -2341,6 +2349,9 @@ exclude_file_name_regexp--sc_prohibit_cross_inclusion= =3D \ exclude_file_name_regexp--sc_prohibit_dirent_d_type =3D \ ^(src/util/vircgroup.c)$ =20 +exclude_file_name_regexp--sc_prohibit_setenv =3D \ + ^(build-aux/syntax-check\.mk|bootstrap\.conf)$$ + exclude_file_name_regexp--sc_prohibit_strcmp =3D \ ^(tools/nss/libvirt_nss.*\.c|tools/virt-login-shell\.c) =20 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list