From nobody Thu Jan 2 13:21:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440024; cv=none; d=zohomail.com; s=zohoarc; b=FkxOACZ8sM/vjpi55lg3I9W93p62dI02RZLXYwOm3daNDmXDwGhEDhxrXDeWJR9hE1ocsfk0ogNPStKtmqwqeYnwlRqRUoyaJJE9t5mUhR4bemjEveX2iyN8bwufUq+h18RHNmeu756epZIXzlqfgZDKKp3sc4u2EWaX9KFu8r4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440024; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f2uaGGnclw1POfb9Tzca/lGRmN66Id6+p7JJGSDwcig=; b=ZX2k/cw3FLSyXtZkNYwRkwfyya2Cl92tNsAZPurOU6qJvADNUP+K4WIjwhP0QBKQsi/pIboBhDSAu1FlSp7NTghVmaw+ZQRNJWV4c2yzeFPu+kqR9nGh8j8pyX+vcMQc5V5wN9BsBYeUAZ5YxieW62E3DSx+3Ei6ivAp5oRsOdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694440024160325.95858531457407; Mon, 11 Sep 2023 06:47:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-X7uW7YSVP0SyzwuF8G5FkQ-1; Mon, 11 Sep 2023 09:44:31 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 22570381CC1D; Mon, 11 Sep 2023 13:44:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A5F12022EBE; Mon, 11 Sep 2023 13:44:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 97B7B194E11F; Mon, 11 Sep 2023 13:44:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 34D471946A49 for ; Mon, 11 Sep 2023 13:44:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 278382022EBD; Mon, 11 Sep 2023 13:44:06 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.225.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F2EB2022EBC; Mon, 11 Sep 2023 13:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440023; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f2uaGGnclw1POfb9Tzca/lGRmN66Id6+p7JJGSDwcig=; b=HNipHwtzoCvOZqcEW5fKfy5HCTWLJDL0d0TSw5tNfa5K71KFrBRXpseqOuCPGnTqFxGTL5 SkgNoRzq9JCTeU3IBDGYCX+Aj2ri3VzgShFd5IenzR510dvJCVdMitBkZ3H6FRkeJvys99 bGywObou3oANvX1nqacibZi3AdwtF50= X-MC-Unique: X7uW7YSVP0SyzwuF8G5FkQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH v2 33/35] ci: helper: Drop the --meson-args/--ninja-args CLI options Date: Mon, 11 Sep 2023 15:43:34 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440026169100001 These originally allowed customizing the ci/Makefile script which was the core of the local container executions. The problem was that however flexible this may have been, it never mirrored what was being done as part of the GitLab jobs. Motivated by the effort of mirroring GitLab jobs locally, these would only ever make sense to be set/used in interactive shell container sessions where the developer is perfectly capable of using the right meson/ninja CLI options directly without going through another shell variable indirection as it was the case with these ci/helper options. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 Erik Skultety : --- ci/helper | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/ci/helper b/ci/helper index b90dc56ede..c734629731 100755 --- a/ci/helper +++ b/ci/helper @@ -75,21 +75,6 @@ class Parser: help=3D"path to lcitool (default: $PATH)", ) =20 - # Options that are common to all actions that call the - # project's build system - mesonparser =3D argparse.ArgumentParser(add_help=3DFalse) - mesonparser.add_argument( - "--meson-args", - default=3D"", - help=3D"additional arguments passed to meson " - "(eg --meson-args=3D'-Dopt1=3Denabled -Dopt2=3Ddisabled')= ", - ) - mesonparser.add_argument( - "--ninja-args", - default=3D"", - help=3D"additional arguments passed to ninja", - ) - # Options that are common to actions communicating with a GitLab # instance gitlabparser =3D argparse.ArgumentParser(add_help=3DFalse) --=20 2.41.0