From nobody Sun Feb 8 19:56:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615569696; cv=none; d=zohomail.com; s=zohoarc; b=PFSkRAkbL88O+BE8bGnpsoGi9oozfVJ5/0mkAo3K/6L1zmkiF7j4m73dUanXztJdLCG7wvr3zBtyfmmBrnYz8dT9bHJ6ThJcIcauPuNGsWLqS10glPrmUEq+djn7rdzfei6dYYvH3EuP+nYUrq3KWoTnwkotlB3BwYWC/sCVmj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615569696; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qJo0+DmqHx7defN44RujTzBondauA/JnXp9vMkfuEDQ=; b=Adxv8QMVO5GnA/9SCs6PclPa1Gmc+kjFUhu0yYEZfHJSsAi+lOiew4Kqx0Iiti0Pdm1x5WwxPM4RP+S173FGuDNDYQfl9AiKAyJaZpMj76g1NYsBnB25RGABv/tZXWsG8aCHHFBSOvcuzPx7+yM6fIuWJqMKSmwRXjBadZss2kw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1615569696791545.9798984719608; Fri, 12 Mar 2021 09:21:36 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-7ae2HPXPPFCKXwIy25OVeA-1; Fri, 12 Mar 2021 12:21:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D4ED1800D55; Fri, 12 Mar 2021 17:21:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC7A05DAA5; Fri, 12 Mar 2021 17:21:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 70E568E1E; Fri, 12 Mar 2021 17:21:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12CHLAcb030198 for ; Fri, 12 Mar 2021 12:21:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1EEE91001281; Fri, 12 Mar 2021 17:21:10 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 749841002388 for ; Fri, 12 Mar 2021 17:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615569695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qJo0+DmqHx7defN44RujTzBondauA/JnXp9vMkfuEDQ=; b=boruKOjz5jv9bXg5AkdCSjX9cJYuoXAHlEs0uEXIJivFfH68BaO1BqSq5AS3GUdyLBA0kp VBCOBaJKqz5dgYZ9BdxlpxjkTQfRtF91eutK/c5HtSLyOSlz2L2h+HmraKZcO/gHIF4rux jbwgB43PuCRQS+bQ6NDgbiC/mkdapVw= X-MC-Unique: 7ae2HPXPPFCKXwIy25OVeA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v3 08/13] tests: qemuxml2argv: Validate generation of JSON props for object-add Date: Fri, 12 Mar 2021 18:20:51 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Similarly to the validation for blockdev-add and netdev_add, use the qemuxml2argv test repository to drive validation of props for object-add. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 29054ba168..631cd427e1 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -603,6 +603,24 @@ testCompareXMLToArgvValidateSchema(virQEMUDriverPtr dr= v, return -1; } + i++; + } else if (STREQ(args[i], "-object")) { + + if (*args[i + 1] !=3D '{') { + i++; + continue; + } + + if (!(jsonargs =3D virJSONValueFromString(args[i + 1]))) + return -1; + + if (testQEMUSchemaValidateCommand("object-add", jsonargs, + schema, false, false, &debug= ) < 0) { + VIR_TEST_VERBOSE("failed to validate -object '%s' against = QAPI schema: %s", + args[i + 1], virBufferCurrentContent(&deb= ug)); + return -1; + } + i++; } } --=20 2.29.2