From nobody Tue Sep 9 03:19:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1746435309; cv=none; d=zohomail.com; s=zohoarc; b=AAixlzq923eARB11auOA/2om8lTvTUO5L7A4SxHylW0mjmO029teYwkPs0MKeMHTjIteIwSD/avzUGKIUEu2urvncsu5OsH/I1h6I0UDcF557QmaNX2DzhCuLoLp+0qjRdH1Rw1KYIfyBJb8BplmsrokmjH5gO5wwHANAT091+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746435309; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=9V2DQrcYbOKvRXSmHui0X99z1sgeXKtdGurDSmQ0IEE=; b=DRtNdDksFWVpzeafu+nmksDVge6jRfa0bYGG4NyFIqGr+NzCwAtsX/sAlTlyTIoGZWgT0rRArUCw+NfrtVg5angOHWaxcJneoYEr88sRfjyQrxo5ur+SLEEf7d4bo4UxyXV64dbkI3b5XI6XLkW8/UtNw/V499OKkzNz2diOCr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174643530961487.17663843169112; Mon, 5 May 2025 01:55:09 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A123213CF; Mon, 5 May 2025 04:55:08 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4408213DB; Mon, 5 May 2025 04:54:50 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B397B13CF; Mon, 5 May 2025 04:54:47 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 35DDF137D for ; Mon, 5 May 2025 04:54:47 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-6M3o9VZYNkKbnPJwZKZSYw-1; Mon, 05 May 2025 04:54:45 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B6DE11956048 for ; Mon, 5 May 2025 08:54:44 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0F2661800360 for ; Mon, 5 May 2025 08:54:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746435286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=miJj42zZJYE+dXo026MpDuC75ZUjQdm0LgYi0cwY0qU=; b=H+EYPJ0QsstJDSUyd8oMIuG+chGMFL/UCMlVauT8O2ai3eHYGZmII60eyj/saM2qU5gojQ 99nwKRMiSF6yZqo9T0oXo5QmK8yacOpIBun9zdwaAdwOsbP138T5Dq/i4aoqsq7JsOjsfX rn5m9t7Atk85fwKR4XveYxo08+d5LKQ= X-MC-Unique: 6M3o9VZYNkKbnPJwZKZSYw-1 X-Mimecast-MFC-AGG-ID: 6M3o9VZYNkKbnPJwZKZSYw_1746435284 To: devel@lists.libvirt.org Subject: [PATCH] docs: hooks: Document when shutoff-reason argument was introduced Date: Mon, 5 May 2025 10:54:41 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 32OIGqN2h52vl3nvxoffIo5DcPzlC8gJtG-Oy6Jbj4w_1746435284 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UYBYPX7VXU5TNJKPE5UE6NY7IPNO6ATO X-Message-ID-Hash: UYBYPX7VXU5TNJKPE5UE6NY7IPNO6ATO X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1746435314088019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Introduced in v10.5.0-rc1~52, qemu and lxc hook scripts are executed with additional argument: shutoff reason. But wording of our docs make it looks like it's been that way forever. Make it clear this is `recent` feature. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/766 Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- docs/hooks.rst | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/hooks.rst b/docs/hooks.rst index 48128ba3d8..b363f51da1 100644 --- a/docs/hooks.rst +++ b/docs/hooks.rst @@ -211,7 +211,9 @@ operation. There is no specific operation to indicate a= "restart" is occurring. /etc/libvirt/hooks/qemu guest_name stopped end - =20 Then, after libvirt has released all resources, the hook is called agai= n, - :since:`since 0.9.0`, to allow any additional resource cleanup: + :since:`since 0.9.0`, to allow any additional resource cleanup + (:since:`since 10.5.0` there's additional argument ``shutoff-reason`` p= assed + to the hook): =20 :: =20 @@ -331,7 +333,9 @@ operation. There is no specific operation to indicate a= "restart" is occurring. /etc/libvirt/hooks/lxc guest_name stopped end - =20 Then, after libvirt has released all resources, the hook is called agai= n, - :since:`since 0.9.0`, to allow any additional resource cleanup: + :since:`since 0.9.0`, to allow any additional resource cleanup + (:since:`since 10.5.0` there's additional argument ``shutoff-reason`` p= assed + to the hook): =20 :: =20 --=20 2.49.0