From nobody Sun Feb 8 23:26:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618600446; cv=none; d=zohomail.com; s=zohoarc; b=Vm/yzh4Ad865/NGsW110JpZx7cwgIBWjCXPZA3ouMuufcKNMQXw2KqNc88wLqn7Cvug3S0JCuzI3/9j+3wT2UFthnzCtLLV5PHyynqYsGV3K9ZHy/4RhpvRpZNQfaKARoFBL6tq/8zHV5PJv69A/0J7tUTPdg1AWReVPi/GjheM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618600446; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TL2VLIOawBDLyAIBDvw8qA5h6AHwFPubOVd7hSe43eQ=; b=TompAZOaMQI67nqsduIBhJIGdb3ncPoQ9WTMgUf3HnjSmXj2gBnyEvsvCyfYQ35ImIo1cXwlhTNulpWmb7TzCHpOiXzMMNSYvtOztcrujjtkrHeCjtr9SVtLggJQ0NenjOn7Y4seF+0DY/Md6rnOr++8X3Bbo0GNpMJ7lewum+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618600446879604.1179737396399; Fri, 16 Apr 2021 12:14:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-4v-aJPXeNi-EB4SnX3AIwA-1; Fri, 16 Apr 2021 15:13:19 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AB8018397A7; Fri, 16 Apr 2021 19:13:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0C5819CBE; Fri, 16 Apr 2021 19:13:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7B7344A65; Fri, 16 Apr 2021 19:13:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13GJCvpD028236 for ; Fri, 16 Apr 2021 15:12:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id A3CC75D749; Fri, 16 Apr 2021 19:12:57 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.195.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 244CF5D6D3 for ; Fri, 16 Apr 2021 19:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618600445; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TL2VLIOawBDLyAIBDvw8qA5h6AHwFPubOVd7hSe43eQ=; b=WoFoWa/jH4SVEGRxm+GcUesgDTbScMeifkKHe0M7ZJE+DTrK9ZeG0L1OJ9PmyrWwfwxsh6 FGGZ0cuUh6q8Zu2QjxPnJob6ylnnxut7MBboiwOSxojnltFKUKeWOIfZtJ5YyyxSXaKoJw ciQFkdiQBBId9g/PvYU96POY5hNviME= X-MC-Unique: 4v-aJPXeNi-EB4SnX3AIwA-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 06/17] virfirewall: use virFindFileInPath instead of virFileIsExecutable Date: Fri, 16 Apr 2021 21:12:35 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Following patches will make this change necessary as we will stop detecting the full path during compile time. Signed-off-by: Pavel Hrdina --- src/util/virfirewall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 78aa7e580e..e79fe52ac8 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -104,7 +104,9 @@ virFirewallValidateBackend(virFirewallBackend backend) size_t i; =20 for (i =3D 0; i < G_N_ELEMENTS(commands); i++) { - if (!virFileIsExecutable(commands[i])) { + g_autofree char *path =3D virFindFileInPath(commands[i]); + + if (!path) { virReportSystemError(errno, _("%s not available, firewall backend wil= l not function"), commands[i]); --=20 2.30.2