From nobody Mon Sep 8 21:37:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748551426; cv=none; d=zohomail.com; s=zohoarc; b=EeBffMTSDiYfjOstVrPEN53Wp0NKQwBGstpcQ39xQ6ITzeRnn6HscGkvJc5e+v6EWhmONAXzcJdlFt1+nYKg6NuQkm8BQT6d6Df2jzBACepq791Zp0cveEGjflLDUTPQPqHx8nqIe5B1LXPkpDYwTDkUVi9ikDWI2RAI/oKUZZc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748551426; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=ppDSacWUIuRAevqJUJKLnxz8mU8Rv6ZwwEjQzARymBs=; b=dQ2BvYGDDWSG7JF0rKfyIECfUMqqaA5AFVrBpuFyuY0042980QAkVYN5cdX5WDj5Nzq58zNREWSKtO+i3818o9UplPGVpk2P+acfallJy1KS6KzPuj/vhrMrAMD31YoU6b/lFldhsFmCvymj2yyTFDugPlhCL8tMEOmOPnrmsWk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748551426523854.1656015262676; Thu, 29 May 2025 13:43:46 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 47FF41298; Thu, 29 May 2025 16:43:45 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0418B128A; Thu, 29 May 2025 16:43:30 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D55461274; Thu, 29 May 2025 16:43:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4AE91123A for ; Thu, 29 May 2025 16:43:27 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-KbgWH9lROUuZNbbIaqeK0Q-1; Thu, 29 May 2025 16:43:25 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AECD0180048E for ; Thu, 29 May 2025 20:43:24 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.44.22.3]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B2CFC30001B7; Thu, 29 May 2025 20:43:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748551407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TMzPDwLen3bqdhFlhuX6JsL6XkVjDqNZBp446wygIN4=; b=CAqizlYrbgHSc4C/YoFLtwr+4atgcjHjpVxH+Y9O+q9s170t8VGnGOKurdbAaNAnHmCREg 0MxrHItIkkW31rmnedigy10ZqkSLIbq2U2kbqaoSkj34DFMUIY4fA+6nl20OzXFwwzkfs3 RKmPyBe3Up/1zP0yzZnh918WIDx7B/s= X-MC-Unique: KbgWH9lROUuZNbbIaqeK0Q-1 X-Mimecast-MFC-AGG-ID: KbgWH9lROUuZNbbIaqeK0Q_1748551404 To: devel@lists.libvirt.org Subject: [PATCH] virConnectAuthCallbackDefault: Return failure if 'virGetPassword' returns NULL Date: Thu, 29 May 2025 22:43:20 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: onmYPvNDaADDtAWjHsRNTVXiilhIAaejbs1LkJtNLIE_1748551404 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5EXHUFRYIJABAANDACN7YERSGN6KHNPU X-Message-ID-Hash: 5EXHUFRYIJABAANDACN7YERSGN6KHNPU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748551428467116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa virGetPassword can return NULL on linux or BSD if it fails. The caller in virConnectAuthCallbackDefault does dereference it unconditionally. Return failure if virGetPassword returns NULL. Fixes: db72866310d1e520efa8ed2d4589bdb5e76a1c95 Closes: https://gitlab.com/libvirt/libvirt/-/issues/777 Signed-off-by: Peter Krempa Reviewed-by: Jiri Denemark --- src/libvirt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libvirt.c b/src/libvirt.c index 581fc6deea..375d3fa7ef 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -158,7 +158,9 @@ virConnectAuthCallbackDefault(virConnectCredentialPtr c= red, if (fflush(stdout) !=3D 0) return -1; - bufptr =3D virGetPassword(); + if (!(bufptr =3D virGetPassword())) + return -1; + if (STREQ(bufptr, "")) VIR_FREE(bufptr); break; --=20 2.49.0