From nobody Tue Sep 9 03:16:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1750167921; cv=none; d=zohomail.com; s=zohoarc; b=H01GJduQRt/Ix1eg+SzKtN7HzCsyHTQEoWVi2v2XQN2fg84QBk8CidC4KaLlgPr4txaYrJjE5Vf13k0/mWhbzdoZB48UhCWQCGH3oCmbdIY9OhSgTGUcrC7ptx16h396PYV7R6/32dWF5U9M/XTl6iJRuhSyrpVZP4N7foUdpmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750167921; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=ehcFFQSsB0EBDNANliW/m+OTHqq1yL8h7vCme567AGk=; b=fhycootopMCAFq60dBKs2vHb7wHhCCGWXQjN8oMPG6mChqGcvFRjSbyUNuhb6/viYcM8sqJ1JT64ZcFH8Y4JZ9Y1iAfGA/UqediG/bUBQDBe4YH/REvDyCeeDLSJ2gXymMMMW7+9tfN5kSRe3/T/xp9bnREZuXQtrGwDAh+mB1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1750167921759579.5942214445022; Tue, 17 Jun 2025 06:45:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AD3FBCEE; Tue, 17 Jun 2025 09:45:20 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5D99E1171; Tue, 17 Jun 2025 09:44:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 086CFBA1; Tue, 17 Jun 2025 09:44:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 855AEB48 for ; Tue, 17 Jun 2025 09:44:07 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-CLSfn1lGOxu5cRFMFcCODQ-1; Tue, 17 Jun 2025 09:44:05 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA9CF19560AE for ; Tue, 17 Jun 2025 13:44:04 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.10]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0529A180045B for ; Tue, 17 Jun 2025 13:44:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750167847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6gwjQx0+dUdR+SUECxPjWeP7QZlrAvPqgnUuYFaYTE=; b=dOQeD5IJkeh2OpXUj4rQBM+1YfKXswIkGsNyVF43ZjPQoSYzlubvBplAZ0k43FgSjd6GY7 MiVjWQj5b9LaqkvR5ZwmOKMlX8SoJ/CEKw4SUgDdiGaLD8g3F6VLlVBPxmER2IAu5soCVc PEFxldLIp/stjm33GogvBtfC2fhOEcc= X-MC-Unique: CLSfn1lGOxu5cRFMFcCODQ-1 X-Mimecast-MFC-AGG-ID: CLSfn1lGOxu5cRFMFcCODQ_1750167845 To: devel@lists.libvirt.org Subject: [PATCH 2/6] virQEMUCapsFindBinary: Refactor local variables Date: Tue, 17 Jun 2025 15:43:55 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YJZyGVZxF8_wj6CNpqZV098UVw4BQQazgdpgqiGVQvA_1750167845 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GEVDSNYPEG22V2ZYSZJ2HWNT65FVY5IE X-Message-ID-Hash: GEVDSNYPEG22V2ZYSZJ2HWNT65FVY5IE X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1750167923107116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 4251ad2d92..2ba5462bb2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -972,14 +972,9 @@ static char * virQEMUCapsFindBinary(const char *format, const char *archstr) { - char *ret =3D NULL; - char *binary =3D NULL; + g_autofree char *binary =3D g_strdup_printf(format, archstr); - binary =3D g_strdup_printf(format, archstr); - - ret =3D virFindFileInPath(binary); - VIR_FREE(binary); - return ret; + return virFindFileInPath(binary); } char * --=20 2.49.0