From nobody Sun Feb 8 07:21:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1644508720; cv=none; d=zohomail.com; s=zohoarc; b=ijhnSE8zws980AOIfz3H6cHPho3Btim1KzXkVS9NFeH8vn+r+Lb7KIxkeexxWMrKtxQUmsbWV0GxpMsRL+6WP9fgRvOJXzqgLQOtS+tVvr2cFMsLrKTJlQEkpo60VriSCVWOwGO+To0682cji9cSFI33LjZnw4yReH+vWDEAYpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644508720; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0L4jr4cgyeVV0SrUo8/MmzQkSkswAFuaS5ShJchpTSo=; b=KrgVAzB2pC9cXTymVzql6AvblF1zucAoVYZK3M2Xd1wQCG8NWxw5KNfW0tBYUIWqQrhcxu57hPfMbWDlkLKtrzkmEc93fiXt4mQdKQ5hjDNZW1H5C34KXLVw34T0TzWQLCoqjkMKZQPD9SIvuaZCwGuGpWS1+qbpwSgtHpmkwKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1644508720735669.1840390223377; Thu, 10 Feb 2022 07:58:40 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-QXPD1CEvPa69DeZTOs03pA-1; Thu, 10 Feb 2022 10:58:38 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7906310151E2; Thu, 10 Feb 2022 15:58:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5388485EEB; Thu, 10 Feb 2022 15:58:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 25FC54A7CB; Thu, 10 Feb 2022 15:58:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21AFpdfT011368 for ; Thu, 10 Feb 2022 10:51:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id BAE6075745; Thu, 10 Feb 2022 15:51:39 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4566775133 for ; Thu, 10 Feb 2022 15:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644508719; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0L4jr4cgyeVV0SrUo8/MmzQkSkswAFuaS5ShJchpTSo=; b=G/1HyAoxc6NemkaSjWG3/wwJR1KZT0D6MrYl5nD9Hhl8zL6azolO4qostbJZVPTBmUg8g9 +3NH0LnJILnizOcRb7b3/9GNHjQrI6jE95bCrd1nsd8+As6PmCgsxCGC75YbGh7s74FSku 34PPxg52TFNxgc6yOxSbmQw864k5pcQ= X-MC-Unique: QXPD1CEvPa69DeZTOs03pA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/6] ch_driver: End job properly on failed chDomainCreateXML() Date: Thu, 10 Feb 2022 16:51:32 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1644508722791100001 Content-Type: text/plain; charset="utf-8" When creating a domain failed, then the virCHDomainObjEndJob() would be jumped over. Fix this by creating enjob label and fixing one goto. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index b023f7e3d3..cd156a222b 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -228,10 +228,11 @@ chDomainCreateXML(virConnectPtr conn, goto cleanup; =20 if (virCHProcessStart(driver, vm, VIR_DOMAIN_RUNNING_BOOTED) < 0) - goto cleanup; + goto endjob; =20 dom =3D virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); =20 + endjob: virCHDomainObjEndJob(vm); =20 cleanup: --=20 2.34.1