From nobody Sat May 4 18:43:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1685110732; cv=none; d=zohomail.com; s=zohoarc; b=ekvNY5NN7dSgh8Td/40XxJxcOzPTUBtzdWb9RO7+3hYn+UbLzD4CmFWH2/awP4YoFqk42AHCHJLpyCoUypfa4V3VdzxPM+6LfaDyYJTLVA2braM1368o7XI436BaAEmOmL3o/QqwuxnnNwNibjZbkla7K/NPLx7CSswt9Kqvvqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685110732; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Z0WB9YUWLB7e5olSYT5adJned7yXI9LNduCMdQdS9q4=; b=Kl64ZBYRniHlSYPFWedIE08wjZjvfM9P+Wtn3SXI14IKtjmDcw74giGyw6CdWQ0q8QolRcc9K1Exg6SmzEg71tro9xPxe2Arhlme70G02Dv7BaSjtPW90OyExiXS6yfpSsmyLpYM+DR8722j5hfYhKKyv+kE8DHSjRkDRiQAl4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1685110732061139.100568041237; Fri, 26 May 2023 07:18:52 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-118-3dv8w5WVNQyREd9i6k4HMg-1; Fri, 26 May 2023 10:18:44 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49E8E3C13A1D; Fri, 26 May 2023 14:17:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71CDB407DEC3; Fri, 26 May 2023 14:17:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 14D9419465A8; Fri, 26 May 2023 14:17:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 13BA119465A0 for ; Fri, 26 May 2023 14:17:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F26991121315; Fri, 26 May 2023 14:17:42 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 998AE1121314 for ; Fri, 26 May 2023 14:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685110731; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Z0WB9YUWLB7e5olSYT5adJned7yXI9LNduCMdQdS9q4=; b=O2mX1CGiQr0m/htCZIkEWwba9gKELfqxpXCyE1HoBxUmcbZZe20fSfQ8vVAM06UkrRcOL/ LITG/4bGqzQvz1FsulW4uV7bFP6Nxk2khZ5dis+nGRzhUHPK7yy00cJZMsHVG7vtypgShD 8OZ5Td6YRyRKCG6qiVsRwRLC/L7nFJY= X-MC-Unique: 3dv8w5WVNQyREd9i6k4HMg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] conf: Run virDomainInputDefPostParse() only for VIR_DOMAIN_DEVICE_INPUT Date: Fri, 26 May 2023 16:17:41 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1685110734289100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Due to missed break; statement the virDomainInputDefPostParse() is called not only for VIR_DOMAIN_DEVICE_INPUT but also VIR_DOMAIN_DEVICE_LEASE and VIR_DOMAIN_DEVICE_NET, which can lead to all sort of unpredictable results. Fixes: c4bc4d3b82fbe22e03c986ca896090f481df5c10 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_postparse.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index 7ef478e3e1..c6695b460d 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -725,12 +725,13 @@ virDomainDeviceDefPostParseCommon(virDomainDeviceDef = *dev, ret =3D virDomainFSDefPostParse(dev->data.fs); break; =20 - case VIR_DOMAIN_DEVICE_LEASE: - case VIR_DOMAIN_DEVICE_NET: case VIR_DOMAIN_DEVICE_INPUT: virDomainInputDefPostParse(dev->data.input, def); ret =3D 0; break; + + case VIR_DOMAIN_DEVICE_LEASE: + case VIR_DOMAIN_DEVICE_NET: case VIR_DOMAIN_DEVICE_SOUND: case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_GRAPHICS: --=20 2.39.3