From nobody Sun Apr 28 18:43:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556280690; cv=none; d=zoho.com; s=zohoarc; b=mtYLWr2fu+TzdZPC1OjTMKByrxRIU80kqsiPU6sMee/eye64czKo0beDQqzPvzpbGGLpQDRYzCdyiugEmlJi60jdh2R7H+OZru8kAmFpuXtp6YjYbOc2Fh76YXTYC4iwDWDSQxYUHx2K4J/YQXalRgzl2XiJwYdZb1pkKQ9NkLE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556280690; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=yEOn2sf3WvVIkpoUxDm3B/pRwAhtbtkuK6B2MrBxUx0=; b=UhyzJQ7fYHx0vj8UySrrUnrvVoCQObd33Y9+D/AR+Z09lR0mo9rjrX4e29o6e7XN+IqkCoNnMVkS218TEX/0C+2yVcfC606wdCe77Nc6KqZa32IL/jL9oWL4TeKFAwceqBvaGv7sTMYUhRdvF/QdpEboG2qt5FgI5K4WhaduRYk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1556280690418476.28545665761794; Fri, 26 Apr 2019 05:11:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E1A3308FF0E; Fri, 26 Apr 2019 12:11:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A32435C219; Fri, 26 Apr 2019 12:11:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 13A22181AC92; Fri, 26 Apr 2019 12:11:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3QCBM95015429 for ; Fri, 26 Apr 2019 08:11:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 05EB71001925; Fri, 26 Apr 2019 12:11:22 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 823BE1001E6C for ; Fri, 26 Apr 2019 12:11:19 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 26 Apr 2019 14:11:17 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virsh: Put a new line char after in attach-disk X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 26 Apr 2019 12:11:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Each attribute is on its own line. We forgot to add new line character for Signed-off-by: Michal Privoznik --- Pushed under trivial rule. tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index da57d96d1a..82140feb57 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -683,7 +683,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, "%s\n", serial); =20 if (alias) - virBufferAsprintf(&buf, "", alias); + virBufferAsprintf(&buf, "\n", alias); =20 if (wwn) virBufferAsprintf(&buf, "%s\n", wwn); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list