From nobody Mon Feb 9 08:33:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617980497; cv=none; d=zohomail.com; s=zohoarc; b=gnArBFs7cfwMdjW+OfALOTzPs/+wqIL18L8Tae3CVuIXu2awKTRd/TRwdCCbKxklh7PMTTVQugKy3dxbG5MkOhPYYqlhQBCQP3QLFc+UkHF2vMifYyad22sK5QVrm6xzWPWudZ6MO4Rh2WOhE2QV1lQI4DPE2y89au2VXvEqlmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617980497; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=obUGxgsf9iQr82m776jCtwjQAmU2M64QyHpZqZUG63w=; b=B551I3Yu+dc37ieWUiByDXkxFM/fDFo4SOCGWHBnvthlgBigbQnLCLNGayKo5ogg80QnT7Q1cKosYscm8ydbw93fzxqoAJY5YcLR9pZ1N8B+0bH7wddm52Jxi1FD/tNLhihBiu+2KTiCKaka6Vy27a2TfApJBRZU4UImpkDUD8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617980497798598.3275835658307; Fri, 9 Apr 2021 08:01:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-_goCWrBOMUyT3SFUbc7IXg-1; Fri, 09 Apr 2021 11:01:29 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22B9AC7441; Fri, 9 Apr 2021 15:00:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F00F65D9C0; Fri, 9 Apr 2021 15:00:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8529E1806D17; Fri, 9 Apr 2021 15:00:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 139EvROu023646 for ; Fri, 9 Apr 2021 10:57:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id E216F14106; Fri, 9 Apr 2021 14:57:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46DC260D79 for ; Fri, 9 Apr 2021 14:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617980495; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=obUGxgsf9iQr82m776jCtwjQAmU2M64QyHpZqZUG63w=; b=Q3crde1VCnAym7y9eGTg+NRxbfp+flaHgFM9cLRcUtuGlz/5/skFlcBymidOL2sTGqo4So Bn3IqkxnjkJ9UK5m9Hr6hPkwyBpYWHQyJoZ+k56IH8hgD+rzOCXA+Rg26vBlOgNFuG8/CH BL50C0CVmJ+WVoI003e7PAA1dArPTWc= X-MC-Unique: _goCWrBOMUyT3SFUbc7IXg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [RFC PATCH 03/43] qemuxml2(argv|xml)test: Don't exit early when testQemuInfoSetArgs fails Date: Fri, 9 Apr 2021 16:56:39 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Set the return code to failure and continue testing. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 07cd522699..15a14be1bb 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -904,7 +904,7 @@ mymain(void) info.qapiSchemaCache =3D qapiSchemaCache; \ if (testQemuInfoSetArgs(&info, capscache, capslatest, \ __VA_ARGS__, ARG_END) < 0) \ - return EXIT_FAILURE; \ + ret =3D -1; \ testInfoSetPaths(&info, _suffix); \ if (virTestRun("QEMU XML-2-ARGV " _name _suffix, \ testCompareXMLToArgv, &info) < 0) \ diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 03cb405123..2b8fca8316 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -134,7 +134,7 @@ mymain(void) ARG_END) < 0 || \ qemuTestCapsCacheInsert(driver.qemuCapsCache, info.qemuCaps) <= 0) { \ VIR_TEST_DEBUG("Failed to generate test data for '%s'", _name)= ; \ - return -1; \ + ret =3D -1; \ } \ \ if (when & WHEN_INACTIVE) { \ --=20 2.30.2