From nobody Tue Dec 16 16:56:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740065321305914.6983029639212; Thu, 20 Feb 2025 07:28:41 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 86274217F; Thu, 20 Feb 2025 10:28:40 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E26732233; Thu, 20 Feb 2025 10:26:47 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 757F32195; Thu, 20 Feb 2025 10:26:42 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C232621B9 for ; Thu, 20 Feb 2025 10:26:32 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-GTgl0CtTMVSmsLVFKC4_0A-1; Thu, 20 Feb 2025 10:26:31 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 744301800373 for ; Thu, 20 Feb 2025 15:26:30 +0000 (UTC) Received: from orkuz (unknown [10.43.3.115]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 01A751800947 for ; Thu, 20 Feb 2025 15:26:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740065192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bns4GOBm3RUuB+e91ZHWHzeolgFxO/7bh5cXTUAAbjs=; b=LrB15kSItTTd9g3E8bohucM65NHFaGYhcxp3m47IxY9WmCgFn8WV3Vjtgqt899JbWf/1VF ithTFRfVTV9vwm+ud/OPWRA4gJVnpllpWW53qVw9D3iqDIe2OHtf/XGVUDEWq2mHGZDgD1 kz77F/Sfgwqy3YRv/xs3TKtgcg+H+8Y= X-MC-Unique: GTgl0CtTMVSmsLVFKC4_0A-1 X-Mimecast-MFC-AGG-ID: GTgl0CtTMVSmsLVFKC4_0A_1740065190 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [PATCH 06/13] virsh: Introduce vshWarn Date: Thu, 20 Feb 2025 16:26:08 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: m7-qOGZYnor3vxLlDl67sYP-GAQ2wPB20TBUttN6otk_1740065190 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SONJJC2AWQAK5RVJRVUV6H5G7PMDKHEB X-Message-ID-Hash: SONJJC2AWQAK5RVJRVUV6H5G7PMDKHEB X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740065321919019000 Content-Type: text/plain; charset="utf-8" This new function can be used for printing warnings about suboptimal usage. Signed-off-by: Jiri Denemark --- tools/virsh-secret.c | 2 +- tools/vsh.c | 13 ++++++++++++- tools/vsh.h | 2 ++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index d9435e4357..6655d3211e 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -235,7 +235,7 @@ cmdSecretSetValue(vshControl *ctl, const vshCmd *cmd) =20 if (base64) { /* warn users that the --base64 option passed from command line is= wrong */ - vshError(ctl, _("Passing secret value as command-line argument is = insecure!")); + vshWarn(ctl, _("Passing secret value as command-line argument is i= nsecure!")); secret_val =3D g_strdup(base64); secret_len =3D strlen(secret_val); } else if (filename) { diff --git a/tools/vsh.c b/tools/vsh.c index 91e2ae2067..812fc81bde 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2144,6 +2144,17 @@ vshError(vshControl *ctl, const char *format, ...) } =20 =20 +void +vshWarn(vshControl *ctl, const char *format, ...) +{ + va_list ap; + + va_start(ap, format); + vshPrintStderr(ctl, VSH_ERR_WARNING, format, ap); + va_end(ap); +} + + void vshEventLoop(void *opaque) { @@ -2501,7 +2512,7 @@ vshAskReedit(vshControl *ctl, const char *msg G_GNUC_UNUSED, bool relax_avail G_GNUC_UNUSED) { - vshDebug(ctl, VSH_ERR_WARNING, "%s", _("This function is not supported= on WIN32 platform")); + vshWarn(ctl, "%s", _("This function is not supported on WIN32 platform= ")); return 0; } #endif /* WIN32 */ diff --git a/tools/vsh.h b/tools/vsh.h index 1c7370dd4f..5970addfb6 100644 --- a/tools/vsh.h +++ b/tools/vsh.h @@ -240,6 +240,8 @@ struct _vshCmdGrp { =20 void vshError(vshControl *ctl, const char *format, ...) G_GNUC_PRINTF(2, 3); +void vshWarn(vshControl *ctl, const char *format, ...) + G_GNUC_PRINTF(2, 3); void vshOpenLogFile(vshControl *ctl); void vshOutputLogFile(vshControl *ctl, int log_level, const char *msg); void vshCloseLogFile(vshControl *ctl); --=20 2.48.1