From nobody Thu Mar 28 20:34:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634045777; cv=none; d=zohomail.com; s=zohoarc; b=XSz15ilt1Gjzu3B1Gv/PfHBTT7pLb9/E0+ZIF3tY+z5KavqKBfemVWkRlYpLuPsfSgrVV2lYaps5GrmnhxB7YlOHbwCWq8jdPNiuC5E+lwTC3Lhm2ZDtTXGvC6znSV+k5EnKpMFFQ3vW+zWpoD4ppcylhEgnZAvLKG7fy+d53mE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634045777; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=padltTNbPF1c6q9dweIE3Iyv2wQu9NzXLB9hYgPD95M=; b=IbSMMPtJlQBc5yMo3okprxhk++J+9cQtizhZU88hFxiYhlYgfosu7dM2EgX9f22OLbd56R5o2SNyja/kdVOQoWhaRuUlsPKjS0ES325d3mchwmPVACkFMwCE2z1MvLY5fDzz+JEv2jNlhNsznIamAWQsV5I+wGpBd32e3LgwyUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1634045777711707.64467698055; Tue, 12 Oct 2021 06:36:17 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-0GKlvl56NbatrdQeIIZUwA-1; Tue, 12 Oct 2021 09:36:13 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C44061007922; Tue, 12 Oct 2021 13:36:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7DE2E1001B2C; Tue, 12 Oct 2021 13:36:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D0F3C1809C81; Tue, 12 Oct 2021 13:35:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19CDZvSY032564 for ; Tue, 12 Oct 2021 09:35:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id D5B1D5D9DD; Tue, 12 Oct 2021 13:35:57 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FF255D9D5 for ; Tue, 12 Oct 2021 13:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634045776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=padltTNbPF1c6q9dweIE3Iyv2wQu9NzXLB9hYgPD95M=; b=gxNwZTBFTikCgzUy/CmrMKdLqC197psVCsDg2u9PhiBEA8FARS4vfqyxw7c0vTq2YcOQtS c3SpymnSqQtINHSV75g4g6pyBi/Nj6EP3ykfmLquKt7Z13fPWluyZBoqF6Xn6beDeM9lii Xu4IjnlABRUjJAMCveNziMubZZika3Y= X-MC-Unique: 0GKlvl56NbatrdQeIIZUwA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: correctly pass qemuBuildVHostUserFsDevProps Date: Tue, 12 Oct 2021 15:35:47 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634045778323100001 ../../work/libvirt/src/qemu/qemu_hotplug.c: In function =E2=80=98qemuDomain= AttachFSDevice=E2=80=99: ../../work/libvirt/src/qemu/qemu_hotplug.c:3458:68: error: ordered comparis= on of pointer with integer zero [-Werror=3Dextra] 3458 | if (qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv) = < 0) | ^ cc1: all warnings being treated as errors Fixes: b98787303498cfb8426ab27ee62247b164101242 Signed-off-by: J=C3=A1n Tomko --- Pushed as a build-breaker fix. Surprisingly, clang does not seem to mind the comparison. src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b113a5bc1e..af49e58f8e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3455,7 +3455,7 @@ qemuDomainAttachFSDevice(virQEMUDriver *driver, =20 charAlias =3D qemuDomainGetVhostUserChrAlias(fs->info.alias); =20 - if (qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv) < 0) + if (!(devprops =3D qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias= , priv))) goto cleanup; =20 if (!fs->sock) { --=20 2.31.1