From nobody Sat May 4 20:02:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596454748; cv=none; d=zohomail.com; s=zohoarc; b=U3vcxnbtE6m3vfAaK3Z5ABDxFiJkL1bV2rPDWNnm1MPGVBxJ5Rk9z02vxQsxPXCb/naEMzlZCAFdfaoIanBN1tyWL+K7t5g4oPrVe4EWHTFKdBzou72T9yoWu82P/2PUmz0x+kCr858YYhVDpGK1grnY0MT8Brjhp3Q0HnYYAtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596454748; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Wdt/xE1vvI0efXnPYYR16gNh/ITohUWa9kIc3ae3XgQ=; b=T5Flu8dFtyb7ruyYKDz5rgCj/OV5dwz+QWjTSldMO4YwXQJaLn9lE7fNpg6G2SR0/9lrdK7kY+Kc3ZcGR9xwX8HNVRR1Ck7TwUb4lmD89LER3OkPrzj9t1NvGPMvkgSHQg3bWmpI+vv68NJJkXaAWR1pZWPR8X6X1kkICcIEl90= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 159645474886892.80676807940438; Mon, 3 Aug 2020 04:39:08 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-poGIxVt7PuC4KtG6uY4dTw-1; Mon, 03 Aug 2020 07:39:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09FC6100A8C0; Mon, 3 Aug 2020 11:38:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BF1E712EB; Mon, 3 Aug 2020 11:38:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 20AEC9A10B; Mon, 3 Aug 2020 11:38:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 073Bcrli027858 for ; Mon, 3 Aug 2020 07:38:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5E9A7177F9; Mon, 3 Aug 2020 11:38:53 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9705717150 for ; Mon, 3 Aug 2020 11:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596454747; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Wdt/xE1vvI0efXnPYYR16gNh/ITohUWa9kIc3ae3XgQ=; b=dSW22VTSaJeMlrkznBdYHc+3ML0ir91WrfGbnRxNHu1C54ch46A6o4P5YuoGxVBEH0Ol7K aBTqmHLeZkTsB8Mm+P3PMBVfF1uoWvLxta8XeVxP/j0AzmHsAWCpG56JymDsqh/voGDn/Z wPieDs0yW2aCo8pZ+r+FrRVM1dn7eJk= X-MC-Unique: poGIxVt7PuC4KtG6uY4dTw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] util: cgroup: remove unused opts in virCgroupV2BindMount Date: Mon, 3 Aug 2020 13:38:47 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) In virCgroupV2BindMount there is an unused variable containing what seem to be tmpfs mount options. Delete it. Unlike with cgroups v1, we do not create a tmpfs here. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Pavel Hrdina --- src/util/vircgroupv2.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 80f596542c..bf6b4a298c 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -548,9 +548,8 @@ virCgroupV2KillRecursive(virCgroupPtr group, static int virCgroupV2BindMount(virCgroupPtr group, const char *oldroot, - const char *mountopts) + const char *mountopts G_GNUC_UNUSED) { - g_autofree char *opts =3D NULL; g_autofree char *src =3D NULL; =20 VIR_DEBUG("Mounting cgroups at '%s'", group->unified.mountPoint); @@ -561,8 +560,6 @@ virCgroupV2BindMount(virCgroupPtr group, return -1; } =20 - opts =3D g_strdup_printf("mode=3D755,size=3D65536%s", mountopts); - src =3D g_strdup_printf("%s%s", oldroot, group->unified.mountPoint); =20 if (mount(src, group->unified.mountPoint, "none", MS_BIND, NULL) < 0) { --=20 2.26.2