From nobody Mon Feb 9 03:42:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695225910; cv=none; d=zohomail.com; s=zohoarc; b=ZDHPQq4gPt6V5pynMckCTWCbt07wy/NLjDH8zEqDrwumL/jYqOlf057Mz63DRsiwJPg7az2KrkfFo7xPxnf8Eli+V7s2HlrDMD5UEcmpQjDrCgjAqtoXvlsvRKF67xXnJEJ2uBr7WZNeUrbplfx6shV4rHmbE06uOk+J5JSRWpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695225910; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ID2uD7Cmg+KMoEk7b9FtDVprCSxNurKe9tw0vd5Wrz8=; b=Bk/os8bIGJyXUr2Lk3oZqjWEp6iH+9n5JUER2Z2DsxeG3JbTUBUO5/C+xMXmYP9WF/vJzwxJVRRfdgI4iBzjQpun3HtXD/VA1xhvNpkNBwCVORazprxw4gnIHV2lUKdrZhNjXeRqUl82admKxxpYBN2VDmJmlNoxUEcgHJHOLcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695225910616894.9789904085621; Wed, 20 Sep 2023 09:05:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-222-Px6M6RqtMrSri0dhUGes3Q-1; Wed, 20 Sep 2023 12:05:01 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE05C3C0DF7D; Wed, 20 Sep 2023 16:04:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C813EC15BB8; Wed, 20 Sep 2023 16:04:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AC3F41946594; Wed, 20 Sep 2023 16:04:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5B1EA194658D for ; Wed, 20 Sep 2023 16:04:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 016471005E27; Wed, 20 Sep 2023 16:04:40 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.2.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D08710F1BE7 for ; Wed, 20 Sep 2023 16:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695225909; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ID2uD7Cmg+KMoEk7b9FtDVprCSxNurKe9tw0vd5Wrz8=; b=fZ4vk4yx4WhguoBm0nfdTBH5HoQfAqPj825ZAZ/YT9NaJedbSzzbnhbQ+3mRkJTCT1PGwe 0813uvFSkerE0bpaubzhYzUAT8R12ioVFSBA/9pOLkBaZX0ZwTgfmZCninyHrylEq2Zl+4 4aADlV1yzwj9qqS2PrilcFo+6H4Uhg4= X-MC-Unique: Px6M6RqtMrSri0dhUGes3Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] test_driver: Implement virConnectGetDomainCapabilities() Date: Wed, 20 Sep 2023 18:04:38 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695225912717100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Our test driver lacks implementation for virConnectGetDomainCapabilities(). Provide one, though a trivial one. Mostly so that something else than VIR_ERR_NO_SUPPORT error is returned. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/test/test_driver.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c1d4d71b78..a8705a8da2 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -10000,6 +10000,41 @@ testNetworkSetMetadata(virNetworkPtr net, return ret; } =20 +static char * +testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, + const char *emulatorbin, + const char *arch_str, + const char *machine, + const char *virttype_str, + unsigned int flags) +{ + g_autoptr(virDomainCaps) domCaps =3D NULL; + virArch arch =3D VIR_ARCH_NONE; + int virttype =3D VIR_DOMAIN_VIRT_NONE; + + virCheckFlags(0, NULL); + + if (arch_str && + (arch =3D virArchFromString(arch_str)) =3D=3D VIR_ARCH_NONE) { + virReportError(VIR_ERR_INVALID_ARG, + _("unknown architecture: %1$s"), arch_str); + return NULL; + } + + if (virttype_str && + (virttype =3D virDomainVirtTypeFromString(virttype_str)) < 0) { + virReportError(VIR_ERR_INVALID_ARG, + _("unknown virttype: %1$s"), virttype_str); + return NULL; + } + + if (!(domCaps =3D virDomainCapsNew(emulatorbin, machine, arch, virttyp= e))) + return NULL; + + return virDomainCapsFormat(domCaps); +} + + /* * Test driver */ @@ -10167,6 +10202,7 @@ static virHypervisorDriver testHypervisorDriver =3D= { .domainCheckpointGetParent =3D testDomainCheckpointGetParent, /* 5.6.0= */ .domainCheckpointDelete =3D testDomainCheckpointDelete, /* 5.6.0 */ .domainGetMessages =3D testDomainGetMessages, /* 7.6.0 */ + .connectGetDomainCapabilities =3D testConnectGetDomainCapabilities, /*= 9.8.0 */ }; =20 static virNetworkDriver testNetworkDriver =3D { --=20 2.41.0