From nobody Mon Feb 9 01:47:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864226; cv=none; d=zohomail.com; s=zohoarc; b=SceqLtVBpcyw6vQPvl33flPVQTy5iSDDNPlMHMGCaXFTDDrFktKsoT6mkxZiQlB4B2IWMBBFE2sErPbd4UJzYVG5Yt4lFiFXjKnzbGnufikgTBb1BvmPMwHf77eTyMhdQ83sg57dP4NDWf1BaBYYvbblZVYA2WkeEvoLPmLFl28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864226; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qRJySnh4m3hZa94WoOgqA5MKJrSaFzgno7CGUgIhQGc=; b=dR/w85tgnFNULm0wKx25nmXxMmv9t7kTy2LX/vicfVCEpN5shT1h/+0vSdoISNL92i+JFeD4HoyXdYWYINpPfG/0P7F6J8Lh0GQzmRweiIOQK955lsynmeEBKWC0xAh9NTnRVR+kuVb/78125+GjuY/Cs2nO7Zn9/msaoWQQayw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162686422638725.761436322497275; Wed, 21 Jul 2021 03:43:46 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-0F_j6U1jPmqF4IZcXTjGLg-1; Wed, 21 Jul 2021 06:43:44 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D95693929; Wed, 21 Jul 2021 10:43:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3E32119D9B; Wed, 21 Jul 2021 10:43:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DAD1C4A703; Wed, 21 Jul 2021 10:43:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAhGbZ000978 for ; Wed, 21 Jul 2021 06:43:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3ADCD19D9B; Wed, 21 Jul 2021 10:43:16 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A6B519C79 for ; Wed, 21 Jul 2021 10:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864225; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qRJySnh4m3hZa94WoOgqA5MKJrSaFzgno7CGUgIhQGc=; b=cdB9tLpVD8dATeztlgabWVzb/+F8Il1moAxSZPrZ1pi2LQYtrh92RknclY5cTk0w+n8iFS NCwNEU3aHp635pmpYFnoek3TIzPAPEWzIMjqanbo2PDnTU3phC87SDzEzGFFGntpwtj/Ux dSKsKnIo1Ek1GTE8iJ3OZTyYwtbP/kM= X-MC-Unique: 0F_j6U1jPmqF4IZcXTjGLg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 22/33] qemu: Remove return value from qemuMonitorDomainSerialChangeCallback Date: Wed, 21 Jul 2021 12:42:34 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864228021100001 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 10 +++++----- src/qemu/qemu_process.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 7f6a0a71ee..0db2c69ec5 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -247,11 +247,11 @@ typedef void (*qemuMonitorDomainNicRxFilterChangedCal= lback)(qemuMonitor *mon, const char *de= vAlias, void *opaque); -typedef int (*qemuMonitorDomainSerialChangeCallback)(qemuMonitor *mon, - virDomainObj *vm, - const char *devAlias, - bool connected, - void *opaque); +typedef void (*qemuMonitorDomainSerialChangeCallback)(qemuMonitor *mon, + virDomainObj *vm, + const char *devAlias, + bool connected, + void *opaque); typedef int (*qemuMonitorDomainSpiceMigratedCallback)(qemuMonitor *mon, virDomainObj *vm, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 57eca2906f..26a88069c0 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1521,7 +1521,7 @@ qemuProcessHandleNicRxFilterChanged(qemuMonitor *mon = G_GNUC_UNUSED, } -static int +static void qemuProcessHandleSerialChanged(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, const char *devAlias, @@ -1552,7 +1552,7 @@ qemuProcessHandleSerialChanged(qemuMonitor *mon G_GNU= C_UNUSED, cleanup: virObjectUnlock(vm); - return 0; + return; error: qemuProcessEventFree(processEvent); goto cleanup; --=20 2.31.1