From nobody Sun Feb 8 19:55:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637760586; cv=none; d=zohomail.com; s=zohoarc; b=nN558ZCkMHnFwNwR/xrx5u3SoTgiTsDjudCfoWjiAo+/T5qXG7TORO78GXlDilzJWd+evw6ffCnF8c7tWcnOuuAZE8Hl5l5zWhuK7plerLwLNVKzQNFnWSQWvKqs8m4wPZTRaEUmLOcXTGpddjaAGY4aW+QPzShDxExTu0f5EIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637760586; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/EYULd4Ro3nW8ssAPeaTD5o1IFSjmBpkJahyMuYUgBI=; b=Hwm+B2usgjp0lws02ccjGJVx+RF8vC2bRSlFsXC0V9KNhBcNPMfEajIcAsnsCYiy4qdkn+qo9AaHDJ7X3qQwnJTPrGgAYPpptSUIFV6/DWKhiKkvi7cK4f5NFO8PPfzUpxPaRT2bN2LV71R0b5Kp4X6IBVZ7/By8wQDtvz1MsxY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1637760586205507.41471871519514; Wed, 24 Nov 2021 05:29:46 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-46-BXq5zBUgPXSp5yZ5Zj3Fxg-1; Wed, 24 Nov 2021 08:29:42 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B8E51006AA3; Wed, 24 Nov 2021 13:29:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2C0760CC9; Wed, 24 Nov 2021 13:29:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B75434A707; Wed, 24 Nov 2021 13:29:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AODTLh4012581 for ; Wed, 24 Nov 2021 08:29:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5EF5418171; Wed, 24 Nov 2021 13:29:21 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBF545D9CA for ; Wed, 24 Nov 2021 13:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637760584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/EYULd4Ro3nW8ssAPeaTD5o1IFSjmBpkJahyMuYUgBI=; b=NCpM/OzMRTUNFNyyNc3tEtTAuKmLtHY1DkSHXihGv8xTCmhLyQz6NazZu276NyfhdWtlqL QMv1H8mviDcNoIU+6VpYuCUk1A0jFSyA5cWSvnztyacdAkClvqjjHTFeE4EF0lUwRA843Q 3JC0D7WalkDXCUPLWV4mSYvPYUyFgt8= X-MC-Unique: BXq5zBUgPXSp5yZ5Zj3Fxg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/7] qemu: qemuDomainObjExitMonitor: do not warn on unused result Date: Wed, 24 Nov 2021 14:28:49 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637760586992100002 This wrapper for qemuDomainObjExitMonitorInternal was extended by my commit dc2fd51fd727bbb6de172e0ca4b7dd307bb99180 to check whether the domain is still alive, because we were observing crashes if the QEMU process died while some of our APIs were in the monitor and the thread processing the EOF event freed the domain definition. This bug was fixed by: commit 81f50cb92d16643bcd749e3ab5b404b8b7cec643 qemu: Avoid calling qemuProcessStop without a job but we kept checking for the return value since. Remove the G_GNUC_WARN_UNUSED_RESULT attribute since all of the calls that could set def->id to -1 are protected by qemuProcessBeginStopJob and cannot happen while we have a job in the monitor. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_domain.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 6728ab047e..596add616d 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -489,8 +489,7 @@ void qemuDomainObjEnterMonitor(virQEMUDriver *driver, ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); int qemuDomainObjExitMonitor(virQEMUDriver *driver, virDomainObj *obj) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) - G_GNUC_WARN_UNUSED_RESULT; + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); int qemuDomainObjEnterMonitorAsync(virQEMUDriver *driver, virDomainObj *obj, qemuDomainAsyncJob asyncJob) --=20 2.31.1