From nobody Sun Oct 5 01:49:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757491626; cv=none; d=zohomail.com; s=zohoarc; b=cBJ+A5IqkM6TMoRZfIHEb1HEGaItJz/Xw2BJqP2mRgoIMxhfUhDPyRP0t5QDnY7M8+Yos/zVPMh1P6dOhGY/cqeZMf+Bf/20ve0H0q4ziHq8ryJbaJHh7dI86UP7pXcGvuhBRm78sdlTMeSOY8SNWi3pDit1HL5Vc1sdUsSrPws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757491626; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qzFLM4Lx+6KndgUEkuhue3s1RX1hfkom63PcBcTcO0M=; b=AbmrR7X8VTa0YnrXX0Ap6eJrZqOK6jb6/uQaJ1tytWd76OT7FYGgMPWfTZ8ccRlaIXi2Ffrjcu6CQ8vv7WRFaoGLX4JVvfNTguFCS8qSroViWB2b2Jfxj7LeVHwe/11NCoTzGYOosW2xS6ivRdPgZpwOz0br17SaA5jxTP1KdjQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757491626877163.48510877775163; Wed, 10 Sep 2025 01:07:06 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 631E841B76; Wed, 10 Sep 2025 04:07:06 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B46F543DDE; Wed, 10 Sep 2025 04:04:56 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0218641A9E; Wed, 10 Sep 2025 04:03:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 026AB41A9A for ; Wed, 10 Sep 2025 04:03:51 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-cH35xf3uNn6w1zobmdw_4A-1; Wed, 10 Sep 2025 04:03:50 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9FC6D195608B for ; Wed, 10 Sep 2025 08:03:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F1EAE19560AB for ; Wed, 10 Sep 2025 08:03:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757491431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qzFLM4Lx+6KndgUEkuhue3s1RX1hfkom63PcBcTcO0M=; b=G8eQW2XCGNJug15Oj3NfjPfS84/4ez/XmXaGeWqKn3C92pyOEAVSSzEiiavFKksGfndDxA SooQPiOhCZXg5+ZKoh8MiPT6ll1nQyIrw/SejwCSi1ChAYs1ueVb8Z+qee6D+MPE33c7oO DHscXgUfmEIJndB5WKGmURsRW4buX8w= X-MC-Unique: cH35xf3uNn6w1zobmdw_4A-1 X-Mimecast-MFC-AGG-ID: cH35xf3uNn6w1zobmdw_4A_1757491429 To: devel@lists.libvirt.org Subject: [PATCH 3/4] ch: Drop useless variable in chDomainFindDisk() Date: Wed, 10 Sep 2025 10:03:40 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HdQZDXWyOIavcZxVy54ga7wihOafRK9Zc0eQHUjLQvo_1757491429 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JCJMU2KLIFNCY3J4XEFSGM2W2WPDXU5A X-Message-ID-Hash: JCJMU2KLIFNCY3J4XEFSGM2W2WPDXU5A X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757491636121154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The 'disk' variable inside of chDomainFindDisk() is not used really. Drop it. Signed-off-by: Michal Privoznik --- src/ch/ch_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c index aa723dd123..cfa11cc5e5 100644 --- a/src/ch/ch_hotplug.c +++ b/src/ch/ch_hotplug.c @@ -185,7 +185,6 @@ chDomainFindDisk(virDomainObj *vm, virDomainDiskDef *match, virDomainDiskDef **detach) { - virDomainDiskDef *disk; int idx; =20 if ((idx =3D chFindDiskId(vm->def, match->dst)) < 0) { @@ -193,7 +192,7 @@ chDomainFindDisk(virDomainObj *vm, _("disk %1$s not found"), match->dst); return -1; } - *detach =3D disk =3D vm->def->disks[idx]; + *detach =3D vm->def->disks[idx]; =20 return 0; } --=20 2.49.1