From nobody Mon Feb 9 01:40:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571415114; cv=none; d=zoho.com; s=zohoarc; b=dHiu+07I0WDzS8lzak0VEoY+gJY/yCmXqUfj55BBp9QUUX3tB9t4ca7JpXwbhsoLrxc4ZAFK7EoOzKvAINMT/rdVqC1u1HMey+ZnQ+aXw53K5b5dnoGq4Qc0p8pbudri+mA6bda0ZBVCN8I5JNm2nU1VtE7+q5nR/E+lE5Xd2xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571415114; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9SMcqLSyjl82BqLeFLHOhmjt1StFoYOvh+UAj0P8ruk=; b=hSxtE2dzMJC/OjUxZyE2roL0IRX/31qUvvmIB8/Yj4Jq117QqSgzBr7iSVj+VZZo0OFXzhLlplpHGgLfQ/TkFdMMRT7xbMuK/rKm5EIrRmTcnfxW42wN5bJ5G9dFUMD3PC7J/wp/JoWMkojNM0GFwKX6YF3E8HsiDpmjtT04xxE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571415114798578.2519272110848; Fri, 18 Oct 2019 09:11:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 411A210CC216; Fri, 18 Oct 2019 16:11:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1565F100EBD6; Fri, 18 Oct 2019 16:11:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CA51D180BAA7; Fri, 18 Oct 2019 16:11:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9IGBenV004626 for ; Fri, 18 Oct 2019 12:11:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1BD396012A; Fri, 18 Oct 2019 16:11:40 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7190560161; Fri, 18 Oct 2019 16:11:39 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 18 Oct 2019 18:10:56 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH RFC 11/40] conf: Remove unused virDomainDiskFindByBusAndDst X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Fri, 18 Oct 2019 16:11:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Previous commit removed last use of this function so we can get rid of it.t Signed-off-by: Peter Krempa Reviewed-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 21 --------------------- src/conf/domain_conf.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 25 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1fffd56a22..e12d676a8c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8566,27 +8566,6 @@ virDomainDeviceFindSCSIController(const virDomainDef= *def, return NULL; } -virDomainDiskDefPtr -virDomainDiskFindByBusAndDst(virDomainDefPtr def, - int bus, - char *dst) -{ - size_t i; - - if (!dst) - return NULL; - - for (i =3D 0; i < def->ndisks; i++) { - if (def->disks[i]->bus =3D=3D bus && - STREQ(def->disks[i]->dst, dst)) { - return def->disks[i]; - } - } - - return NULL; -} - - int virDomainDiskDefAssignAddress(virDomainXMLOptionPtr xmlopt, virDomainDiskDefPtr def, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 690aa3c84b..071de9e71e 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2859,9 +2859,6 @@ void virDomainDiskSetFormat(virDomainDiskDefPtr def, = int format); virDomainControllerDefPtr virDomainDeviceFindSCSIController(const virDomainDef *def, virDomainDeviceInfoPtr info); -virDomainDiskDefPtr virDomainDiskFindByBusAndDst(virDomainDefPtr def, - int bus, - char *dst); virDomainControllerDefPtr virDomainControllerDefNew(virDomainControllerTyp= e type); void virDomainControllerDefFree(virDomainControllerDefPtr def); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 2379c1ed8b..fdfe1e7295 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -345,7 +345,6 @@ virDomainDiskDiscardTypeToString; virDomainDiskEmptySource; virDomainDiskErrorPolicyTypeFromString; virDomainDiskErrorPolicyTypeToString; -virDomainDiskFindByBusAndDst; virDomainDiskGeometryTransTypeFromString; virDomainDiskGeometryTransTypeToString; virDomainDiskGetDetectZeroesMode; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list