From nobody Mon Feb 9 10:54:39 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710511364261299.2093478849979; Fri, 15 Mar 2024 07:02:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 022F52158; Fri, 15 Mar 2024 10:02:42 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D82121C92; Fri, 15 Mar 2024 09:46:11 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C89DA1B94; Fri, 15 Mar 2024 09:45:31 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 659A21BAB for ; Fri, 15 Mar 2024 09:44:47 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-ycGlOFciPMi4qt2NA9bJrQ-1; Fri, 15 Mar 2024 09:44:45 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F1A8101A526 for ; Fri, 15 Mar 2024 13:44:45 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC935C1576F for ; Fri, 15 Mar 2024 13:44:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: ycGlOFciPMi4qt2NA9bJrQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 22/28] virsh: volume: Mark optional 'pool' argument as 'positional' Date: Fri, 15 Mar 2024 14:44:17 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 7APMD3FGV6DPX4ZFSDUDZBRTXSEYZDEW X-Message-ID-Hash: 7APMD3FGV6DPX4ZFSDUDZBRTXSEYZDEW X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710511364788100001 Annotate arguments which can be unintentionally parsed positionally. (See previous commits for explanation.) The pool name is optional but in all cases it can be promoted to an optional positional argument so that it can be properly aligned with the expectations of the parser. Signed-off-by: Peter Krempa --- tools/virsh-volume.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 8794126f21..7e6c6d5ef5 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -49,6 +49,7 @@ #define VIRSH_COMMON_OPT_POOL_OPTIONAL \ {.name =3D "pool", \ .type =3D VSH_OT_STRING, \ + .positional =3D true, \ .help =3D N_("pool name or uuid"), \ .completer =3D virshStoragePoolNameCompleter, \ .completer_flags =3D VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE, \ --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org