From nobody Mon Feb 9 05:24:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732782794229850.3755429800651; Thu, 28 Nov 2024 00:33:14 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A7CCEC18; Thu, 28 Nov 2024 03:33:13 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 68FCB1826; Thu, 28 Nov 2024 03:32:37 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 431C217CB; Thu, 28 Nov 2024 03:32:35 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BBF9F178F for ; Thu, 28 Nov 2024 03:32:34 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-j4CFKL7LPRSnEMPKnKoF8A-1; Thu, 28 Nov 2024 03:32:32 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88135195609F for ; Thu, 28 Nov 2024 08:32:31 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8FF4F195605A for ; Thu, 28 Nov 2024 08:32:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732782754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UTM4IloUwECuFz421HVSej9ecpc0UEgwjFWB++HbjI=; b=bAYSczpvQdy8QHs7bVIb5Ee1YdrU1rNfrYpU7lrUAA9rB/2gT/13w3ZyzvL5KbkdOUUfbg A3FVqF3MWiI8PXPJCIItvSFiI5qS1B2z4x8mRbSiicyb6gxfI6Z2/+dDPDIOpgkT2ezOVH JQjJlgSV8tbCJ2ko/JjK5q2Ewrj6j1o= X-MC-Unique: j4CFKL7LPRSnEMPKnKoF8A-1 X-Mimecast-MFC-AGG-ID: j4CFKL7LPRSnEMPKnKoF8A From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/5] schemas: domain: Make subelement of NFS disk source optional Date: Thu, 28 Nov 2024 09:32:23 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MxyYdKrPalH89XYcuV9VVGx_hxK_cII2i2hy0YwE4sU_1732782751 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3P4JQSSQCLG6EWMJYOPMOZJ4SZFTAQG6 X-Message-ID-Hash: 3P4JQSSQCLG6EWMJYOPMOZJ4SZFTAQG6 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732782794890019100 Content-Type: text/plain; charset="utf-8" Both the 'user' and 'group' attribute are optional so can be empty. Allow it to be omitted completely. The parser and qemu code can handle that. The schema was introduced in 943871f971d680f72726a9d6e9330eec264f6588 and in d018c8dc9ebcd0496c7a564bc2e8b1c9cbd8d96f an offending test was added. Fixes: 943871f971d680f72726a9d6e9330eec264f6588 Fixes: d018c8dc9ebcd0496c7a564bc2e8b1c9cbd8d96f Signed-off-by: Peter Krempa --- src/conf/schemas/domaincommon.rng | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 7415c37b65..b3fdbf7ffb 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -2010,18 +2010,20 @@ - - - - - - - - - - - - + + + + + + + + + + + + + + --=20 2.47.0