From nobody Sun Feb 8 18:32:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612186784; cv=none; d=zohomail.com; s=zohoarc; b=gQMnfr07kgslMdP89a4ZKASg2Ib33Ej89ZK8Bewsymd6MXWpR9V5unZmY9RBPF5VLQ3mK0Qb09QjURGdb9NSnnymw4tGNXlUNQKhdCfXfYOZt90IBvaSQih/E7PppL8yBEwRtKlSBjNxR/XWsTJFJzDb02dyXN2x3RZ94m7RkHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612186784; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UP0qEjoYsVCg/kScBK6+qZPcb6+maCwdBHc3d8nQ1Ok=; b=TqhFwTQtsiDyg17QGPfCfRE7w019o8n3ObPDULkoY4YiHT4sdcJOOTKIvpPIApCwMHWZ1eRuDHSkmCGjEunxmM6QRkJZmyUD4bpHkwYHSHDm2V00FqdhVNy8t2H0JbN0XJmyMjVdrEPyrVzFUkHT7M46j4BldzoCCML+TVleLDY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612186784124776.1831257277719; Mon, 1 Feb 2021 05:39:44 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-w8215WvAOaGd-ny6IT5cxw-1; Mon, 01 Feb 2021 08:39:40 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40F3A84A5E3; Mon, 1 Feb 2021 13:39:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16FD71975E; Mon, 1 Feb 2021 13:39:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D2F1F1809CA8; Mon, 1 Feb 2021 13:39:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111DdV8S023576 for ; Mon, 1 Feb 2021 08:39:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id ABED560C69; Mon, 1 Feb 2021 13:39:31 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05FA860C66 for ; Mon, 1 Feb 2021 13:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612186783; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UP0qEjoYsVCg/kScBK6+qZPcb6+maCwdBHc3d8nQ1Ok=; b=fCs08tpoD+tfQ2tgjNigRBIGU7IpAFvNqFjq28UP5QRdyf3/GcUYsKOvRuGmMoF5VyBAwk 3oJUwb9UAbW4WCJrE+ZTBlzXWIEjYOJ2ijfnCU6lHu5gSeNQLEIVnqZr0yxn+2AjJI9qKm pabsiXvaDTw2gh3Ud/CJGKiTUMHv8ec= X-MC-Unique: w8215WvAOaGd-ny6IT5cxw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 12/14] storageBackendCreateQemuImgSecretPath: Use memset instead of VIR_DISPOSE_N Date: Mon, 1 Feb 2021 14:39:04 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Clear out the value using an explicit memset and free it with g_free so that VIR_DISPOSE_N can be phased out. Signed-off-by: Peter Krempa --- src/storage/storage_util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 3d8de16341..303ba5fa70 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -1314,7 +1314,10 @@ storageBackendCreateQemuImgSecretPath(virStoragePool= ObjPtr pool, cleanup: virObjectUnref(conn); - VIR_DISPOSE_N(secret, secretlen); + if (secret) { + memset(secret, 0, secretlen); + g_free(secret); + } return secretPath; --=20 2.29.2