From nobody Wed Mar 12 17:29:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740587676647373.7262310324884; Wed, 26 Feb 2025 08:34:36 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 78C6D16F4; Wed, 26 Feb 2025 11:34:35 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 067471789; Wed, 26 Feb 2025 11:31:43 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id D8BB718A5; Wed, 26 Feb 2025 11:31:39 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1F7871705 for ; Wed, 26 Feb 2025 11:31:28 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-0IwNGB5qMKScQoT2mWz63A-1; Wed, 26 Feb 2025 11:31:26 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A66B61801A0D for ; Wed, 26 Feb 2025 16:31:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.10]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD347180035E for ; Wed, 26 Feb 2025 16:31:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740587487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5UQY8GeSCZ0ZugssMZLzWp5zJOLxxT+IkMWhFOZQb5o=; b=C/TNI5wZsgcUdRwZtpq4edtQwrp2OX+l3BriCJ4JtgrRVXv9V9W56FTrZuRRvgydjtJy4S nw1SIuB4hhuhdF0Wbbp9AQ+NyVxnbMLWXqLrRsRnzedySQwQ7hwsMrp3B1GS9mWKh6lcOV H3Y1Rr3ZDkz6fKOVwRMEiUNprFQv6rg= X-MC-Unique: 0IwNGB5qMKScQoT2mWz63A-1 X-Mimecast-MFC-AGG-ID: 0IwNGB5qMKScQoT2mWz63A_1740587485 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 09/10] qemuDomainGetGuestInfo: Convert hostname code to virTypedParamList Date: Wed, 26 Feb 2025 17:31:09 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: W_KmwmvVb0XbZO_7fUTa5JMPa2UsPoWKc0sQGuVAeFU_1740587485 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PJSARBPHSQ2PNH5NYLB6HCHFDGCHDFOS X-Message-ID-Hash: PJSARBPHSQ2PNH5NYLB6HCHFDGCHDFOS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740587679417019100 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cd07d3eac5..5d91bd1a93 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19356,7 +19356,6 @@ qemuDomainGetGuestInfo(virDomainPtr dom, virDomainObj *vm =3D NULL; qemuAgent *agent; int ret =3D -1; - int maxparams =3D 0; g_autofree char *hostname =3D NULL; unsigned int supportedTypes; bool report_unsupported =3D types !=3D 0; @@ -19415,9 +19414,8 @@ qemuDomainGetGuestInfo(virDomainPtr dom, qemuAgentGetHostname(agent, &hostname, report_unsupported) =3D=3D = -1) goto exitagent; - if (hostname && - virTypedParamsAddString(params, nparams, &maxparams, "hostname", h= ostname) < 0) - goto exitagent; + if (hostname) + virTypedParamListAddString(list, hostname, "hostname"); if (supportedTypes & VIR_DOMAIN_GUEST_INFO_FILESYSTEM) { rc =3D qemuAgentGetFSInfo(agent, &agentfsinfo, report_unsupported); --=20 2.48.1