From nobody Mon Feb 9 15:10:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1552924567761160.2102825262607; Mon, 18 Mar 2019 08:56:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AECC0308FEC2; Mon, 18 Mar 2019 15:56:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78378605C9; Mon, 18 Mar 2019 15:56:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 296B53D38B; Mon, 18 Mar 2019 15:56:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x2IFtdvX022705 for ; Mon, 18 Mar 2019 11:55:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id D0CF51001E6A; Mon, 18 Mar 2019 15:55:39 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 596BE1001E61 for ; Mon, 18 Mar 2019 15:55:39 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 18 Mar 2019 16:55:05 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 16/34] tests: Use full force of our VIR_AUTO* machinery in testBackingXMLjsonXML X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 18 Mar 2019 15:56:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/qemublocktest.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index f40cba36cd..b1d1ed943c 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -43,14 +43,14 @@ static int testBackingXMLjsonXML(const void *args) { const struct testBackingXMLjsonXMLdata *data =3D args; - xmlDocPtr xml =3D NULL; - xmlXPathContextPtr ctxt =3D NULL; - virBuffer buf =3D VIR_BUFFER_INITIALIZER; - virJSONValuePtr backendprops =3D NULL; - virJSONValuePtr wrapper =3D NULL; - char *propsstr =3D NULL; - char *protocolwrapper =3D NULL; - char *actualxml =3D NULL; + VIR_AUTOPTR(xmlDoc) xml =3D NULL; + VIR_AUTOPTR(xmlXPathContext) ctxt =3D NULL; + VIR_AUTOCLEAN(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; + VIR_AUTOPTR(virJSONValue) backendprops =3D NULL; + VIR_AUTOPTR(virJSONValue) wrapper =3D NULL; + VIR_AUTOFREE(char *) propsstr =3D NULL; + VIR_AUTOFREE(char *) protocolwrapper =3D NULL; + VIR_AUTOFREE(char *) actualxml =3D NULL; int ret =3D -1; VIR_AUTOUNREF(virStorageSourcePtr) xmlsrc =3D NULL; VIR_AUTOUNREF(virStorageSourcePtr) jsonsrc =3D NULL; @@ -104,15 +104,6 @@ testBackingXMLjsonXML(const void *args) ret =3D 0; cleanup: - VIR_FREE(propsstr); - VIR_FREE(protocolwrapper); - VIR_FREE(actualxml); - virJSONValueFree(backendprops); - virJSONValueFree(wrapper); - virBufferFreeAndReset(&buf); - xmlXPathFreeContext(ctxt); - xmlFreeDoc(xml); - return ret; } --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list