From nobody Sun Feb 8 17:03:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657266930; cv=none; d=zohomail.com; s=zohoarc; b=apcypH7AJNQ+5f1uMBQm7ja2Of80rWs+Q6wwZylDJ0a3uhjvHo2J6LeCpbXjQKP7hfHClOGGKkpqDLxrFzpE8yMIV1kX5Qvc1ei86EHyZ9aMSTkrtwtF2soGBEfXX/O6rPGFdlUrKcz67IhHYR+lMVIc/arLhDfB8g4hGPUHVr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657266930; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a/owlsfHayOtwOEvPDh5M8TGKKeyAZulA4qoN3gbabs=; b=fnmYpoqJOcAGaZYqqG2bhyK5jJiIfzdGIczQWe/qvy4ditNZVaVMwvjQohXqdbv5aF4SZgc3vCmQTGkefEWvb61vZKi25ANWJN2oUv8inKZgACU0mpXdQ/tUO6BF5aot1L9J5SanPdL+5DR3rrIEzD7MYKbGK2i29jvpf8Veg3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1657266930928870.8984449292158; Fri, 8 Jul 2022 00:55:30 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-K0Dpf3CkP2WKoKTgGI8e5g-1; Fri, 08 Jul 2022 03:55:23 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AABB81C00510; Fri, 8 Jul 2022 07:55:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C820492C3B; Fri, 8 Jul 2022 07:55:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B58FB19451F1; Fri, 8 Jul 2022 07:55:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3FCDE1947BA2 for ; Fri, 8 Jul 2022 07:55:19 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 23B2B1121320; Fri, 8 Jul 2022 07:55:19 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0E001121315 for ; Fri, 8 Jul 2022 07:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657266929; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=a/owlsfHayOtwOEvPDh5M8TGKKeyAZulA4qoN3gbabs=; b=iMh1n6dcHC3O9Y0+U4rpGdmSCvIhAqVKSKa56lFTPbZPuGVqpWhNWbehmGP/bM8R9yvQBv khsrEZFPgvA529142PprOPb1WA+nBpVK3KslD9DeQ9NjmG/2x5hWjTJa/rT7QitH/SJe86 uQ7674AtkjfW9EJ1IGS6BkspYWizRNg= X-MC-Unique: K0Dpf3CkP2WKoKTgGI8e5g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 5/5] virsh: Implement --config for iothreadset Date: Fri, 8 Jul 2022 09:55:14 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657266931877100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Our man page already documents that iothreadset has --config argument. Well, it doesn't really. Normally, I'd just fix the man page, but with recent work on the API it's possible to tweak values for inactive XML too. Therefore, implement the --config argument for the command. Signed-off-by: Michal Privoznik --- tools/virsh-domain.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 43034f2f81..da63cc95ff 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7831,6 +7831,7 @@ static const vshCmdOptDef opts_iothreadset[] =3D { .type =3D VSH_OT_INT, .help =3D N_("upper boundary for worker thread pool") }, + VIRSH_COMMON_OPT_DOMAIN_CONFIG, VIRSH_COMMON_OPT_DOMAIN_LIVE, VIRSH_COMMON_OPT_DOMAIN_CURRENT, {.name =3D NULL} @@ -7842,6 +7843,8 @@ cmdIOThreadSet(vshControl *ctl, const vshCmd *cmd) g_autoptr(virshDomain) dom =3D NULL; int id =3D 0; bool ret =3D false; + bool current =3D vshCommandOptBool(cmd, "current"); + bool config =3D vshCommandOptBool(cmd, "config"); bool live =3D vshCommandOptBool(cmd, "live"); unsigned int flags =3D VIR_DOMAIN_AFFECT_CURRENT; virTypedParameterPtr params =3D NULL; @@ -7852,8 +7855,13 @@ cmdIOThreadSet(vshControl *ctl, const vshCmd *cmd) int thread_val; int rc; =20 + VSH_EXCLUSIVE_OPTIONS_VAR(current, live); + VSH_EXCLUSIVE_OPTIONS_VAR(current, config); + if (live) flags |=3D VIR_DOMAIN_AFFECT_LIVE; + if (config) + flags |=3D VIR_DOMAIN_AFFECT_CONFIG; =20 if (!(dom =3D virshCommandOptDomain(ctl, cmd, NULL))) return false; --=20 2.35.1