From nobody Fri Dec 19 02:54:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1751616814; cv=none; d=zohomail.com; s=zohoarc; b=Llhxm7qeFBCsEHGH0m3c8I/qlhiQeUJPhpm8l25ieHq9Fao/lfr30ldnapfe0FcOuLqogJn18Re/ltNb9XT3r8KKGEj82uCBHW/poGsvtnwF8s1OWgZ278qf2Y+qlBtuYxKhFgWGpkw9hdvItIjRrK4xWg3k3TuUgK2+Ae7SI04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751616814; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=fzW6hEgnjZAFCToIVIoXiAwbOqHgqCLcrZ/qK8haw/U=; b=Gho2qUHvknllCVLvpwlTPpkMLbsMYYEV7SG5+uphG85xmW+jOLRJFvgSOqA40737Hm/j7hbjDshTQxxD2bftnifyQAQkROvqhR68YsLIJJfEsmBbGL+sfsA28uPJ2hUcbEwT73dKjwx/UwQl4ILan7laezruGWI7EV8oH4gbFgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1751616814554199.43962964615025; Fri, 4 Jul 2025 01:13:34 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8CC3912BD; Fri, 4 Jul 2025 04:13:33 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7627D1266; Fri, 4 Jul 2025 04:13:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 53805C30; Fri, 4 Jul 2025 04:13:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CF2B111AE for ; Fri, 4 Jul 2025 04:13:11 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-au6mjnQlM3at1V1ihsGABw-1; Fri, 04 Jul 2025 04:13:10 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BB6A1944A8D for ; Fri, 4 Jul 2025 08:13:09 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9A28B195608F for ; Fri, 4 Jul 2025 08:13:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751616791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uvsNSSDuREysoaoUduGRGY+E9+oVY8SgPZPY3O0DyuU=; b=D2CmW1R1UMDUcfXLI+Bdo0dHoeitIWzzsNx/sPt6GGYjR7LToEN9wzc3RdjnlsnT0M3Xik D1uJGCgd5HD0WDIjvo3ECv+j3E878662P/UKuHG4Wa7HydfOPRaybV4vvQGKXpLZEKL2bX iudQKPSZrntPhrqYnNRVCUAN7XH2y5Q= X-MC-Unique: au6mjnQlM3at1V1ihsGABw-1 X-Mimecast-MFC-AGG-ID: au6mjnQlM3at1V1ihsGABw_1751616789 To: devel@lists.libvirt.org Subject: [PATCH] build: prohibit realpath() by syntax-check Date: Fri, 4 Jul 2025 10:12:44 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UFNg0YPWvze96Oj5Fcfe_NI0_bSFa0N7Fs7N8Rcmg30_1751616789 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NH5EJMFF77GXVSJ7ZJ6ZLO3VOAERKLWF X-Message-ID-Hash: NH5EJMFF77GXVSJ7ZJ6ZLO3VOAERKLWF X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751616817976116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik We have virFileCanonicalizePath() which calls realpath() but also is present in our mocks (in contrast to realpath()). Introduce a syntax-check rule to enforce use of our wrapper. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- build-aux/syntax-check.mk | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 1303a0ce7e..27eabe6565 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -247,6 +247,12 @@ sc_prohibit_canonicalize_file_name: halt=3D'use virFileCanonicalizePath() instead of canonicalize_file_name()= ' \ $(_sc_search_regexp) =20 +sc_prohibit_realpath: + @prohibit=3D'\