From nobody Sun Feb 8 10:30:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636623084; cv=none; d=zohomail.com; s=zohoarc; b=nfzfUV176co6Oe0uDiLlAuIEBQElQDuaYQ39SPlOnibqhdhOFf8ma6urGAKYoQy8ME9KBYRT8uvW5008tDaG7ySPrmJKRMLiiqw3DvXjLmJkHSSC7mSD9N8NSe3beT92NXk8b/tBVRpudQe+Y93+8NoUirzaYhQsh+ilJSz9XQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636623084; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HVEW+kgBgv9L6iYvcaHSRb3bnhLRuS6KLdzsAZkUk0w=; b=XTvu0HsSEHhS7LXmkutvI2ZZ7cmFLQLeidD+okWUzl6oSuroWhfQ/r0Kr95BKNPe1qgdwQ/Bg2WUN3tt0t+JII+8Fz2ITkpWpeqR8zDAsZBMAYAaU/zaW6rfz4q22W0Ddir1MyABMvlX7ANoevmBKs3AjrQ/92SwfaEdnRBpHzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1636623084779115.78245302186963; Thu, 11 Nov 2021 01:31:24 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-Hz739l7MMpmiso5gpJAyhA-1; Thu, 11 Nov 2021 04:31:22 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7352804140; Thu, 11 Nov 2021 09:31:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8A895C1B4; Thu, 11 Nov 2021 09:31:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7AE4F4EA3B; Thu, 11 Nov 2021 09:31:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AB9ST11029384 for ; Thu, 11 Nov 2021 04:28:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id CADB467841; Thu, 11 Nov 2021 09:28:29 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5123567847 for ; Thu, 11 Nov 2021 09:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636623083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HVEW+kgBgv9L6iYvcaHSRb3bnhLRuS6KLdzsAZkUk0w=; b=XPfQEwqhO5Zoc8gmH69peUPoA40yiWkPp+BBeZSPh383uza3hjSA7y6+HazxjbVVOMUe7w QQKNRkXyCSIu3wTyuh4bhunqDuT5MJVeuJaHXbI/L3qoxeIF31w+UA61jXYjxcbS293vqK ZUoOxT+T0y1USta5yt50cpLItb39u7E= X-MC-Unique: Hz739l7MMpmiso5gpJAyhA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/5] Use virNWFilterBindingObjEndAPI() more Date: Thu, 11 Nov 2021 10:28:19 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636623086255100001 Content-Type: text/plain; charset="utf-8" Instead of explicit virObjectUnlock(obj) + virObjectUnref(obj) combo the virNWFilterBindingObjEndAPI() can be used. Signed-off-by: Michal Privoznik --- src/conf/virnwfilterbindingobjlist.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/conf/virnwfilterbindingobjlist.c b/src/conf/virnwfilterbin= dingobjlist.c index 470a30ca90..212cca2265 100644 --- a/src/conf/virnwfilterbindingobjlist.c +++ b/src/conf/virnwfilterbindingobjlist.c @@ -114,11 +114,8 @@ virNWFilterBindingObjListFindByPortDev(virNWFilterBind= ingObjList *bindings, obj =3D virNWFilterBindingObjListFindByPortDevLocked(bindings, name); virObjectRWUnlock(bindings); =20 - if (obj && virNWFilterBindingObjGetRemoving(obj)) { - virObjectUnlock(obj); - virObjectUnref(obj); - obj =3D NULL; - } + if (obj && virNWFilterBindingObjGetRemoving(obj)) + virNWFilterBindingObjEndAPI(&obj); =20 return obj; } @@ -407,8 +404,7 @@ virNWFilterBindingObjListFilter(virNWFilterBindingObj *= **list, */ if (virNWFilterBindingObjGetRemoving(binding) || (filter && !filter(conn, def))) { - virObjectUnlock(binding); - virObjectUnref(binding); + virNWFilterBindingObjEndAPI(&binding); VIR_DELETE_ELEMENT(*list, i, *nbindings); continue; } --=20 2.32.0