[libvirt PATCH] qemu: end the agent job in qemuDomainSetTimeAgent

Ján Tomko posted 1 patch 4 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/d61f95cf6a6fbd564e104c168d325581acd9cd8d.1579503688.git.jtomko@redhat.com
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt PATCH] qemu: end the agent job in qemuDomainSetTimeAgent
Posted by Ján Tomko 4 years, 2 months ago
This function grabs an agent job but ends a monitor job.
End the agent job instead.

https://bugzilla.redhat.com/show_bug.cgi?id=1792723

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reported-by: Dan Zheng <dzheng@redhat.com>
Fixes: e005c95f56fee9ed780be7f8db103d690bd34cbd
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7e379fe83a..2f66d7cd9a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -20464,7 +20464,7 @@ qemuDomainSetTimeAgent(virQEMUDriverPtr driver,
     qemuDomainObjExitAgent(vm, agent);
 
  endjob:
-    qemuDomainObjEndJob(driver, vm);
+    qemuDomainObjEndAgentJob(vm);
     return ret;
 }
 
-- 
2.21.0

Re: [libvirt PATCH] qemu: end the agent job in qemuDomainSetTimeAgent
Posted by Peter Krempa 4 years, 2 months ago
On Mon, Jan 20, 2020 at 08:01:41 +0100, Ján Tomko wrote:
> This function grabs an agent job but ends a monitor job.
> End the agent job instead.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1792723
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> Reported-by: Dan Zheng <dzheng@redhat.com>
> Fixes: e005c95f56fee9ed780be7f8db103d690bd34cbd
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK