From nobody Tue Apr 23 13:30:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557751089; cv=none; d=zoho.com; s=zohoarc; b=nZwSEY6HPUdqsZQOVSBV5Mt5VjMtsRrPLMer+1kf4/323yME2ZdPi34fo+zY5KVAIPtdPTaJKDZ3GeuPhgqlhndeHUZah1qQW8mm9mlDEEqGcdVJo/bmgG3r9aMOynkjWl//QiUMiumuieQs87zH0T7YyA7i36VMybfNCBwdeYM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557751089; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=44ihS+BdS9ubQxZz/vHzsT2WraDeKvTrayPCAJ1UE5U=; b=K9koxFjCFD5tjoDOTN14DPE3Xdug/BDEOZFBtDhxVVvy0lLdTBtYe7cSgjENSX/9hhIEJjADRGMSiCaPCSk5vbSLcGY5s07PlAfsf3EhKb9hUv/bbK7AQY8cEBP9uzKljgTAQBQsISGsCEUv22QQ1VhQWAx0TxA3SwTnuOxTtYY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557751089472724.1185004176855; Mon, 13 May 2019 05:38:09 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 022703082B4D; Mon, 13 May 2019 12:38:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2F3E68D94; Mon, 13 May 2019 12:38:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 74D4D18089CB; Mon, 13 May 2019 12:38:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4DCc6s2008771 for ; Mon, 13 May 2019 08:38:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5E33663BBA; Mon, 13 May 2019 12:38:06 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9892600C8 for ; Mon, 13 May 2019 12:38:02 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 13 May 2019 14:38:00 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virsh: Don't leak disk targets in cmdDomBlkError X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 13 May 2019 12:38:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The virDomainGetDiskErrors() API copies disk targets into @disks array that we allocate. But we forgot to free it: =3D=3D140828=3D=3D 16 bytes in 4 blocks are definitely lost in loss record = 41 of 242 =3D=3D140828=3D=3D at 0x4C2F08F: malloc (vg_replace_malloc.c:299) =3D=3D140828=3D=3D by 0x8C406D9: strdup (in /lib64/libc-2.28.so) =3D=3D140828=3D=3D by 0x5377DD3: virStrdup (virstring.c:966) =3D=3D140828=3D=3D by 0x54C112F: testDomainGetDiskErrors (test_driver.c:= 3068) =3D=3D140828=3D=3D by 0x55C863D: virDomainGetDiskErrors (libvirt-domain.= c:10988) =3D=3D140828=3D=3D by 0x15D1FA: cmdDomBlkError (virsh-domain-monitor.c:1= 215) =3D=3D140828=3D=3D by 0x17F1A8: vshCommandRun (vsh.c:1335) =3D=3D140828=3D=3D by 0x13489E: main (virsh.c:920) Signed-off-by: Michal Privoznik --- Pushed under trivial rule. tools/virsh-domain-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index d87475f6f6..d2b7e5a059 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -1229,6 +1229,8 @@ cmdDomBlkError(vshControl *ctl, const vshCmd *cmd) ret =3D true; =20 cleanup: + for (i =3D 0; i < count; i++) + VIR_FREE(disks[i].disk); VIR_FREE(disks); virshDomainFree(dom); return ret; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list