From nobody Mon Feb 9 09:16:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673266761; cv=none; d=zohomail.com; s=zohoarc; b=V6gVcJqD5qEx2K/b0QFEwNG+twx/RTJk/pFMMAR/MMEsIhkvqiJlFR3KCZd5gBrWd1/ZcAhzvgbZbWZ96fJVsR8FZUy3XYTpIZ9IZNf/+XyJlAn2DTDEwVrKVquLUINwx7AdU9bfhVytOKpI6skLxwzcjO0v/cY3ptvL1vLXkOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673266761; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7FUwnt/VfNCClA8D6ClxpyBY9koTtZ8Hx75MhfM+YIc=; b=GXafAKug+k7ozZ8lMoXeUgfbHEmTTyPnJDilzfU8Uj9o+491cdp5vp02bmYaFDSyAnVq7sPW7w5xojCkX38fOhoGtg+XuA5MJ4BkwWijFdc3H/ihoWO+jD/F7SJz1olsbXE7tnlaQ+ZwXipjXTvydkrrI66208kBP62KyOpWEJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1673266761864540.2130005406123; Mon, 9 Jan 2023 04:19:21 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-248-EIcyPDYAPQGXnDSc9c7x1g-1; Mon, 09 Jan 2023 07:19:16 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0106D85CCE1; Mon, 9 Jan 2023 12:19:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0A6B492C18; Mon, 9 Jan 2023 12:19:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CD1E41947B9E; Mon, 9 Jan 2023 12:19:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C64F01947BAD for ; Mon, 9 Jan 2023 12:19:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id AB13F40C1060; Mon, 9 Jan 2023 12:19:12 +0000 (UTC) Received: from speedmetal.redhat.com (ovpn-208-20.brq.redhat.com [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FD4E4014CE2 for ; Mon, 9 Jan 2023 12:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673266760; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7FUwnt/VfNCClA8D6ClxpyBY9koTtZ8Hx75MhfM+YIc=; b=N0MSXwiBxa3dlrrbEkKW9oaNd1VsVnhhRSwjtW8LF95SfMZLAHu60TOAh7eP2Iss67d7Yz uuKassdn3siI+I+fEa+1TxTv++P1WcpufioK8scIWu+7scw1VSfBq+A9c6Ra38v94bjHdW 6PpIS0Aoplm/N+2NtaGbZrACypOFKFs= X-MC-Unique: EIcyPDYAPQGXnDSc9c7x1g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 15/17] qemu: cgroup: Don't setup cgroups for FD-passed images Date: Mon, 9 Jan 2023 13:18:53 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673266763118100005 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_cgroup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 9cf2d6474a..aac7c70054 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -206,7 +206,9 @@ qemuSetupImageCgroupInternal(virDomainObj *vm, if (qemuSetupImagePathCgroup(vm, QEMU_DEV_VFIO, false) < 0) return -1; } else { - if (!src->path || !virStorageSourceIsLocalStorage(src)) { + if (!src->path || + !virStorageSourceIsLocalStorage(src) || + virStorageSourceIsFD(src)) { VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s", NULLSTR(src->path), virStorageTypeToString(src->type= )); return 0; --=20 2.38.1