From nobody Sun Feb 8 20:12:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1698233999; cv=none; d=zohomail.com; s=zohoarc; b=Rrp6CKD7JaEqBV1VHSjYZXu69YKTYBbjATUL9q2NVHzKJP6yh4gfJB+ImtiSmcKHpABFMsYtiWr3lKnFE2+utp3QLszfxzNaE9wYExSYFK7z1asHxm5z2Vd+ubfj3xkcGKMCEKisP16GJi7jtYRTFou3R8LJ9AiR7qud/JKIhtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698233999; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=XeF3YOnAf+6eRCG1zrn7LL/xZ/va2DP2yxXQLGjt4qE=; b=FbVCVj6m0SDeWA7647hHZo1+w1glIyJ+OXYoJ5C2Y1cFfwHNWHzxWo7v34AsZCIS9hM4+zY2gND0aF2WLcan8f+N+1za9S4XLtO40UXecmv87gBNLXLTTQtiWsm25CDs1tKmUsppecOtMCU2Va21TQ4lyzzdOoHPCOBOzUFClsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1698233999832163.07055012863452; Wed, 25 Oct 2023 04:39:59 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-tyPxDUHQNNC-SADbUNf2dQ-1; Wed, 25 Oct 2023 07:39:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8CFEF185A78F; Wed, 25 Oct 2023 11:39:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7822D8C0A; Wed, 25 Oct 2023 11:39:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6ED49194658C; Wed, 25 Oct 2023 11:39:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7658619465B6 for ; Wed, 25 Oct 2023 11:39:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6B7A4492BFC; Wed, 25 Oct 2023 11:39:48 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBC6E492BFA for ; Wed, 25 Oct 2023 11:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698233998; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XeF3YOnAf+6eRCG1zrn7LL/xZ/va2DP2yxXQLGjt4qE=; b=JJVmOVrzDGWg7ztHhkO6bWS84n188Gp4+ZsO5BGpo0mwo5AT9VhHVO3iL74zO0kIEKlOey JU7wazN79vL1ImhkbfmThvHYMZDR+BnCscaK1I11R332bdZQG+Zp6yk+cRbXo69He7up3O vmaAfUtx1+ZllnxIcGGX/2GbUhC+j/s= X-MC-Unique: tyPxDUHQNNC-SADbUNf2dQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 06/22] virStorageSource: Use proper type for shadow copies of iomode/cachemode/discard/detect_zeroes Date: Wed, 25 Oct 2023 13:39:16 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1698234001301100001 Content-Type: text/plain; charset="utf-8" The aforementioned fields in virStorageSource struct are copies of the disk properties, but were not converted to the proper type yet. Signed-off-by: Peter Krempa --- src/conf/storage_source_conf.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h index 2db780611e..5e7d127453 100644 --- a/src/conf/storage_source_conf.h +++ b/src/conf/storage_source_conf.h @@ -397,10 +397,10 @@ struct _virStorageSource { /* Libvirt currently stores the following properties in virDomainDiskD= ef. * These instances are currently just copies from the parent definitio= n and * are not mapped back to the XML */ - int iomode; /* enum virDomainDiskIo */ - int cachemode; /* enum virDomainDiskCache */ - int discard; /* enum virDomainDiskDiscard */ - int detect_zeroes; /* enum virDomainDiskDetectZeroes */ + virDomainDiskIo iomode; + virDomainDiskCache cachemode; + virDomainDiskDiscard discard; + virDomainDiskDetectZeroes detect_zeroes; virTristateSwitch discard_no_unref; bool floppyimg; /* set to true if the storage source is going to be us= ed --=20 2.41.0