From nobody Sun Feb 8 16:56:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682065563; cv=none; d=zohomail.com; s=zohoarc; b=m0BG1EhaBmWdYiBhSaFKEzl3FREtLBRM9rE5yq0dsQqMbZHJC7zhJ+261MtCwqv2pEbN+azHm+mU6hSvAoADs0TcPOEZXsnP8/iC1AYSONkhJUrwX5wSDA+iF1JYgPw2PnSzmgvSon/TZS3qXeyvSZ/NemC5iVcGq/3x39YpR6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682065563; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h9UZ6muVEZD2zZd+Lf6elLzc2gtfDwlzeI7oHaGrXnw=; b=hjDSF+QiJK1E81kH2mlZzHz+Qm2PmCQgSk2YxAw8SaIBKl/7bN30dn5TmXKykOAenSyvrWkclYOpqL1b4uExK0qtHxEEqqgMtfEqPEJUJegUS7wzDOAteCyU8q+wfop+gWYV6oJ9O1dXJRhPT5wwbQR4vOxQNgyVeN3fW7GzUMk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1682065563959191.57980610478614; Fri, 21 Apr 2023 01:26:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-pUMJ1sKRP7-0HC0_JnJktw-1; Fri, 21 Apr 2023 04:25:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4431101A552; Fri, 21 Apr 2023 08:25:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E39CF2029F9A; Fri, 21 Apr 2023 08:25:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E93E21946A54; Fri, 21 Apr 2023 08:25:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BD6E219466DF for ; Fri, 21 Apr 2023 08:25:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B13F918EC7; Fri, 21 Apr 2023 08:25:12 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 587575AB7A for ; Fri, 21 Apr 2023 08:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682065563; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h9UZ6muVEZD2zZd+Lf6elLzc2gtfDwlzeI7oHaGrXnw=; b=FKmPm5Or9MjzlanHaiJxxxpCw2VN3y1NKGdxYIU23GrN7qpZewwE4n0aptD5qDBXPaNCg5 GpJw8pq3JeRV2oyqBKj3f4Zllv3F91jQVyBPvLCdziBz53FdPdu3OWaisej/8VLW+gKkoA 3TPb12S/x8GfdOUB5mTCrPsnA+ZT760= X-MC-Unique: pUMJ1sKRP7-0HC0_JnJktw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 01/11] qemu: Replace @dom argument with @driver in qemuDomainUpdateDeviceLive() Date: Fri, 21 Apr 2023 10:25:00 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682065565574100003 Content-Type: text/plain; charset="utf-8"; x-default="true" The qemuDomainUpdateDeviceLive() accepts virDomainPtr as one of its arguments, but use it only to get QEMU driver out of it. Well, the only caller already done that and thus can pass it instead of virDomainPtr. This also makes it look like the rest of device hot(un-)plug functions: qemuDomainAttachDeviceLive() and qemuDomainUpdateDeviceLive(). Signed-off-by: Michal Privoznik Reviewed-by: Kristina Hanicova --- src/qemu/qemu_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 523a83682c..48eb759531 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7070,10 +7070,9 @@ qemuDomainChangeMemoryLive(virQEMUDriver *driver G_G= NUC_UNUSED, static int qemuDomainUpdateDeviceLive(virDomainObj *vm, virDomainDeviceDef *dev, - virDomainPtr dom, + virQEMUDriver *driver, bool force) { - virQEMUDriver *driver =3D dom->conn->privateData; virDomainDeviceDef oldDev =3D { .type =3D dev->type }; int idx; =20 @@ -7939,7 +7938,7 @@ qemuDomainUpdateDeviceFlags(virDomainPtr dom, if (flags & VIR_DOMAIN_AFFECT_LIVE) { /* virDomainDefCompatibleDevice call is delayed until we know the * device we're going to update. */ - if ((ret =3D qemuDomainUpdateDeviceLive(vm, dev_live, dom, force))= < 0) + if ((ret =3D qemuDomainUpdateDeviceLive(vm, dev_live, driver, forc= e)) < 0) goto endjob; =20 qemuDomainSaveStatus(vm); --=20 2.39.2