From nobody Sun Feb 8 16:12:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604407396; cv=none; d=zohomail.com; s=zohoarc; b=Q9nBlfuzQdj1rHYvIlBMI3OSP7HT3r9YeOoouLdJ6q/FfERLsLQRflCjIuVbNdXuU6NknE31BNNqyqzMNIVzlUoY0UI9TGjlHHzgEMbJkdghGRJ1oId02pVBDvaa2056qKk04+ru1JRpz6QDDDkO3ePQxbIs+wCjUWtzNRI0jqE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604407396; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m5F6g98Qk8wt3Eqxmhwd7aAfKc0/nnoPPRMdtR4vejU=; b=kanOqbbwu2S+Sv1lm/YxWo86fIM6zs8V/QWemV3nxcB39NhPb+sJUc3mtk0Erg/1t/NTXudlixzMAaStH5BJ0puhkRlxAu/3xRKHvAen2FpmxSa7OpBBLFz9u9BtzRGbozZlp6GpGG9bnpQTd5kfXCDet3DFd6lnmxb4oXRTEnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1604407396140734.9923583989496; Tue, 3 Nov 2020 04:43:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-64U4GsJDOxStQ4tstrXBMA-1; Tue, 03 Nov 2020 07:42:28 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3305C10866A2; Tue, 3 Nov 2020 12:42:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11D9B5DA33; Tue, 3 Nov 2020 12:42:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CFF32922EB; Tue, 3 Nov 2020 12:42:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A3Cg4l7016278 for ; Tue, 3 Nov 2020 07:42:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id A68747366D; Tue, 3 Nov 2020 12:42:04 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 210CB1C4 for ; Tue, 3 Nov 2020 12:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604407394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=m5F6g98Qk8wt3Eqxmhwd7aAfKc0/nnoPPRMdtR4vejU=; b=Zo+grKWQc/TUiH1D8JMLQifNcbxeOJ8xmYDFSm74fWGZF4e/lZY8IG/IA37A9TH9QLWYGi b5lt9fHGwme0u8Mv+D0PQ9NJcIwLwzWfVriviFOticruH28AUqJEfunEZDwNQgCdoJU5aT XUVyGfnCqXUJoZvrmzinhF/qAKiCvYI= X-MC-Unique: 64U4GsJDOxStQ4tstrXBMA-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 21/25] vircgroup: drop @create from virCgroupNewDomainPartition Date: Tue, 3 Nov 2020 13:41:33 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" All callers pass true. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 5 +---- src/util/vircgrouppriv.h | 1 - tests/vircgrouptest.c | 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 00967ea5fa..1e18b84b54 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -969,7 +969,6 @@ int virCgroupNewDomainPartition(virCgroupPtr partition, const char *driver, const char *name, - bool create, virCgroupPtr *group) { g_autofree char *grpname =3D NULL; @@ -993,7 +992,7 @@ virCgroupNewDomainPartition(virCgroupPtr partition, * a group for driver, is to avoid overhead to track * cumulative usage that we don't need. */ - if (virCgroupMakeGroup(partition, newGroup, create, + if (virCgroupMakeGroup(partition, newGroup, true, VIR_CGROUP_MEM_HIERACHY) < 0) { return -1; } @@ -1278,7 +1277,6 @@ virCgroupNewMachineManual(const char *name, if (virCgroupNewDomainPartition(parent, drivername, name, - true, &newGroup) < 0) return -1; =20 @@ -2836,7 +2834,6 @@ int virCgroupNewDomainPartition(virCgroupPtr partition G_GNUC_UNUSED, const char *driver G_GNUC_UNUSED, const char *name G_GNUC_UNUSED, - bool create G_GNUC_UNUSED, virCgroupPtr *group G_GNUC_UNUSED) { virReportSystemError(ENXIO, "%s", diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h index 7248bc1d35..77e01519b0 100644 --- a/src/util/vircgrouppriv.h +++ b/src/util/vircgrouppriv.h @@ -123,7 +123,6 @@ int virCgroupNewPartition(const char *path, int virCgroupNewDomainPartition(virCgroupPtr partition, const char *driver, const char *name, - bool create, virCgroupPtr *group) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5); =20 diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index 0dd5e3f0b4..1baa71e61c 100644 --- a/tests/vircgrouptest.c +++ b/tests/vircgrouptest.c @@ -434,7 +434,7 @@ static int testCgroupNewForPartitionDomain(const void *= args G_GNUC_UNUSED) return -1; } =20 - if ((rv =3D virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo",= true, &domaincgroup)) !=3D 0) { + if ((rv =3D virCgroupNewDomainPartition(partitioncgroup, "lxc", "foo",= &domaincgroup)) !=3D 0) { fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv); return -1; } @@ -475,7 +475,7 @@ static int testCgroupNewForPartitionDomainEscaped(const= void *args G_GNUC_UNUSED return -1; } =20 - if ((rv =3D virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.= foo", true, &domaincgroup)) !=3D 0) { + if ((rv =3D virCgroupNewDomainPartition(partitioncgroup3, "lxc", "cpu.= foo", &domaincgroup)) !=3D 0) { fprintf(stderr, "Cannot create LXC cgroup: %d\n", -rv); return -1; } --=20 2.26.2