[libvirt] [PATCH] libvirt: document UNDEFINE_KEEP_NVRAM in UndefineFlags docs

Cole Robinson posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/d05f77df08b0ac7189bf669f5fef0529e8d3a56c.1488842205.git.crobinso@redhat.com
Test syntax-check passed
src/libvirt-domain.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[libvirt] [PATCH] libvirt: document UNDEFINE_KEEP_NVRAM in UndefineFlags docs
Posted by Cole Robinson 7 years ago
---
 src/libvirt-domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 619a9fc..749297f 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -6287,9 +6287,9 @@ virDomainUndefine(virDomainPtr domain)
  * whether this flag is present.  On hypervisors where snapshots do
  * not use libvirt metadata, this flag has no effect.
  *
- * If the domain has any nvram specified, then including
- * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag
- * will cause the undefine process to fail.
+ * If the domain has any nvram specified, the undefine process will fail
+ * unless VIR_DOMAIN_UNDEFINE_KEEP_NVRAM is specified, or if
+ * VIR_DOMAIN_UNDEFINE_NVRAM is specified to remove the nvram file.
  *
  * Returns 0 in case of success, -1 in case of error
  */
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] libvirt: document UNDEFINE_KEEP_NVRAM in UndefineFlags docs
Posted by Pavel Hrdina 7 years ago
On Mon, Mar 06, 2017 at 06:16:45PM -0500, Cole Robinson wrote:
> ---
>  src/libvirt-domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 619a9fc..749297f 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -6287,9 +6287,9 @@ virDomainUndefine(virDomainPtr domain)
>   * whether this flag is present.  On hypervisors where snapshots do
>   * not use libvirt metadata, this flag has no effect.
>   *
> - * If the domain has any nvram specified, then including
> - * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag
> - * will cause the undefine process to fail.
> + * If the domain has any nvram specified, the undefine process will fail
> + * unless VIR_DOMAIN_UNDEFINE_KEEP_NVRAM is specified, or if
> + * VIR_DOMAIN_UNDEFINE_NVRAM is specified to remove the nvram file.
>   *
>   * Returns 0 in case of success, -1 in case of error
>   */

ACK

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list