From nobody Mon Feb 9 09:55:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606920886; cv=none; d=zohomail.com; s=zohoarc; b=d9lVdwqYaIoAtHeuIbTPLt2ez9GYFy28unlmtERaneiCdzemRKzxy5O3Lkz1hUH04q7E3dB2qj1Fm3q2ffQBnjGtt60cjTl3h6H3VbO+R9YAseGI8Rvfxynnkof3v+h648SmqhxsGyEYXDTGdDERar5pClEdD7g2D3IpexfLpAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606920886; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=EmmTb/7bm1XGeTOLIUYiOQhuHjiizXKmC29ifUMpFv4=; b=fIvWPUx0S9/LwLZrvU35MXSK401Ls9y0nUXN09qklKSNU3cdOCUfEC8NihXezwsRvAHQHO5rqa3Sq6ZAO6VjqELkMz14qLMEL3ONtdgM8UwtwQkKbiYJsEkwIOdB7lc7WcgwSB8jTABzfZobiSLFowZpwS/fvuSWWUev+lHbbYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606920886402324.0989461231982; Wed, 2 Dec 2020 06:54:46 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-u1of-UziOXyQPnnqU5bjtA-1; Wed, 02 Dec 2020 09:54:43 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1DD7858188; Wed, 2 Dec 2020 14:54:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7776219C48; Wed, 2 Dec 2020 14:54:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3008B4E58E; Wed, 2 Dec 2020 14:54:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2EsZdj022780 for ; Wed, 2 Dec 2020 09:54:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id EEAA660855; Wed, 2 Dec 2020 14:54:35 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 707CE60854 for ; Wed, 2 Dec 2020 14:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606920885; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EmmTb/7bm1XGeTOLIUYiOQhuHjiizXKmC29ifUMpFv4=; b=Xm0i5G+67VmXCeVr8IsnXo+Ap49xWNK6p8Dc4aBNeBUKWCOiW0qvKcceu2fb4aAxg2zFqg FEDP989Rnn1P5uFF9TAvXHcFY2e/Z/QTwpl5u95W6CSvgrFN8OzhisEgp6nQb2bKOa4e76 QUeagt5SRw/gKMURaK8S91z9llzjaEY= X-MC-Unique: u1of-UziOXyQPnnqU5bjtA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2] coding-style: Document 100 chars limit for line length Date: Wed, 2 Dec 2020 15:54:28 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The idea is to have it like a soft limit: if possible then break lines, if not then have a long line instead of some creative approach. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- v2 of: https://www.redhat.com/archives/libvir-list/2020-November/msg01600.html docs/coding-style.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index cfd7b16638..b3ac070fac 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -131,7 +131,7 @@ around operators and keywords: =20 indent-libvirt() { - indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 \ + indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l100 -lc100 \ -sbi4 -psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc \ --no-tabs "$@" } @@ -141,6 +141,9 @@ further, by piping it through ``expand -i``, since some= leading TABs can get through. Usually they're in macro definitions or strings, and should be converted anyhow. =20 +The maximum permitted line length is 100 characters, but lines +should aim to be approximately 80 characters. + Libvirt requires a C99 compiler for various reasons. However, most of the code base prefers to stick to C89 syntax unless there is a compelling reason otherwise. For example, it is preferable to use --=20 2.26.2