From nobody Sat Jul 25 09:31:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784647377; cv=none; d=zohomail.com; s=zohoarc; b=CVSvuhcvXa+sKEhKwAyIELHaYj8WnImZJtdcXnzeZDUCjvWcr8VCbFIiLWOcDY2k+RMlI3C6xGzfeikCBvDM5zHkuqwqXD5Wr46lIXft8Aln+AGYorNdHsBeaMSKhpASMSxKWACVsT/Tzb/HFNfi8AY/NP0VGymgMZnh9+AhKOM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647377; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=D7j04HU152TDB/AiPsuupOMjTaHz+tzzXsr+7gxAM2k=; b=hxa5ro/1iYNYwCTivUYZZuyPQGoTL5yqZ/G8c73aiu/RqIkG3DbkP+5XVgAsD0lIjssbLq6JIkWa3A8fcNMI1mIhGmvO2KtgYyETDUzs77bpIgWqsEz2Yl/0gc/1nkQFohaGijRd3y3T8Pc3Hk3jAsYNVFNfd+nfp2AVNxf66ps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784647377241874.9747771056059; Tue, 21 Jul 2026 08:22:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1FD573FA30; Tue, 21 Jul 2026 11:22:55 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id AF43F41BBC; Tue, 21 Jul 2026 11:18:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5D55141906; Tue, 21 Jul 2026 11:17:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0599641906 for ; Tue, 21 Jul 2026 11:17:30 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-GcEGHs2BM2qydxI39CQtOg-1; Tue, 21 Jul 2026 11:17:27 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E5E0195F163 for ; Tue, 21 Jul 2026 15:17:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 87F4B1955F7D for ; Tue, 21 Jul 2026 15:17:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7j04HU152TDB/AiPsuupOMjTaHz+tzzXsr+7gxAM2k=; b=NpsG+DzekEsx91e62QGLyKXts9k9I0Hh/TxxmocNTNNoPUdvlkqZMOQiYrw/9rnb8d68kF rlXEIRnwFovlX6C8DFkfgCVTAyWhGtzz8hIlFG5N4yVWTcjdy40qLaAyOj3/r0wPmy3s3I plyTESOeMQ32Ekt7uGVm1ASfbhFaOcM= X-MC-Unique: GcEGHs2BM2qydxI39CQtOg-1 X-Mimecast-MFC-AGG-ID: GcEGHs2BM2qydxI39CQtOg_1784647046 To: devel@lists.libvirt.org Subject: [PATCH 1/4] libvirt-domain: Use consistent flag names for APIs declaring use of 'virDomainDeviceModifyFlags' Date: Tue, 21 Jul 2026 17:17:19 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cy8dmSr5Q3J4BnaOKgSwnNXRrKHBAj6lJYP918HbhnQ_1784647046 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: T6LBDDBBGLIPO5NO6UPDHMHYZOFQACSU X-Message-ID-Hash: T6LBDDBBGLIPO5NO6UPDHMHYZOFQACSU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784647379655158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa APIs which declared that they use 'virDomainDeviceModifyFlags' enum as flags used 'virDomainModificationImpact' flag names instead. Fix the flag names so that it's consistent. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/897 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-domain.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4cf1d996b8..60d84b24a1 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8989,11 +8989,11 @@ virDomainAttachDevice(virDomainPtr domain, const ch= ar *xml) * @flags: bitwise-OR of virDomainDeviceModifyFlags * * Attach a virtual device to a domain, using the flags parameter - * to control how the device is attached. VIR_DOMAIN_AFFECT_CURRENT + * to control how the device is attached. VIR_DOMAIN_DEVICE_MODIFY_CURRENT * specifies that the device allocation is made based on current domain - * state. VIR_DOMAIN_AFFECT_LIVE specifies that the device shall be + * state. VIR_DOMAIN_DEVICE_MODIFY_LIVE specifies that the device shall be * allocated to the active domain instance only and is not added to the - * persisted domain configuration. VIR_DOMAIN_AFFECT_CONFIG + * persisted domain configuration. VIR_DOMAIN_DEVICE_MODIFY_CONFIG * specifies that the device shall be allocated to the persisted domain * configuration only. Note that the target hypervisor must return an * error if unable to satisfy flags. E.g. the hypervisor driver will @@ -9050,7 +9050,7 @@ virDomainAttachDeviceFlags(virDomainPtr domain, * @xml: pointer to XML description of one device * * This is an equivalent of virDomainDetachDeviceFlags() when called with - * @flags parameter set to VIR_DOMAIN_AFFECT_LIVE. + * @flags parameter set to VIR_DOMAIN_DEVICE_MODIFY_LIVE. * * See virDomainDetachDeviceFlags() for more details. * @@ -9096,11 +9096,11 @@ virDomainDetachDevice(virDomainPtr domain, const ch= ar *xml) * @flags: bitwise-OR of virDomainDeviceModifyFlags * * Detach a virtual device from a domain, using the flags parameter - * to control how the device is detached. VIR_DOMAIN_AFFECT_CURRENT + * to control how the device is detached. VIR_DOMAIN_DEVICE_MODIFY_CURRENT * specifies that the device allocation is removed based on current domain - * state. VIR_DOMAIN_AFFECT_LIVE specifies that the device shall be + * state. VIR_DOMAIN_DEVICE_MODIFY_LIVE specifies that the device shall be * deallocated from the active domain instance only and is not from the - * persisted domain configuration. VIR_DOMAIN_AFFECT_CONFIG + * persisted domain configuration. VIR_DOMAIN_DEVICE_MODIFY_CONFIG * specifies that the device shall be deallocated from the persisted domain * configuration only. Note that the target hypervisor must return an * error if unable to satisfy flags. E.g. the hypervisor driver will @@ -9181,11 +9181,11 @@ virDomainDetachDeviceFlags(virDomainPtr domain, * @flags: bitwise-OR of virDomainDeviceModifyFlags * * Change a virtual device on a domain, using the flags parameter - * to control how the device is changed. VIR_DOMAIN_AFFECT_CURRENT + * to control how the device is changed. VIR_DOMAIN_DEVICE_MODIFY_CURRENT * specifies that the device change is made based on current domain - * state. VIR_DOMAIN_AFFECT_LIVE specifies that the device shall be + * state. VIR_DOMAIN_DEVICE_MODIFY_LIVE specifies that the device shall be * changed on the active domain instance only and is not added to the - * persisted domain configuration. VIR_DOMAIN_AFFECT_CONFIG + * persisted domain configuration. VIR_DOMAIN_DEVICE_MODIFY_CONFIG * specifies that the device shall be changed on the persisted domain * configuration only. Note that the target hypervisor must return an * error if unable to satisfy flags. E.g. the hypervisor driver will @@ -9248,8 +9248,8 @@ virDomainUpdateDeviceFlags(virDomainPtr domain, * * Detach a virtual device from a domain, using the alias to * specify the device. The value of @flags should be either - * VIR_DOMAIN_AFFECT_CURRENT, or a bitwise-or of values from - * VIR_DOMAIN_AFFECT_LIVE and VIR_DOMAIN_AFFECT_CURRENT, although + * VIR_DOMAIN_DEVICE_MODIFY_CURRENT, or a bitwise-or of values from + * VIR_DOMAIN_DEVICE_MODIFY_LIVE and VIR_DOMAIN_DEVICE_MODIFY_CONFIG, alth= ough * hypervisors vary in which flags are supported. * * In contrast to virDomainDetachDeviceFlags() this API is --=20 2.55.0 From nobody Sat Jul 25 09:31:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784647176; cv=none; d=zohomail.com; s=zohoarc; b=ELVGihu8fHhnZX/acU52+aVR9qY0UCky0/4bDXLb3wVIrMFiGv+yf8hYZBrp/aLnorEr04Bj0kcOh27+7LGxkghGd5oKw0OU+gQe2mOCmrGzF0FlJLJzhryvgazhj+jtpiq5jKU42ybUcawBZXKhJV6FzGxVFBYZiMf0VOibk44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647176; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=JXjyvwSpohxFfD6Drh1JWumLnUsD0wxT+30SzE9yR/w=; b=P9Jnyn6bi+th+3itkW/m+MlK2Z1xZPgkobd1hNfV9lqUivDtfNGJBvyyBoVVRrAOs4RoyHbwvZ4JaMynbueaHYHr1hwZ2B/vNODCrb/+SvIHFRIgc/sWmiUEgkaPCawxoDLesonI/jmFZzq9OKcgZbMVBa+ZJadPxDKVKzZ+VT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 178464717636613.49687398498179; Tue, 21 Jul 2026 08:19:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7120341C14; Tue, 21 Jul 2026 11:19:34 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9CEDC41DDC; Tue, 21 Jul 2026 11:17:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 616B53F880; Tue, 21 Jul 2026 11:17:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 094CE4190B for ; Tue, 21 Jul 2026 11:17:30 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-fQ3_4PVcMbyfW10k_Hpc6g-1; Tue, 21 Jul 2026 11:17:28 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E45B195C27A for ; Tue, 21 Jul 2026 15:17:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B7FAD1955F7E for ; Tue, 21 Jul 2026 15:17:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JXjyvwSpohxFfD6Drh1JWumLnUsD0wxT+30SzE9yR/w=; b=fAJ+u2CKzKpkQzrsMwoRv4mjNYNBg0aoyInSpBbpuaWwLCBAjvp8tNU3DlVEEEeFd3uvlm BC11xuLSoWlDaTrPrRsfJdjgL2YpDj16fbLkEMZpWYGefyF//mwNBR95f3y/if+K4KmdKl F5f7Cbyk3JZQrCXFeWBjYwapt9DZR8s= X-MC-Unique: fQ3_4PVcMbyfW10k_Hpc6g-1 X-Mimecast-MFC-AGG-ID: fQ3_4PVcMbyfW10k_Hpc6g_1784647047 To: devel@lists.libvirt.org Subject: [PATCH 2/4] libvirt-qemu: Add reference to QMP protocol documentation Date: Tue, 21 Jul 2026 17:17:20 +0200 Message-ID: <0b858140bc3af4f64c42f57c1c9e1066b820b6c3.1784647021.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J-SjIeAOw1qRGnKqQGeDC7BaqX7EqIXSQF2tXTQ0j58_1784647047 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XF7V6IQKQEKEPT5AO6RDAHNRWZKDN6TU X-Message-ID-Hash: XF7V6IQKQEKEPT5AO6RDAHNRWZKDN6TU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784647178047158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add link to the qemu QMP protocol reference. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-qemu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 2898b71983..d6c68083f2 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -51,6 +51,9 @@ VIR_LOG_INIT("libvirt-qemu"); * libvirt is possible as a means to test new QEMU features before * they have support in libvirt, but no guarantees are made to safety * + * QEMU expects the command @cmd to be in the QMP format which is document= ed at + * https://www.qemu.org/docs/master/interop/qmp-spec.html + * * If VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP is set, the command is * considered to be a human monitor command and libvirt will automatically * convert it into QMP if needed. In that case the @result will also @@ -123,6 +126,9 @@ virDomainQemuMonitorCommand(virDomainPtr domain, const = char *cmd, * libvirt is possible as a means to test new QEMU features before * they have support in libvirt, but no guarantees are made to safety * + * QEMU expects the command @cmd to be in the QMP format which is document= ed at + * https://www.qemu.org/docs/master/interop/qmp-spec.html + * * If VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP is set, the command is * considered to be a human monitor command and libvirt will automatically * convert it into QMP if needed. In that case the @result will also --=20 2.55.0 From nobody Sat Jul 25 09:31:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784647307; cv=none; d=zohomail.com; s=zohoarc; b=SqAsolwVCMdSA5Ydlee+Zkh90RagDyFfx0ijFeYJKNhkHhS+Vi7R0MRpUVZj996db5q6Ix3vBvgXRLyXutJKZBvLCTZr86Ov6wnm480kYcPz+vl2tMgzvzFfvhXeb3/5q0/OMqYiT5Q7DPv8A5M15q/lsRWbFc60J/2eOOGJ5iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647307; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=A3ZfyRj/AiUHME0Q52QsKDh+VMl01uhfWKvvkbcyEbQ=; b=fEMb+o7f5MI/4WgkPhjIEobDyEduUynNKO9gWwRER9+n2XAHD0ES8LFopI3dnh56cFeSacRPwRbQzymwR01HV3sB5DYVZAMnnXHn6sBTs7W2yE9GsH5WbqCI6XZTcUyDhHaYo2yVoeJVz4JkeOqmpk7Vr0GHmpfw3m9AjX/eGvo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784647307085369.339933563813; Tue, 21 Jul 2026 08:21:47 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5B8AF41B69; Tue, 21 Jul 2026 11:21:45 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id C87DC41C77; Tue, 21 Jul 2026 11:18:00 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4A24A41908; Tue, 21 Jul 2026 11:17:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 445F341939 for ; Tue, 21 Jul 2026 11:17:32 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-fDzxa27uP4W0IBk5AQDMWg-1; Tue, 21 Jul 2026 11:17:29 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B78AB1809A39 for ; Tue, 21 Jul 2026 15:17:28 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DE5421955F7D for ; Tue, 21 Jul 2026 15:17:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A3ZfyRj/AiUHME0Q52QsKDh+VMl01uhfWKvvkbcyEbQ=; b=QnVjR4XixCJjtnQvNuL7V1WfcH9E84okBq0gnGSeb2D6ApbxveUneGb2vRawdt2Kp5YNgn rdvrz7hBO5I2eK0bqWW5XFPxzFhZf71ocx82u3b/g+/d+o6j6VJDvWT+X7GFnYoq0+GkVR G3K+bntzUVMmafKOSGatop0HF5VfAt4= X-MC-Unique: fDzxa27uP4W0IBk5AQDMWg-1 X-Mimecast-MFC-AGG-ID: fDzxa27uP4W0IBk5AQDMWg_1784647048 To: devel@lists.libvirt.org Subject: [PATCH 3/4] libvirt-qemu: Document that 'virDomainQemuAttach' no longer works Date: Tue, 21 Jul 2026 17:17:21 +0200 Message-ID: <0168dff3639d41f22bd63d9b1bb50088affa0238.1784647021.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: npT3S-fhK26vZweQkCpLweXz5giNW9JlmxckpgOQUKA_1784647048 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2FVUTZJQVS7RXZJCFYCKD72K555LFITR X-Message-ID-Hash: 2FVUTZJQVS7RXZJCFYCKD72K555LFITR X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784647308982158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The qemu driver support was removed in libvirt 5.5.0 but the top level documentation for the API didn't mention that yet. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-qemu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index d6c68083f2..c4cbc49ef7 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -202,6 +202,9 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domai= n, * @pid_value: the UNIX process ID of the external QEMU process * @flags: optional flags, currently unused * + * This API is not functional since libvirt 5.5.0 as support in the QEMU d= river + * was removed. + * * This API is QEMU specific, so it will only work with hypervisor * connections to the QEMU driver. * --=20 2.55.0 From nobody Sat Jul 25 09:31:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784647240; cv=none; d=zohomail.com; s=zohoarc; b=RCXjc1aEhEvMpztWKumV1QGEyoPzF5X9lLnAUCysN/Coytg1JysaViFeQTp2sRV8mmdgA8wbai1QWGHqEfnGXzaKNQatoKF8takNMTY3rZiaCguwwAbOkelSmwKNr9o2yYhqCW5dzpFI0O8Rn2/YspusNLQMIsU6Mm+bWkKWitM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647240; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=TCVij+noKhcpmJzQkTyn1/OCwaEwhFaA0BE/MHvBArQ=; b=D9LY8+kKi9kHf+dDekY5XqjeovLDtBCUcOjMJ3dQ1q8e/+7fDxH+5eicXmnt50OWHCYfjo0MAiXpB0m9z55CkKFDHHDw8iDvnYci77/7bGswTmx8vEO5+uwYUKTqIBvIsb5e3g3+9/J95tjFQuNjFWPYeZLnf/XYXjlI7IyA19I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 17846472404771018.3469648610879; Tue, 21 Jul 2026 08:20:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C044241BC0; Tue, 21 Jul 2026 11:20:37 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5018441BCF; Tue, 21 Jul 2026 11:17:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA4E641908; Tue, 21 Jul 2026 11:17:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0DA8F4190D for ; Tue, 21 Jul 2026 11:17:32 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-5pI3NSIGNDCYLEjWqEHisQ-1; Tue, 21 Jul 2026 11:17:30 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC4F11955DC2 for ; Tue, 21 Jul 2026 15:17:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3425B1955E7E for ; Tue, 21 Jul 2026 15:17:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TCVij+noKhcpmJzQkTyn1/OCwaEwhFaA0BE/MHvBArQ=; b=P7kbAo9pol/QkIWlsCMR7XowA9N3y2I2GWMKX1ZhyGsFdA9zihcZJpYjIA69wbJJLMa5h8 YPiEatTP5Eyrk+Sdyul1w0RdMWv8Gtj3nxZM/MlI3cEjF0mSbrZTG4PjHMSMJTfV3PInpm 4yRKgyOBTJM0f8XCcvgXPlY0eQS4iNI= X-MC-Unique: 5pI3NSIGNDCYLEjWqEHisQ-1 X-Mimecast-MFC-AGG-ID: 5pI3NSIGNDCYLEjWqEHisQ_1784647050 To: devel@lists.libvirt.org Subject: [PATCH 4/4] libvirt-qemu: Add reference to QEMU agent protocol syntax Date: Tue, 21 Jul 2026 17:17:22 +0200 Message-ID: <9c6fe2bf8ea1b0c5b682856d3ef4ec880bf7e8a3.1784647021.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3w5ELN3zLeBWH32EhfS4eAc6At3w2q54C3x9n69p3y8_1784647050 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YKXOO5GPKH7QCIFISR3DTFKPAYTNACZ4 X-Message-ID-Hash: YKXOO5GPKH7QCIFISR3DTFKPAYTNACZ4 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784647242483158501 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add a reference to the expected format of commands used with 'virDomainQemuAgentCommand'. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/891 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-qemu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index c4cbc49ef7..3df33609e9 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -278,6 +278,11 @@ virDomainQemuAttach(virConnectPtr conn, * Execute an arbitrary Guest Agent command. * * Issue @cmd to the guest agent running in @domain. + * + * The QEMU guest agent expects the command @cmd to be in the QEMU Guest A= gent + * Protocol format documented at: + * https://www.qemu.org/docs/master/interop/qemu-ga-ref.html + * * @timeout must be -2, -1, 0 or positive. * VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK(-2): meaning to block forever waiti= ng for * a result. @@ -285,7 +290,8 @@ virDomainQemuAttach(virConnectPtr conn, * VIR_DOMAIN_QEMU_AGENT_COMMAND_NOWAIT(0): does not wait. * positive value: wait for @timeout seconds * - * Returns strings if success, NULL in failure. + * Returns string containing the verbatim reply from the guest agent on + * success, NULL on failure. * * Since: 0.10.0 */ --=20 2.55.0