From nobody Tue Jul 14 21:21:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1782911109; cv=none; d=zohomail.com; s=zohoarc; b=Y058bVeX5tz1qFhDqJIyox9X6BHXsTs8gyIjJbTGY4vYVE2zZxJEabPdyjh2e4SBry7VJr0VuwtXjJzWOZcJBYzRMBS3k/qXWEAZ9olhr0UE8FZgB2eMq1h2jvCUycn/0jJ/eVMawAyqXyEB97exKo/9DPrIOBFV8COnpROHfzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782911109; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=OS1EPpQpHnDeo67rkAs2EfbvYQCHFANdqUGJLz+gftg=; b=XWA42VVZ4iTx1NZMze5135Aa8D88+K8h6J9XyVXWiGLWlyKqkgNYC6tk9TIrbkvulyL8HFz2vevqo3zJ+SuXJeT4gVEjSuEQ8UyY1jDzHUjsj7L8e7uZtAOHLILVm5dYsRxACxSWpZp1oCH8OR5QLwCripXWFIw0vdVX6vD+lBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782911109946397.30693402695454; Wed, 1 Jul 2026 06:05:09 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id CFC1F41BAC; Wed, 1 Jul 2026 09:05:08 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 0D52B41E36; Wed, 1 Jul 2026 09:03:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E5B1241B9F; Wed, 1 Jul 2026 09:03:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 50FE841AFC for ; Wed, 1 Jul 2026 09:03:09 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-WJ3NxzC5NVumC7JyzNGmqA-1; Wed, 01 Jul 2026 09:03:07 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE1161933FA0 for ; Wed, 1 Jul 2026 13:03:06 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3CAAA3000C29 for ; Wed, 1 Jul 2026 13:03:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782910989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OS1EPpQpHnDeo67rkAs2EfbvYQCHFANdqUGJLz+gftg=; b=jHGDC8DevN76jIF1hFYzqEIxR3btczPqSAcy05zwy9bBWceD/sb7/96pspwT6PlScqBOEi OulGCrowt0273oX1kOCAhA2G7PxELJ2mOsj+rAvqBPh1+8M7S3pizRO+uI09YKzaoHOGjA hwyHNVUGiZd+EQUANi1ck6is+NqRK4o= X-MC-Unique: WJ3NxzC5NVumC7JyzNGmqA-1 X-Mimecast-MFC-AGG-ID: WJ3NxzC5NVumC7JyzNGmqA_1782910986 To: devel@lists.libvirt.org Subject: [PATCH 1/3] gendispatch: Use g_autoptr() for virAccessManager Date: Wed, 1 Jul 2026 15:03:00 +0200 Message-ID: <71fc7bc94fcbed4ed968c2576bddedf093bd3599.1782910959.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fw6VrMypvbgl2leyuXeQKI65qDbDJvejmHmC1TUU2pY_1782910986 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LUT6X6INEKJXSECVYOBP6FCU5RUOF5GR X-Message-ID-Hash: LUT6X6INEKJXSECVYOBP6FCU5RUOF5GR X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782911111463158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Let's modify our gendispatch.pl script so that the code it generates for the ACL checks uses g_autoptr instead of explicit unref()-ing in each exit path. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/access/viraccessmanager.h | 2 +- src/rpc/gendispatch.pl | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/access/viraccessmanager.h b/src/access/viraccessmanager.h index 2050ac9b85..02661fe81b 100644 --- a/src/access/viraccessmanager.h +++ b/src/access/viraccessmanager.h @@ -38,7 +38,7 @@ void virAccessManagerSetDefault(virAccessManager *manager= ); =20 virAccessManager *virAccessManagerNew(const char *name); virAccessManager *virAccessManagerNewStack(const char **names); - +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virAccessManager, virObjectUnref); =20 void *virAccessManagerGetPrivateData(virAccessManager *manager); =20 diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 8cb7d7eda2..4d385927aa 100755 --- a/src/rpc/gendispatch.pl +++ b/src/rpc/gendispatch.pl @@ -2165,7 +2165,7 @@ elsif ($mode eq "client") { print "/* Returns: $fail on error/denied, $pass on allowed= */\n"; print "$ret $apiname(" . join(", ", @argdecls) . ")\n"; print "{\n"; - print " virAccessManager *mgr;\n"; + print " g_autoptr(virAccessManager) mgr =3D NULL;\n"; print " int rv;\n"; print "\n"; print " if (!(mgr =3D virAccessManagerGetDefault())) {\= n"; @@ -2205,7 +2205,6 @@ elsif ($mode eq "client") { print " "; } print "(rv =3D $method(" . join(", ", @argvars, $perm)= . ")) <=3D 0) {\n"; - print " virObjectUnref(mgr);\n"; if ($action eq "Ensure") { print " if (rv =3D=3D 0)\n"; print " virReportError(VIR_ERR_ACCESS_D= ENIED,\n"; @@ -2219,7 +2218,6 @@ elsif ($mode eq "client") { print "\n"; } =20 - print " virObjectUnref(mgr);\n"; print " return $pass;\n"; print "}\n\n"; } --=20 2.53.0 From nobody Tue Jul 14 21:21:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1782911157; cv=none; d=zohomail.com; s=zohoarc; b=diXrAXfVE+v6eduSxM+aZp6fm4fq5G7XovRp+LcifCMReKiVeoG/bjBa0grswfbikn+DPUIyfL0tZ9KBsxktNVZqdP84HCdvLtqyFJCzZrB0RQD097CTVCt8YZMW5SacNI8yKZBvnBKNQseu1T5qXT6hiuId+gKjsNNndWmXA+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782911157; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qkjsJwWFx+Im4iNWzY7EsgL2FkDWgQA3NcOsv/R6t40=; b=VNtnHdrmpOmK3F7L3f6WuU2R/th8E1pk11fmjZ695RoOq+HtTuCH7755dBwaM2p+TFCSFIRSu+z2li9XSYM8SNXAkK1xx1B3WIPI4QsgB7WGGEwLHn59BrnoMFRNWhjDtEoCphEGPv2KNUii8It/yGgiSeB3OL63cG5Fv3uc1Og= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782911157702621.2562039168821; Wed, 1 Jul 2026 06:05:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 41D0141BBA; Wed, 1 Jul 2026 09:05:56 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 015A5423F2; Wed, 1 Jul 2026 09:03:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5176841BA3; Wed, 1 Jul 2026 09:03:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AD39C41B9F for ; Wed, 1 Jul 2026 09:03:10 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91--QZ4MlB0NE2j9o45WqPXJA-1; Wed, 01 Jul 2026 09:03:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D85BD1944EAE for ; Wed, 1 Jul 2026 13:03:07 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3F0923000C29 for ; Wed, 1 Jul 2026 13:03:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782910990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkjsJwWFx+Im4iNWzY7EsgL2FkDWgQA3NcOsv/R6t40=; b=UCSYQeSY5yZ70uH/brsJp8GFNzK6uWSKJzOtBPa9TZqOljg2kVOR7WSytbJdaz9zUFJEtu LBmmSBB+lFYXm9LgInR+g2c7HUaQSqrZOM8jvi/bxIYPUtqndEuX5bmpqNDEeKvrDgpS9l uH+6VtoE+715Tu6LQAvL4EDOu/TFrXc= X-MC-Unique: -QZ4MlB0NE2j9o45WqPXJA-1 X-Mimecast-MFC-AGG-ID: -QZ4MlB0NE2j9o45WqPXJA_1782910988 To: devel@lists.libvirt.org Subject: [PATCH 2/3] viraccessmanager: Drop virAccessError macro Date: Wed, 1 Jul 2026 15:03:01 +0200 Message-ID: <7883e7c9a89f6e8d239364e6e4ec363594808e5f.1782910959.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: joqX_qO5ysHBT54XyoyCQh539XKVfX7X_nKV-zJF1XA_1782910988 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WRHKUXE5QBBTF2DGWUMT5CFE3ZJPKQE5 X-Message-ID-Hash: WRHKUXE5QBBTF2DGWUMT5CFE3ZJPKQE5 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782911160185158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The virAccessError macro already exists under a different name: virReportError(). Switch code to use the latter and drop the former. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/access/viraccessmanager.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/access/viraccessmanager.c b/src/access/viraccessmanager.c index 6d9fdee5f1..9ceec2744b 100644 --- a/src/access/viraccessmanager.c +++ b/src/access/viraccessmanager.c @@ -36,10 +36,6 @@ =20 VIR_LOG_INIT("access.accessmanager"); =20 -#define virAccessError(code, ...) \ - virReportErrorHelper(VIR_FROM_THIS, code, __FILE__, \ - __FUNCTION__, __LINE__, __VA_ARGS__) - struct _virAccessManager { virObjectLockable parent; =20 @@ -203,7 +199,7 @@ virAccessManagerSanitizeError(int ret, { if (ret < 0) { virResetLastError(); - virAccessError(VIR_ERR_ACCESS_DENIED, + virReportError(VIR_ERR_ACCESS_DENIED, _("'%1$s' denied access"), driverName); } =20 --=20 2.53.0 From nobody Tue Jul 14 21:21:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1782911202; cv=none; d=zohomail.com; s=zohoarc; b=KjgrNpdu/vaAfEZJA/OXAFcZ13Wd4LdCUP5DQ4B8ZqgSo0+57/AoYU04HyOAbWLkLCIW4jADEINbgWZiCPSlmUq0+1onecMxRfPyc1YbEa1pzIJlOjWdsjoV8EO2ROPJYaIPhwWSu94KkAZNeFofO1wilYJO/9xROZEnct//LxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782911202; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=j1Cok/xwGEdCXQdb5Rc/4qWflnjxlc6tpPlWGvFDC5c=; b=EwON8j+z1v5rc1LCKEFeC5TUAm21VD7ScJ0crrFNMzV9MlzU6JlAj7UPza0glJkRRIty13JGtilYUHtrDZ+I+KEDop70ykTyb0BJv1pxfGxXGLj0r+BqI3Y4QfPNsBkHVaVceTsJNLKVNkVz3JTLkn9s8B2TOF/Y/B9zeMdaiF8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 178291120201370.89497079952594; Wed, 1 Jul 2026 06:06:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 893A841D4C; Wed, 1 Jul 2026 09:06:38 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E2F2D41D99; Wed, 1 Jul 2026 09:03:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2173B41DAE; Wed, 1 Jul 2026 09:03:16 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4FBDB41BA0 for ; Wed, 1 Jul 2026 09:03:12 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-5Q-o8edtP6yuN-dE7XzUBg-1; Wed, 01 Jul 2026 09:03:10 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E63DE1933356 for ; Wed, 1 Jul 2026 13:03:08 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B4873000C29 for ; Wed, 1 Jul 2026 13:03:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782910992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j1Cok/xwGEdCXQdb5Rc/4qWflnjxlc6tpPlWGvFDC5c=; b=WuxBJYPeY3XJXgaNydUmBcZLZspSVr8tI4TCyvUWK8wrMCRzsHNnGZIHwv4skcukCecs67 vncld0llB706fOMl2retNOW+m7THUJu5XQ17tmuKEoKGgUdkmKjSGCVkWE4vz2fSQapx/1 0osk5aEBfk43U82l1/wdJJOmVJh3pnk= X-MC-Unique: 5Q-o8edtP6yuN-dE7XzUBg-1 X-Mimecast-MFC-AGG-ID: 5Q-o8edtP6yuN-dE7XzUBg_1782910989 To: devel@lists.libvirt.org Subject: [PATCH 3/3] gendispatch.pl: Produce newline at end of block Date: Wed, 1 Jul 2026 15:03:02 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: efin2y0aM6_9xpx4_zqQL7cgo1A8xzUwAAS7nHAubsY_1782910989 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2KXCYKJHTRZOHVFI7HUQN2YARQOW2UIN X-Message-ID-Hash: 2KXCYKJHTRZOHVFI7HUQN2YARQOW2UIN X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782911204528158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik After each block that's generated into viraccessapicheck.c there should be a new line. Format it into generated source file. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/rpc/gendispatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 4d385927aa..252562ccfd 100755 --- a/src/rpc/gendispatch.pl +++ b/src/rpc/gendispatch.pl @@ -2214,7 +2214,7 @@ elsif ($mode eq "client") { print " virResetLastError();\n"; print " return $fail;\n"; } - print " }"; + print " }\n"; print "\n"; } =20 --=20 2.53.0