From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777776; cv=none; d=zohomail.com; s=zohoarc; b=OB4t+sbeZqZqZHnY2erFW1Cx/nBuh1Q9N6KP7lgcHIRsZq/qK+Ips+Xc7Kq0CA7e6nGSQp/flkoDxdXMWPmjv3f2tehwRCyRGoBYA6dow/tN+x3sS9in2rF3k9ujMcgrmcaornFhxjiQUkBLm+/SL3jQPhv8PV+zDs08znm8NZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777776; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=+IurqVOawsNFKpYZSArVm/PskhoEqUY/PB4fYs5WBOQ=; b=dQbKnXCTJB0ldgjKkJG32lTpZhOxhpDe0T7wp7X3TSRT7S//UAwGxX6vux1SwKa+qt/+fjRFQp/1xL7WG2ZDww3p2eYOVPB/RNU1JNbhMnudxUSZwoZIHPANuwJw3X/AhifcawFMcypqaMPbbRJ1KKoVoy59PmRMO/CGC23MUOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777776557261.7767076530131; Thu, 14 May 2026 09:56:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 64AA741911; Thu, 14 May 2026 12:56:15 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 51A9841902; Thu, 14 May 2026 12:49:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D87CE418EA; Thu, 14 May 2026 12:49:17 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AA58F4184C for ; Thu, 14 May 2026 12:49:12 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-WQzJsbqUMz2RcQZBf8OeDA-1; Thu, 14 May 2026 12:49:10 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B0C651956046 for ; Thu, 14 May 2026 16:49:09 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0A82918001E8 for ; Thu, 14 May 2026 16:49:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IurqVOawsNFKpYZSArVm/PskhoEqUY/PB4fYs5WBOQ=; b=T1HtnIbHEXBN1SCqOkLCHoh/b0wECePIKe1oV2VCgBHhM/MTatES/pWpF1V0LHV1efnDFz xjWb89WEZwusiA8E9ahxWMJ3rAzJLog14iHt/jGsWHftPlyNk5o6mtSX6Tqyv6TwPMQEvS MAar0/bE+kEX2CWDKb1aCzirYjwj/gY= X-MC-Unique: WQzJsbqUMz2RcQZBf8OeDA-1 X-Mimecast-MFC-AGG-ID: WQzJsbqUMz2RcQZBf8OeDA_1778777349 To: devel@lists.libvirt.org Subject: [PATCH 1/9] remote_driver: Don't leak opaque pointer passed to 'virStreamEventAddCallback' Date: Thu, 14 May 2026 18:48:58 +0200 Message-ID: <3bf022d9ea01e42bc5dd231601ebc38357620a24.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: opPABDSggiWVWLRwaacGbwcQRO94JvzU2BKuQde8Ils_1778777349 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VBXLUVEWI5ILREGNXHNDMGBAPXSTZXJR X-Message-ID-Hash: VBXLUVEWI5ILREGNXHNDMGBAPXSTZXJR X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777777134158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa In the implementation of the virStream events in the remote driver, the freeing of the passed opaque data for the callback was guarded by: if (!cbdata->cb && cbdata->ff) (cbdata->ff)(cbdata->opaque); thus if the 'cb' is passed to 'virStreamEventAddCallback' the private data would never be freed once 'virStreamEventRemoveCallback' is called. The issue can be reproduced both in client applications which would register the stream callback and also in the libvirt daemons, when modular daemons are used. The virStream remote driver client code is in such deployments also used to tunnel requests from the hypervisor daemon (virtqemud) to sub-daemons (virstoraged). In those cases the leak is amplified as the stream event callback is internally used to do the tunnelling and the daemon dispatch code stores a reference to the 'virNetClient' object associated with the connection. As this causes the last reference on the virNetClient object to be still active, the corresponding connection to the storage daemon isn't closed either, leaking a FD both in virtqemud and virtstoraged. Internally the data is stored in 'struct remoteStreamCallbackData' which is defined only in 'remote_driver.c' and there's no code which would update the 'cb' field, thus the leak can't be avoided. Remove the check for 'cb'. My assumption is that this was supposed to mimic the 'dispatching' field in 'util/fdstream.c' or similar logic in other dispatch functions. The patch also adds debug statements which I've used to trace this. The leak of a connection in 'virtqemud' has the following backtrace under valgrind (note that the pointer is considered reachable and thus this isn't visible in default config): =3D=3D3678343=3D=3D 136 bytes in 1 blocks are still reachable in loss recor= d 2,680 of 2,964 =3D=3D3678343=3D=3D at 0x48FC6CD: calloc (vg_replace_malloc.c:1616) =3D=3D3678343=3D=3D by 0x4ED8A91: g_malloc0 (in /usr/lib64/libglib-2.0.s= o.0.8600.5) =3D=3D3678343=3D=3D by 0x5019CA2: g_type_class_get (in /usr/lib64/libgob= ject-2.0.so.0.8600.5) =3D=3D3678343=3D=3D by 0x5001011: g_object_new_with_properties (in /usr/= lib64/libgobject-2.0.so.0.8600.5) =3D=3D3678343=3D=3D by 0x5001EA0: g_object_new (in /usr/lib64/libgobject= -2.0.so.0.8600.5) =3D=3D3678343=3D=3D by 0x499E653: virObjectNew (virobject.c:252) =3D=3D3678343=3D=3D by 0x499EA0F: virObjectLockableNew (virobject.c:274) =3D=3D3678343=3D=3D by 0x4A84651: virNetClientStreamNew (virnetclientstr= eam.c:144) =3D=3D3678343=3D=3D by 0x4AE82AE: remoteStorageVolUpload (remote_client_= bodies.h:8242) =3D=3D3678343=3D=3D by 0x4BED13D: virStorageVolUpload (libvirt-storage.c= :1809) =3D=3D3678343=3D=3D by 0x4043539: remoteDispatchStorageVolUpload (remote= _daemon_dispatch_stubs.h:20248) =3D=3D3678343=3D=3D by 0x4043539: remoteDispatchStorageVolUploadHelper (= remote_daemon_dispatch_stubs.h:20218) =3D=3D3678343=3D=3D by 0x4A89A2C: virNetServerProgramDispatchCall (virne= tserverprogram.c:423) =3D=3D3678343=3D=3D by 0x4A89A2C: virNetServerProgramDispatch (virnetser= verprogram.c:299) Resolves: https://redhat.atlassian.net/browse/RHEL-170773 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/remote/remote_driver.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 000c1b5324..e83b0abcbe 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5363,8 +5363,12 @@ static void remoteStreamEventCallback(virNetClientSt= ream *stream G_GNUC_UNUSED, static void remoteStreamCallbackFree(void *opaque) { struct remoteStreamCallbackData *cbdata =3D opaque; + virNetClientStream *privst =3D cbdata->st->privateData; - if (!cbdata->cb && cbdata->ff) + VIR_DEBUG("stream=3D%p, clientstream=3D%p, cb=3D%p, ff=3D%p, opaque=3D= %p", + cbdata->st, privst, cbdata->cb, cbdata->ff, cbdata->opaque); + + if (cbdata->ff) (cbdata->ff)(cbdata->opaque); virObjectUnref(cbdata->st); @@ -5385,6 +5389,9 @@ remoteStreamEventAddCallback(virStreamPtr st, struct remoteStreamCallbackData *cbdata; VIR_LOCK_GUARD lock =3D remoteDriverLock(priv); + VIR_DEBUG("st=3D%p, clientstream=3D%p, events=3D%d, cb=3D%p, opaque=3D= %p, ff=3D%p", + st, privst, events, cb, opaque, ff); + cbdata =3D g_new0(struct remoteStreamCallbackData, 1); cbdata->cb =3D cb; cbdata->opaque =3D opaque; --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777493; cv=none; d=zohomail.com; s=zohoarc; b=P/jEG9igclpzcr6FbVtNXHJ9QNvGKkL7UM/oDb514kpzuGnZ6AKfogxa9UcKxYsux32cUvZW12U4eieFOHE3OOZ+q+ATkQVsXntVBKUqyTn366gxn772EgowTrSZKBgNOA01tJzPpqb8mp0nrtpfD4p4Jvw0FCLdAPxZ4jEp0qI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777493; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=7GXM8PH+uW7WqiDQ4CBH7mDW0qLBsJDT0hM+YPLPPIw=; b=k8YINyhaXEVlC6oz0h2eB7vx3GhLGtfC5YEz0fcxZ4YDmqE9N0Va2mhxBxYvgv7xvoNWUIjv1t4+nDfHuGjWjHXkdmdTlq34XA7HCAX9dTgYUgrlx2ybwOXBirPLz9W+l+tDpyCGfB0iJsEXMqaU/0pdxy841FrLpM3dImVjj4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777493520216.01761281446716; Thu, 14 May 2026 09:51:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5BDEF419D7; Thu, 14 May 2026 12:51:32 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 3CAD541935; Thu, 14 May 2026 12:49:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1F6B83F2F8; Thu, 14 May 2026 12:49:13 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4049F4184D for ; Thu, 14 May 2026 12:49:13 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-W4LtRbBDNHaUkdvBTcwgUw-1; Thu, 14 May 2026 12:49:11 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D31501956062 for ; Thu, 14 May 2026 16:49:10 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2292D180075D for ; Thu, 14 May 2026 16:49:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7GXM8PH+uW7WqiDQ4CBH7mDW0qLBsJDT0hM+YPLPPIw=; b=LoROGgbqkS7tONqi873LBBpkzUWVuYyQcthgYjn4SDEDdZ55rpeTc69+rVz1amCHYazGgA EK8DqD+UGCz8yD1uVXieC8N7VguvhpyzuSkQucE0edFyhbFBcHxRnkVvgfnOjRJeXAUUhR c6fqeX1CpP05ln4Dlo2DWUcHwmaS6DU= X-MC-Unique: W4LtRbBDNHaUkdvBTcwgUw-1 X-Mimecast-MFC-AGG-ID: W4LtRbBDNHaUkdvBTcwgUw_1778777351 To: devel@lists.libvirt.org Subject: [PATCH 2/9] libvirt_probes: Fix alignment of 'virobject' probe points Date: Thu, 14 May 2026 18:48:59 +0200 Message-ID: <3b17e4091d4e9af225272ea0b1a6e78732e9476b.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: s4uUp8FhsJfK9mCQUpCXZdvjRjGxjM5pm0IyJ1JFsEY_1778777351 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3JOODUEX6ULYBDJFF6I43X62CWPRME5S X-Message-ID-Hash: 3JOODUEX6ULYBDJFF6I43X62CWPRME5S X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777494761158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt_probes.d | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libvirt_probes.d b/src/libvirt_probes.d index d9e75d9797..58d362ac6e 100644 --- a/src/libvirt_probes.d +++ b/src/libvirt_probes.d @@ -13,12 +13,12 @@ provider libvirt { probe event_glib_remove_timeout_idle(int timer, void *ff, void *opaque); probe event_glib_dispatch_timeout(int timer, void *cb, void *opaque); - # file: src/util/virobject.c - # prefix: object - probe object_new(void *obj, const char *klassname); - probe object_ref(void *obj); - probe object_unref(void *obj); - probe object_dispose(void *obj); + # file: src/util/virobject.c + # prefix: object + probe object_new(void *obj, const char *klassname); + probe object_ref(void *obj); + probe object_unref(void *obj); + probe object_dispose(void *obj); # file: src/rpc/virnetsocket.c # prefix: rpc --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777562; cv=none; d=zohomail.com; s=zohoarc; b=RwYvfnLDkgeXOWm0BICnPlO0yz8WSJb+xkbcfnEp3avMD/gCpe8kReUnmeTiy+l+h4oR5SIc9h7NgHM9qYWUqScSdM+uFRm1u5hGMi4t+u5sFFnIPMYBf1YZNgyhOH7kATp0fFwD4E119ZDcYUg1icoTDzxeBMxBBcKoIXmMpwE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777562; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=d1Gqp00mxGGsRaYLZYZzFF4VxxIFM0KyeQZXTRU6les=; b=DPiRSuedpjtf4Pl2tKXsGRDEDJxH8yhyyKjvpRiKXh+ml+DRvWreyA10mMj2lLvk1NUUHGqby3mox/JGD0I5XhwQxafOZYUPH7Fp8CbXpvXU0UZSSBueTJqTOs/uFmk5Yde0KAP80AKFUTMnmviIBkDVO5t4oGvU8dI0qs/TTSA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777562213327.7071762807401; Thu, 14 May 2026 09:52:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E934F41919; Thu, 14 May 2026 12:52:40 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 0763841B16; Thu, 14 May 2026 12:49:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 43580418E2; Thu, 14 May 2026 12:49:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 986E63F2F8 for ; Thu, 14 May 2026 12:49:14 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-Qo7imi-CMUyNL5qEUb45bA-1; Thu, 14 May 2026 12:49:12 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 090C71800371 for ; Thu, 14 May 2026 16:49:12 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 52E5918001E8 for ; Thu, 14 May 2026 16:49:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d1Gqp00mxGGsRaYLZYZzFF4VxxIFM0KyeQZXTRU6les=; b=EgANYeWvu4Lya/G70ES74sqjhk91bcLOYJpDgL2IQ0LZaNs7Dc/PkJHpS04sIjTr/Yds00 afgNaHbthI0MInxYJPctIrdm770155EawnSZdQi7s97gmMrj3Sqjr4X8GL6co36aplI+IQ o8A6BX8vw+H2gjjnNkJxyEGLCpsCWSQ= X-MC-Unique: Qo7imi-CMUyNL5qEUb45bA-1 X-Mimecast-MFC-AGG-ID: Qo7imi-CMUyNL5qEUb45bA_1778777352 To: devel@lists.libvirt.org Subject: [PATCH 3/9] util: probe: Add 'PROBE_DEBUG' Date: Thu, 14 May 2026 18:49:00 +0200 Message-ID: <255811332ff2f2ce605d042705336da3fdb6b65a.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jj_lrzulTLpcyaXVoghGfqBB2QPgRwNSSPP5Z3zU8Qo_1778777352 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XQ6LHV7463UH7GKNPL3PCFH7F4KT7L5H X-Message-ID-Hash: XQ6LHV7463UH7GKNPL3PCFH7F4KT7L5H X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777566182158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The standard 'PROBE' macro uses the 'info' priority for the log entry corresponding to the probe point. While in some cases it makes sense to log above debug priority in others it does not. Add the possibility to pick a lower priority level. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/util/virprobe.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/util/virprobe.h b/src/util/virprobe.h index 80a5f48ec8..d23b626d2f 100644 --- a/src/util/virprobe.h +++ b/src/util/virprobe.h @@ -90,6 +90,15 @@ VIR_ADD_CASTS(__VA_ARGS__)); \ } +# define PROBE_DEBUG(NAME, FMT, ...) \ + VIR_DEBUG_INT(&virLogSelf, \ + __FILE__, __LINE__, __func__, \ + #NAME ": " FMT, __VA_ARGS__); \ + if (LIBVIRT_ ## NAME ## _ENABLED()) { \ + PROBE_EXPAND(LIBVIRT_ ## NAME, \ + VIR_ADD_CASTS(__VA_ARGS__)); \ + } + # define PROBE_QUIET(NAME, FMT, ...) \ if (LIBVIRT_ ## NAME ## _ENABLED()) { \ PROBE_EXPAND(LIBVIRT_ ## NAME, \ @@ -101,5 +110,10 @@ __FILE__, __LINE__, __func__, \ #NAME ": " FMT, __VA_ARGS__); +# define PROBE_DEBUG(NAME, FMT, ...) \ + VIR_DEBUG_INT(&virLogSelf, \ + __FILE__, __LINE__, __func__, \ + #NAME ": " FMT, __VA_ARGS__); \ + # define PROBE_QUIET(NAME, FMT, ...) #endif --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777654; cv=none; d=zohomail.com; s=zohoarc; b=NxhFd+KC/qdLXooPTqQILaVgIk1DkG08gxfId2cb6OYgvm63Itd6fGWaS/N3dDZl4rHWFOQdS8vL/bO8yO7AV6xfnS7pUqSY77WhGWjwVrm6YC6bc93YeoSSgM8w2Emy3u2YNUwQUDAJjAtI9Fgv0eILfgnQ5qmrr5e//6bh/co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777654; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=WPASBFimJG7k0+rvnI2TyMOpMSV+njaeFlCfSjB3wu4=; b=Ie4CU5dTL6IHUf6czu7JXgGi4uh+m3SgV/FeUpWoZz5khAUzcCCMxlPtqfuSY+HeXhh2Y/RwqXMAzZPXmFV2nerapV+lRQeKRdszvvI18uuNUIEifrzratMOVup0qHix59IyjDqt1ziaXH74G6u6kGsLE51t0vM/otOjat1k/xI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777654224394.33359970617676; Thu, 14 May 2026 09:54:14 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3187D41915; Thu, 14 May 2026 12:54:13 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E57B9419DD; Thu, 14 May 2026 12:49:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BC3F341819; Thu, 14 May 2026 12:49:16 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E9A1341819 for ; Thu, 14 May 2026 12:49:15 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-ekDRflNLMWmZ2maDYnlBHQ-1; Thu, 14 May 2026 12:49:14 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D73B18005B5 for ; Thu, 14 May 2026 16:49:13 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8113F18004A3 for ; Thu, 14 May 2026 16:49:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WPASBFimJG7k0+rvnI2TyMOpMSV+njaeFlCfSjB3wu4=; b=etjA7IeVddx8jbl/iluj7WB7FZP6Rkx3YkotvVRZMq5ezRL9wLwTogEFRIyyLv8aXUjq23 4OEqTtHnED2AiZOCpNrhzGgxfO/cyvuKYnZhk34IsiBaq1gbjccGc7ryCJsnGusWPkwrvc nZFo2sBRSM+CRjNOtEq3UeXVd9eHwJc= X-MC-Unique: ekDRflNLMWmZ2maDYnlBHQ-1 X-Mimecast-MFC-AGG-ID: ekDRflNLMWmZ2maDYnlBHQ_1778777353 To: devel@lists.libvirt.org Subject: [PATCH 4/9] util: object: Downgrade PROBE points to PROBE_DEBUG Date: Thu, 14 May 2026 18:49:01 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G_bfDtizwpizxdEFF6Z7b3msQ8keLbVr2f_rPAFJdsE_1778777353 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MYZPLMVDOVIN2I7Q7GT5BPQ62YTMDDZY X-Message-ID-Hash: MYZPLMVDOVIN2I7Q7GT5BPQ62YTMDDZY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777657868158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The debug messages related to PROBE points in object handling don't really need to be logged with the 'info' priority. Downshift them to 'debug'. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/util/virobject.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virobject.c b/src/util/virobject.c index 92af4f9fd6..1aa42e62c1 100644 --- a/src/util/virobject.c +++ b/src/util/virobject.c @@ -253,7 +253,7 @@ virObjectNew(virClass *klass) priv =3D vir_object_get_instance_private(obj); priv->klass =3D klass; - PROBE(OBJECT_NEW, "obj=3D%p classname=3D%s", obj, priv->klass->name); + PROBE_DEBUG(OBJECT_NEW, "obj=3D%p classname=3D%s", obj, priv->klass->n= ame); return obj; } @@ -316,7 +316,7 @@ static void vir_object_finalize(GObject *gobj) virObjectPrivate *priv =3D vir_object_get_instance_private(obj); virClass *klass =3D priv->klass; - PROBE(OBJECT_DISPOSE, "obj=3D%p", gobj); + PROBE_DEBUG(OBJECT_DISPOSE, "obj=3D%p", gobj); while (klass) { if (klass->dispose) @@ -375,7 +375,7 @@ virObjectUnref(void *anyobj) return; g_object_unref(anyobj); - PROBE(OBJECT_UNREF, "obj=3D%p", obj); + PROBE_DEBUG(OBJECT_UNREF, "obj=3D%p", obj); } @@ -397,7 +397,7 @@ virObjectRef(void *anyobj) return NULL; g_object_ref(obj); - PROBE(OBJECT_REF, "obj=3D%p", obj); + PROBE_DEBUG(OBJECT_REF, "obj=3D%p", obj); return anyobj; } --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777837; cv=none; d=zohomail.com; s=zohoarc; b=ST/xpzZheVs0SUTkj2h/I2ADFdcipBlUd1CIMfnbPD8CpxEHc9vCGhQP37JsF1Ooyk473M4e9BLwVOhtpTkBZPNwYilIFOPM5RVaFItN8LpKyc5mlhpWJUPJXy2xeUCKLb1LmE9eOoOh9qz+gyrZYNnJ3wd9XMiY7di1OrpgHyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777837; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=16ggZ4CT3HLpr7UrOanmWr35rK0kEIIaGr7CX8/a6sE=; b=NVuSD5sP8gXlxsHnVfM+l4qbyKyVUqIbREb13njdxDqgPjhMJvuimBSKs+gDJpZwmHKCUThf5AlSQR44BBCxOoEdf/x212hzLtuuAF3cdbTuYtYzfb+M6M2YTXybijZ+MWRE/J6oHKLME/C/q+C1CjdfsA90qhfoQDciiJpEoMg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777837085808.8852543683029; Thu, 14 May 2026 09:57:17 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E5499419AA; Thu, 14 May 2026 12:57:15 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id F321741C2A; Thu, 14 May 2026 12:49:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A2B1F4191E; Thu, 14 May 2026 12:49:29 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 18059418F8 for ; Thu, 14 May 2026 12:49:17 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-icgXFmhOPXCPvTQCuvP7RA-1; Thu, 14 May 2026 12:49:15 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 665EF1956052 for ; Thu, 14 May 2026 16:49:14 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3F0B18004A3 for ; Thu, 14 May 2026 16:49:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=16ggZ4CT3HLpr7UrOanmWr35rK0kEIIaGr7CX8/a6sE=; b=IkBsS21jhDgAE8nDEbhGa7CfsMJrORe5Wa8hgnePLUWh3EboToo6IzBrcRgsGNX1piPkTR YqOSLZG6E7moxF3b0ityKhvYiOdjwbQnGvb0/QKZ1h+DH+RR4URhw78pHiEtckxV5W714s jTjphT6gni5sVrxOBGZFTxjhq7pvYGM= X-MC-Unique: icgXFmhOPXCPvTQCuvP7RA-1 X-Mimecast-MFC-AGG-ID: icgXFmhOPXCPvTQCuvP7RA_1778777354 To: devel@lists.libvirt.org Subject: [PATCH 5/9] util: object: Add class name to the Ref/Unref/Dispose debug messages Date: Thu, 14 May 2026 18:49:02 +0200 Message-ID: <444f2100deabb2d5639198d31fddb4d628a09b3c.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 96MM-0IDelEYQA_4pBQJDHDiAyrVnq1-N0gq_CibhIQ_1778777354 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QOIEV6V3RK65B5CNETCOQLHKEUUJ5IJB X-Message-ID-Hash: QOIEV6V3RK65B5CNETCOQLHKEUUJ5IJB X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777837393158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Since the object stores the pointer to the parent class object internally we can add the name of the class of the object to the debug messages. Since the debug messages are based on probe points propagate it into the probe point rather than adding separate debug message. For virObjectUnref, this also fixes the ordering of the messages to be 'unref->dispose' by invoking the PROBE before unref rather than the other way around which didn't make sense in the logs and wouldn't allow accessing the class pointer from the already disposed-of object. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt_probes.d | 6 +++--- src/util/virobject.c | 14 +++++++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/libvirt_probes.d b/src/libvirt_probes.d index 58d362ac6e..b73e9d6e82 100644 --- a/src/libvirt_probes.d +++ b/src/libvirt_probes.d @@ -16,9 +16,9 @@ provider libvirt { # file: src/util/virobject.c # prefix: object probe object_new(void *obj, const char *klassname); - probe object_ref(void *obj); - probe object_unref(void *obj); - probe object_dispose(void *obj); + probe object_ref(void *obj, const char *klassname); + probe object_unref(void *obj, const char *klassname); + probe object_dispose(void *obj, const char *klassname); # file: src/rpc/virnetsocket.c # prefix: rpc diff --git a/src/util/virobject.c b/src/util/virobject.c index 1aa42e62c1..0ccaaf101e 100644 --- a/src/util/virobject.c +++ b/src/util/virobject.c @@ -310,13 +310,14 @@ virObjectRWLockableNew(virClass *klass) return obj; } + static void vir_object_finalize(GObject *gobj) { virObject *obj =3D VIR_OBJECT(gobj); virObjectPrivate *priv =3D vir_object_get_instance_private(obj); virClass *klass =3D priv->klass; - PROBE_DEBUG(OBJECT_DISPOSE, "obj=3D%p", gobj); + PROBE_DEBUG(OBJECT_DISPOSE, "obj=3D%p classname=3D%s", gobj, klass->na= me); while (klass) { if (klass->dispose) @@ -370,12 +371,15 @@ void virObjectUnref(void *anyobj) { virObject *obj =3D anyobj; + virObjectPrivate *priv; if (VIR_OBJECT_NOTVALID(obj)) return; + priv =3D vir_object_get_instance_private(obj); + PROBE_DEBUG(OBJECT_UNREF, "obj=3D%p classname=3D%s", obj, priv->klass-= >name); + g_object_unref(anyobj); - PROBE_DEBUG(OBJECT_UNREF, "obj=3D%p", obj); } @@ -392,12 +396,16 @@ void * virObjectRef(void *anyobj) { virObject *obj =3D anyobj; + virObjectPrivate *priv; if (VIR_OBJECT_NOTVALID(obj)) return NULL; + g_object_ref(obj); - PROBE_DEBUG(OBJECT_REF, "obj=3D%p", obj); + + priv =3D vir_object_get_instance_private(obj); + PROBE_DEBUG(OBJECT_REF, "obj=3D%p classname=3D%s", obj, priv->klass->n= ame); return anyobj; } --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777883; cv=none; d=zohomail.com; s=zohoarc; b=btZMXMjcR7AupdZhJEqoWlNM3i5oRsK7grOSzFXZEvs1CC6QlrOFTJTkXa1CSZTtX0crFksjs+rhVuUneF3c9ftmZ1s00K7ub7r3Pr6+/r1XSD92Bcz86YArcyvqm0wV1y9gnl4nBlLGM0UwsjCiTdWcX8RE6G7RE+rPHRUIY1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777883; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Mt7ptMNzyJ1ditNW59WLbedBrQ6ueTkR56EPOfHW/Ow=; b=dTeN03r74rS0B/Lv6cR1MDe4oZwwjQyISvBbhGDgA8N2sP+9yxzWfPBUOxjL5L1RNoYxe9NRZHqKfmwxCAsXuzmdwyGDWC4XDxyxKRNiQUS370C2MAVy5W4gEqD6nGd6Liw5it7qUCIXnoC6GD/6/sL9VYEN8IkxfC/4ltpRcdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777883103797.9808779375379; Thu, 14 May 2026 09:58:03 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0B324418FD; Thu, 14 May 2026 12:58:01 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 096D541C4F; Thu, 14 May 2026 12:50:00 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 98A0741955; Thu, 14 May 2026 12:49:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3B8B241941 for ; Thu, 14 May 2026 12:49:18 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-kSo9CwsONwec9rpFfygtlg-1; Thu, 14 May 2026 12:49:16 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B2301956053 for ; Thu, 14 May 2026 16:49:15 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D087E18001E8 for ; Thu, 14 May 2026 16:49:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mt7ptMNzyJ1ditNW59WLbedBrQ6ueTkR56EPOfHW/Ow=; b=RYAlDNX1w0o41hPufuPNz+gTuJNW7kaSENKxOyk4Gyj/Hh+b6vQoEzPBPql0gXggtjLWC9 TW7oNSbD4NXDZJVKKrTuFoqUxpc47gtgrnNitP3Xm1YDm2CREMTYAoDYkUTrHDoByvj2rr ZKIdKXkFCJAuYfNVq7QVkm7KEGFMpSY= X-MC-Unique: kSo9CwsONwec9rpFfygtlg-1 X-Mimecast-MFC-AGG-ID: kSo9CwsONwec9rpFfygtlg_1778777355 To: devel@lists.libvirt.org Subject: [PATCH 6/9] daemonRemoveClientStream: Add debug log Date: Thu, 14 May 2026 18:49:03 +0200 Message-ID: <12bf263d772dfe8a963df9de59f78e0a79a4a7a2.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j86hBzSTn3hjP1TZq75hQjIU_ICZ6VraBhN4dBooBg8_1778777355 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PVS6DXQPJG2UGIWSAAKDHXPWJEGZHKGA X-Message-ID-Hash: PVS6DXQPJG2UGIWSAAKDHXPWJEGZHKGA X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777883770158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/remote/remote_daemon_stream.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_s= tream.c index 453728a66b..3777c8e684 100644 --- a/src/remote/remote_daemon_stream.c +++ b/src/remote/remote_daemon_stream.c @@ -480,8 +480,9 @@ daemonRemoveClientStream(virNetServerClient *client, daemonClientStream *curr =3D priv->streams; daemonClientStream *prev =3D NULL; - VIR_DEBUG("client=3D%p, proc=3D%d, serial=3D%u, st=3D%p", - client, stream->procedure, stream->serial, stream->st); + VIR_DEBUG("client=3D%p, proc=3D%d, serial=3D%u, st=3D%p, closed=3D%d", + client, stream->procedure, stream->serial, stream->st, + stream->closed); if (stream->filterID !=3D -1) { virNetServerClientRemoveFilter(client, --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778777930; cv=none; d=zohomail.com; s=zohoarc; b=ZvD7XmmPp3UgTqE1quqiFv2iRQjw7zZ+G046n2BcHoujcj6XnPqR7gRzluilwhEbqhDXr1PFc29YK5zw3p/n55Xk857EHsoyYg3NSyveRihLs36mpsFSy0KCT9T3tMt4R9YAsS3vX7iAJdDPQndmLcsQRoL+K3js7ZxTTbQyFmM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778777930; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=MTCSv4CJKMj1C3ZszwtdyDJT/vT7vo/sdArNQNMGenc=; b=Dhb59137LoCyQzI6/z9sz4yT7nIdDvccNtU8QBlrDrkOOVfp4pIZiBvxBeEzOmYF79L+nzr2X2l/2yYcolZ4e5uYTx4mrZFQwz5Xw+0EJoZEMrH7z/VYhqInDFrYXANi8L3nb4/LgitKeWNkWDKvHUi/kOumf7EVImgbdIEpGaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778777930481987.3325787898272; Thu, 14 May 2026 09:58:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6EB8C418E2; Thu, 14 May 2026 12:58:49 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id CE5F23F83C; Thu, 14 May 2026 12:50:07 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DEDC541980; Thu, 14 May 2026 12:49:39 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 980594197B for ; Thu, 14 May 2026 12:49:19 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-OpFLxDpCOgKR9G3AygPUfA-1; Thu, 14 May 2026 12:49:17 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BAE301956046 for ; Thu, 14 May 2026 16:49:16 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0B8B3180075D for ; Thu, 14 May 2026 16:49:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MTCSv4CJKMj1C3ZszwtdyDJT/vT7vo/sdArNQNMGenc=; b=MjTHUYpKLrxuVOb7nRQK5jLbnbYqhSVASjGtoXO4TmjEBdqDdzaNZRy4jGJoBZNu/2RzMQ 1GIO3GiUTkE8d/8Y/HZiI48X5XgSZtVOjIf1G4V/hyZQ18XZDemCd8J+/80+SXmaXma9s+ p1pHhpZJva325ZD8pq7eZHHsXjfss/A= X-MC-Unique: OpFLxDpCOgKR9G3AygPUfA-1 X-Mimecast-MFC-AGG-ID: OpFLxDpCOgKR9G3AygPUfA_1778777356 To: devel@lists.libvirt.org Subject: [PATCH 7/9] remoteClientFree: Add debug log of parameters Date: Thu, 14 May 2026 18:49:04 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C2-p3Yf1ODbzA4Tmh0u1_W3OVbjOB0xUVShVWJpFXck_1778777356 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EYSCMGPRX2JVLR4ZDNTYGNADWLAQE6E3 X-Message-ID-Hash: EYSCMGPRX2JVLR4ZDNTYGNADWLAQE6E3 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778777932165158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add a debug log when remote client is beng disposed of. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/remote/remote_daemon_dispatch.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 81b0ed00da..55a1bd2af8 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -1808,6 +1808,11 @@ void remoteClientFree(void *data) { struct daemonClientPrivate *priv =3D data; + VIR_DEBUG("priv=3D%p, conn=3D%p, interfaceConn=3D%p, networkConn=3D%p,= nodedevConn=3D%p, nwfilterConn=3D%p, secretConn=3D%p, storageConn=3D%p", + priv, priv->conn, priv->interfaceConn, priv->networkConn, + priv->nodedevConn, priv->nwfilterConn, priv->secretConn, + priv->storageConn); + if (priv->conn) virConnectClose(priv->conn); if (priv->interfaceConn) --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778778001; cv=none; d=zohomail.com; s=zohoarc; b=mwXlPrY1WJVs+LBsugyhMOLqM2LQwgLqhQlH2OBFFnVYakBm6yjDx42OFvMrby4+/pHHWiXJBzqrmeH9mUOJyYCSMmwqikRVTe++E0RdX45wOgC3oR/Z1RQqtsY43hnIKxRVWCBvO765LC/iQ4EkLepQCmQlbX0SG2Y9PnaYGzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778778001; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=5rm9MTLNkjr4kVH1hj+dqCMxfCpJx//Izzf0Fmf3x2g=; b=Jycv7JQbFt2u8aZq+G4M1tMyUmQxfcnwOi4edjaTM+Crus1xqtmXNRwothpfcL1cqEFHBEO61/wqZbhYrSWaLq3FYfNIsB4+dJ3MqOGyxn25+sNv557qnahW3p6Rct+yePXO7ND+8F80h88zONgRPqs6KpsulyyZexA/Ilg3n9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778778001508727.4462705183652; Thu, 14 May 2026 10:00:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5AA36419FF; Thu, 14 May 2026 12:59:59 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 8E42B41D1F; Thu, 14 May 2026 12:50:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F0FD841A0A; Thu, 14 May 2026 12:49:44 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F1352419E5 for ; Thu, 14 May 2026 12:49:20 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-Izm1qL_iOGW3S81WMl3zJQ-1; Thu, 14 May 2026 12:49:19 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 342AC19560A1 for ; Thu, 14 May 2026 16:49:18 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B790180075D for ; Thu, 14 May 2026 16:49:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5rm9MTLNkjr4kVH1hj+dqCMxfCpJx//Izzf0Fmf3x2g=; b=fucmgsLhWrI6kFBAKvNavEX1PLS/qhFoCgqLKCOMfEqS88c58u+niAastR9QiuDcDzeCEH jJ449L7Wj3n0WpTcO24YxH9y8b2ESL34GmvHhUkhOYUdbZhWPed0c2wdUH4VBc9DOQCmjK 0xx9Q7bl18ED4a/elqBhKimsWFoWDoo= X-MC-Unique: Izm1qL_iOGW3S81WMl3zJQ-1 X-Mimecast-MFC-AGG-ID: Izm1qL_iOGW3S81WMl3zJQ_1778777358 To: devel@lists.libvirt.org Subject: [PATCH 8/9] virNetClientStreamEventRemoveCallback: Add debug log Date: Thu, 14 May 2026 18:49:05 +0200 Message-ID: <5c0739bc6bfaa4e014b129f4d22e80dd3e0e8ce2.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gAMmzJmaL-hQOFp-LDxdKETZ4lD4CaRR1s69uX8zBEs_1778777358 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BNO7GRP3JAVOBPXDUMFEUMVNB32QFC3W X-Message-ID-Hash: BNO7GRP3JAVOBPXDUMFEUMVNB32QFC3W X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778778003000158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Log when removig event callback including internal state. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/rpc/virnetclientstream.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/rpc/virnetclientstream.c b/src/rpc/virnetclientstream.c index 380b785869..bad356f8f3 100644 --- a/src/rpc/virnetclientstream.c +++ b/src/rpc/virnetclientstream.c @@ -773,6 +773,10 @@ int virNetClientStreamEventRemoveCallback(virNetClient= Stream *st) int ret =3D -1; virObjectLock(st); + + VIR_DEBUG("st=3D%p, cbDispatch=3D%u, cbOpaque=3D%p, cbFree=3D%p", + st, st->cbDispatch, st->cbOpaque, st->cbFree); + if (!st->cb) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("no stream callback registered")); --=20 2.54.0 From nobody Tue Jun 9 21:14:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778778067; cv=none; d=zohomail.com; s=zohoarc; b=Ra11K3REqwbK8iXhN6Jda1+Xu7GmKGXEnshpO99jHF8zRiuK1Gk5zUU1eCet+J95vc9J0b0o0l14GNDqcyhRa3dPRLPC1vYd+KfrOGc8OhFHbzLlcCVnYJ+vYzmgFwNiRElMZFl0PlMPLzseGmNOrIMktHGeukui4UEhzXsgXwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778778067; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=zGM2JsxiKcVg5UajfxOwgETxhsfm8ONANe+1phUbUk0=; b=lm23+Igl0hFuvcFqBw5BcWE/qiHiEI3DGFe3VF9B460kguXkgIEv05XOK2hY//UkzKyCC5GVNsoUvRBnjJQgRi264SWyHcIOHcgnOmY0a3+w47Pv8bpo8o1regrSHxr074zsMI62rwzbT0N43sieBq22Fem+lWWBVl3Vwiw3DIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778778067127892.4038472690557; Thu, 14 May 2026 10:01:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DDFB1418F7; Thu, 14 May 2026 13:01:05 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D1BE541D0E; Thu, 14 May 2026 12:50:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3AD7041C7C; Thu, 14 May 2026 12:49:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1BA5741A17 for ; Thu, 14 May 2026 12:49:22 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-r2fYDsqjPJCkZtrbuDrxLw-1; Thu, 14 May 2026 12:49:20 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 43E1A1800603 for ; Thu, 14 May 2026 16:49:19 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90A7E180075C for ; Thu, 14 May 2026 16:49:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778777361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGM2JsxiKcVg5UajfxOwgETxhsfm8ONANe+1phUbUk0=; b=Z1vnst8IfpjpcaU6TltDINU0cd5Lp1q+upSGbrCgJq3GsLgc/GtHhHOGZ4BTIdcXYEnkW7 DroTSblzn6WyBLcWWiRLS0eEUnwhYZQS1LZX1jKengEGR+G93jdjAxamGLn1bv6MGBet8I rZH6RvCENKm1pM/6QJz5/jQ+7FQX88E= X-MC-Unique: r2fYDsqjPJCkZtrbuDrxLw-1 X-Mimecast-MFC-AGG-ID: r2fYDsqjPJCkZtrbuDrxLw_1778777359 To: devel@lists.libvirt.org Subject: [PATCH 9/9] util: virobject: Add debug refcounting output Date: Thu, 14 May 2026 18:49:06 +0200 Message-ID: <0beba9396594f4a06569098a1355f363d6b9101d.1778776606.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _3Ahpd5AwBbzZCSed7_xNhsgWd-4xXTtZNldDiHhNNw_1778777359 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6MNP7BEDUSQLI7VR2HSSRO4VJLD5IIL5 X-Message-ID-Hash: 6MNP7BEDUSQLI7VR2HSSRO4VJLD5IIL5 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778778068006158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa virObject internally uses g_object which doesn't expose the internal reference count. When debug logging we log ref/unref operations but when reading logs it's hard to follow if a precise reference count is needed at some points. Add a private reference counter variable and use it in debug messages of virObject operations. The code is designed so that it can be disabled if ever needed since it's just for debugging. For now let's keep it enabled. With all the informaton added the logs look like (timestamps trimmed): debug : virObjectRef:424 : OBJECT_REF: obj=3D0x7fffac001d30 classname=3Dqe= muMonitor refs=3D3 debug : virObjectUnref:392 : OBJECT_UNREF: obj=3D0x7fffac001d30 classname= =3DqemuMonitor refs=3D2 debug : virObjectNew:264 : OBJECT_NEW: obj=3D0x7fffac00db70 classname=3Dvi= rDomainEventAgentLifecycle debug : virObjectUnref:392 : OBJECT_UNREF: obj=3D0x7fffac00db70 classname= =3DvirDomainEventAgentLifecycle refs=3D0 debug : vir_object_finalize:328 : OBJECT_DISPOSE: obj=3D0x7fffac00db70 cla= ssname=3DvirDomainEventAgentLifecycle Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt_probes.d | 4 ++-- src/util/virobject.c | 23 ++++++++++++++++++++--- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/src/libvirt_probes.d b/src/libvirt_probes.d index b73e9d6e82..5f029c3eb6 100644 --- a/src/libvirt_probes.d +++ b/src/libvirt_probes.d @@ -16,8 +16,8 @@ provider libvirt { # file: src/util/virobject.c # prefix: object probe object_new(void *obj, const char *klassname); - probe object_ref(void *obj, const char *klassname); - probe object_unref(void *obj, const char *klassname); + probe object_ref(void *obj, const char *klassname, int refs); + probe object_unref(void *obj, const char *klassname, int refs); probe object_dispose(void *obj, const char *klassname); # file: src/rpc/virnetsocket.c diff --git a/src/util/virobject.c b/src/util/virobject.c index 0ccaaf101e..876a04789f 100644 --- a/src/util/virobject.c +++ b/src/util/virobject.c @@ -32,6 +32,8 @@ VIR_LOG_INIT("util.object"); +#define VIR_OBJECT_DEBUG_REFCOUNT 1 + static unsigned int magicCounter =3D 0xCAFE0000; struct _virClass { @@ -48,6 +50,9 @@ struct _virClass { typedef struct _virObjectPrivate virObjectPrivate; struct _virObjectPrivate { virClass *klass; +#if VIR_OBJECT_DEBUG_REFCOUNT + int refs; /* Informative reference count used for PROBE and debug mes= sages. */ +#endif /* VIR_OBJECT_DEBUG_REFCOUNT */ }; @@ -253,6 +258,9 @@ virObjectNew(virClass *klass) priv =3D vir_object_get_instance_private(obj); priv->klass =3D klass; +#if VIR_OBJECT_DEBUG_REFCOUNT + priv->refs =3D 1; +#endif /*VIR_OBJECT_DEBUG_REFCOUNT */ PROBE_DEBUG(OBJECT_NEW, "obj=3D%p classname=3D%s", obj, priv->klass->n= ame); return obj; @@ -372,12 +380,17 @@ virObjectUnref(void *anyobj) { virObject *obj =3D anyobj; virObjectPrivate *priv; + int refs =3D -1; if (VIR_OBJECT_NOTVALID(obj)) return; priv =3D vir_object_get_instance_private(obj); - PROBE_DEBUG(OBJECT_UNREF, "obj=3D%p classname=3D%s", obj, priv->klass-= >name); +#if VIR_OBJECT_DEBUG_REFCOUNT + refs =3D g_atomic_int_add(&priv->refs, -1) - 1; +#endif /* VIR_OBJECT_DEBUG_REFCOUNT */ + PROBE_DEBUG(OBJECT_UNREF, "obj=3D%p classname=3D%s refs=3D%d", + obj, priv->klass->name, refs); g_object_unref(anyobj); } @@ -397,15 +410,19 @@ virObjectRef(void *anyobj) { virObject *obj =3D anyobj; virObjectPrivate *priv; + int refs =3D -1; if (VIR_OBJECT_NOTVALID(obj)) return NULL; - g_object_ref(obj); priv =3D vir_object_get_instance_private(obj); - PROBE_DEBUG(OBJECT_REF, "obj=3D%p classname=3D%s", obj, priv->klass->n= ame); +#if VIR_OBJECT_DEBUG_REFCOUNT + refs =3D g_atomic_int_add(&priv->refs, 1) + 1; +#endif /* VIR_OBJECT_DEBUG_REFCOUNT */ + PROBE_DEBUG(OBJECT_REF, "obj=3D%p classname=3D%s refs=3D%d", + obj, priv->klass->name, refs); return anyobj; } --=20 2.54.0