From nobody Fri May 15 10:50:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1777460683; cv=none; d=zohomail.com; s=zohoarc; b=fuedEpPeb7V2xilPC5ZhBnY8Haisqaw8D8W8H9k60CPlRs7btaTYH5MpmAoxfdf4ns7S2VuoIV6iQcPZcCmliWBfN6wsTDWqNL/o2fENO713Ooams3Q93vsaP5R9N9zfIDeXxyv3byROKPKbnYyG+fIxNUZtrwxIIdZC93Zzw8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777460683; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=tig97TnG5dc9DWz/nT6ZmlnyufUlB/GtiGo7liMzW+g=; b=hHcNfGy+VbjMSuPMo88SRNnBsG2UeYrHilBIKHb9H8iyEhRfKrA8bGewEYBlR7QYY3DfOrFV+BR7sj53QTuP4KxPKjae5dGIu6mbz9cfJAuHvUg5g2no295yimWqTvA5Q8C/WFWzOu+vgmOQt9Zf9w7gKd1v1RTUly6Jp/vYoRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1777460683044171.58726570825525; Wed, 29 Apr 2026 04:04:43 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 55AC341850; Wed, 29 Apr 2026 07:04:41 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9C4B841993; Wed, 29 Apr 2026 07:00:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 22FD43F2F2; Wed, 29 Apr 2026 07:00:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 375063F2EF for ; Wed, 29 Apr 2026 07:00:31 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-P7yw7ywxMKCtedRu51c67A-1; Wed, 29 Apr 2026 07:00:29 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2606118002CA for ; Wed, 29 Apr 2026 11:00:28 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.17]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 303FD300019F for ; Wed, 29 Apr 2026 11:00:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777460430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tig97TnG5dc9DWz/nT6ZmlnyufUlB/GtiGo7liMzW+g=; b=d90iRihM2koiOrlVvBvLhFd/Fh/Z17Rbt0N0JaJ0iova92KqXGxbC8AuYwr9XDaOZ5k4Sv 3mdm7opv/gxVEilpDDd7/g+NrdVCFIOrqzWVEsTH3CebMYub5vhti7ZyGzCjzgLuIj7uNs xR8oGsaB8ZyUiDu3CHj3Pn+ZBJNo5X4= X-MC-Unique: P7yw7ywxMKCtedRu51c67A-1 X-Mimecast-MFC-AGG-ID: P7yw7ywxMKCtedRu51c67A_1777460428 To: devel@lists.libvirt.org Subject: [PATCH 1/4] qemuDomainGetStatsCpuProc: Don't fetch stats for inactive VMs Date: Wed, 29 Apr 2026 13:00:21 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NNqPuV8ETMbvcUzenJubyr9isZgf-8Ag4-lMMzp8Igs_1777460428 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: H5XVXWXWE3IRDSYJNPVVO3I4YQM4URUJ X-Message-ID-Hash: H5XVXWXWE3IRDSYJNPVVO3I4YQM4URUJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1777460684127158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa CPU stats for inactive VM make no sense. In this case it's especially misleading because 'vm->pid' of an inactive VM is '0' so virProcessGetStat returns stats for virtqemud itself. Fixes: 044b8744d65f8571038f85685b3c4b241162977b Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d227ac58cd..529e9fe3be 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17156,6 +17156,9 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm, unsigned long long userTime =3D 0; unsigned long long sysTime =3D 0; + if (!virDomainObjIsActive(vm)) + return; + if (virProcessGetStatInfo(&cpuTime, &userTime, &sysTime, NULL, NULL, vm->pid, 0) < 0) { /* ignore error */ --=20 2.54.0 From nobody Fri May 15 10:50:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1777460780; cv=none; d=zohomail.com; s=zohoarc; b=bBPtk/GK4WGFZbVhgIaoJ/sZ7nVnpkE/22H/3s4RFv43DsRde/WihTR9OkwKUVrAUoa9O1xWAVEANpcaWWfxqWIf8FBW9Ti92EBOpCC+7TRg/P5ONGgk7xu6WO6yNmngWVkzli/NSZ4t0Tsh3QwJ1orpAtdB66BNt491Y3TR9Lo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777460780; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=KMyRAhX2MgZsotgLVB1MztsnhET6wWSxM9KJC1WixCw=; b=KsZFChZh93QVy1hiBiMMDnpkeVe00Yyhd9Wq2AvxNfipNwM7SbgIzieyBKR1tTRbbRKD0aPhUo+XSL3crwAHDArs6WKPEnoj0obgv5OfG3FJYKwH3jk6yCGXlKXcMBsx1uh0jez3stvrppCVo8OMJXhqvGcatUzVnS6x57xFwtI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1777460780452499.72611337707315; Wed, 29 Apr 2026 04:06:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DDADE41844; Wed, 29 Apr 2026 07:06:19 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D3B3141ACC; Wed, 29 Apr 2026 07:00:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A71633F252; Wed, 29 Apr 2026 07:00:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3BBCB3F364 for ; Wed, 29 Apr 2026 07:00:33 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-f-BKvN9bPEaauemOCo6mKw-1; Wed, 29 Apr 2026 07:00:30 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 716211955F02 for ; Wed, 29 Apr 2026 11:00:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.17]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 91F0830001A1 for ; Wed, 29 Apr 2026 11:00:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777460432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMyRAhX2MgZsotgLVB1MztsnhET6wWSxM9KJC1WixCw=; b=c0FLsDez3w8Xw58afttrlZjViFQlXIk8sFN0cwNIEZ+lgK30oVYPcXa2S3nr+0dKXNTany 9oZBN51A8cmD1mB4GiQGrHZ4iD+BhAjIy8JZW5wu3Zzm9MHDCrmam4yJ3eShiKjLonCP8t f1jMszlLMPeBJuVIy+dG5vS6nRkl6Rc= X-MC-Unique: f-BKvN9bPEaauemOCo6mKw-1 X-Mimecast-MFC-AGG-ID: f-BKvN9bPEaauemOCo6mKw_1777460429 To: devel@lists.libvirt.org Subject: [PATCH 2/4] virProcessGetStatInfo: Improve debug message Date: Wed, 29 Apr 2026 13:00:22 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: njZ2xWys4kbf8omKgbUYQnjoz61RO5lwnF0eS4BgMic_1777460429 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RFO44IZKL35X67HXSXOI5R4MKZI6N4FZ X-Message-ID-Hash: RFO44IZKL35X67HXSXOI5R4MKZI6N4FZ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1777460782067154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Label the 'pid'/'tid' field. Use proper typecast also for 'tid'. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/util/virprocess.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index e06ed94b0d..97843d6f75 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1808,8 +1808,8 @@ virProcessGetStatInfo(unsigned long long *cpuTime, *vm_rss =3D rss * pagesize; - VIR_DEBUG("Got status for %d/%d user=3D%llu sys=3D%llu cpu=3D%d rss=3D= %lld", - (int) pid, tid, utime, stime, cpu, rss); + VIR_DEBUG("Got process stats for pid=3D%d tid=3D%d: user=3D%llu sys=3D= %llu cpu=3D%d rss=3D%lld", + (int) pid, (int) tid, utime, stime, cpu, rss); return 0; } --=20 2.54.0 From nobody Fri May 15 10:50:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1777460737; cv=none; d=zohomail.com; s=zohoarc; b=O5Fy6j/0mpsFiLtkRPlWMQGgo2YsRXsDlr523LT0OWExYE6ufMtMffDIMA4UuCl9yNM+7KLLtVjEqioEuV2D7oQQ3mttYpJMray7lpBDHxfJDTRHixGjgAmhXNPdAqb5Ay3OLFhYc7a7Yvu4EPPcz0xmfyV1TRw6hOboHxeFOc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777460737; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=NXo3C/Vvz24g5a3skj1fTP0gEMg3O8FWhMZURNx5lqY=; b=awKVbmqVvZ+VOQT1Rdtv80ySACCe/dOcBhvXgHj4GPLnfF22xHkHyvAzZNAm9z6ElycqOchPyrJuPpq/MZZozNrOho4wC7dd3irLte4crgioXkGVzuezAfn7Lpgh9/o0pAt5bufoC5gEmlN0Pd23EEkZuV4p8w+nnFjosXDvv1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 17774607370151010.9806557544698; Wed, 29 Apr 2026 04:05:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B870E41846; Wed, 29 Apr 2026 07:05:35 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 608E241A80; Wed, 29 Apr 2026 07:00:52 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A07603F363; Wed, 29 Apr 2026 07:00:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D11403F252 for ; Wed, 29 Apr 2026 07:00:36 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-8FpTosQJM9-GzD8vqvLC9A-1; Wed, 29 Apr 2026 07:00:31 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CF4C519560AA for ; Wed, 29 Apr 2026 11:00:30 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.17]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 01BB030001A1 for ; Wed, 29 Apr 2026 11:00:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777460436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXo3C/Vvz24g5a3skj1fTP0gEMg3O8FWhMZURNx5lqY=; b=d+i+IGrsViJXE1gGf7vxYU4BKA0F1YEyKJjGmOtRMD7F4b+mGzt7OuCl+lvGwVd0s2JiZb dtzG0frdXlpj7rXMoKXCSShxTjtmKO6DFcUCjqdE6f6qs0z7TKX0KtDVUJ5oEn3+6IwjDi TOgZfaxjwtUlDtiEwkYJD2V57MqJCZo= X-MC-Unique: 8FpTosQJM9-GzD8vqvLC9A-1 X-Mimecast-MFC-AGG-ID: 8FpTosQJM9-GzD8vqvLC9A_1777460431 To: devel@lists.libvirt.org Subject: [PATCH 3/4] vsh: Suppress attempts to write to stderr when it was closed in 'cmdComplete' Date: Wed, 29 Apr 2026 13:00:23 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FaI6Bxw-qRUtCA3fIDLHIanJbMxYFYhwHG4Ycf87CUY_1777460431 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GXQIPTHH5YADNTOZFWTMPMZILMQTC36V X-Message-ID-Hash: GXQIPTHH5YADNTOZFWTMPMZILMQTC36V X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1777460738462158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The completer closes stderr to suppress anything poluting the shell when completion would cause any errors. Since 'virshReconnect' would call 'vshError' on connection failure this causes vshError to be killed by SIGPIPE and not provide any completions if the connection is not possible. To avoid this add a flag called 'stderr_closed' to vshControl and use it to suppress output in 'vshPrintStderr'. Keep only the log. Prior to this patch, attempt to run completion on a host with all daemons shut down would result in: # virsh complete -- "start" "--doma" ; echo $? 141 # With this patch the completion will still fail but the return code will be 1. Further patch will allow completion. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tools/vsh.c | 5 +++++ tools/vsh.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/tools/vsh.c b/tools/vsh.c index 74016c0043..c84d17a332 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2145,6 +2145,9 @@ vshPrintStderr(vshControl *ctl, if (ctl) vshOutputLogFile(ctl, level, str); + if (ctl->stderr_closed) + return; + /* Most output is to stdout, but if someone ran virsh 2>&1, then * printing to stderr will not interleave correctly with stdout * unless we flush between every transition between streams. */ @@ -3577,6 +3580,8 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd) if (!ctl->imode) { if (virOnce(&vshCmdCompleteCloseStdinStderrOnce, vshCmdCompleteClo= seStdinStderr) < 0) return false; + + ctl->stderr_closed =3D true; } if (!(hooks && hooks->connHandler && hooks->connHandler(ctl))) diff --git a/tools/vsh.h b/tools/vsh.h index bd2494e899..1c5a69b04e 100644 --- a/tools/vsh.h +++ b/tools/vsh.h @@ -225,6 +225,8 @@ struct _vshControl { const vshClientHooks *hooks;/* mandatory client specific hooks */ void *privData; /* client specific data */ + + bool stderr_closed; /* stderr was closed for the 'complete' co= mmand */ }; typedef void * --=20 2.54.0 From nobody Fri May 15 10:50:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1777460847; cv=none; d=zohomail.com; s=zohoarc; b=XJlWOBGz3o1ArnM2emsl5xfNZ02/pbGkS7UGII+iF4oL4GTPkorYUrOoWh9fz1UgbAp7km7jGIWqkVDC44Uo1CSpIQb1CzHAHCnrzJ96rMYYDfPgn9MnNtzmpNxIdEN7WKsikFEYE8oE911Rr2mI1prX8slJv+JP/+AxpD7zR18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777460847; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qBat0/5bHrqv3/+n351wDd1+ylsBljnc7BKOMpdTXM0=; b=N0GezHBdF1GDo0X2caWgxKyuwLF7rPfuwDGOcDBob1pS5/ok8CVduIYpFU+Q/qen/ziFisjp9k6t53zygGuNFiWXCpsvI4RglZGpwa2hm70Pft8ovKq4FDxNbJsaNJpnZ7YhRk+w2usGZOuadL7/1eDKaoxHHqDoj3mYSyQnRAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1777460847348417.04732037874373; Wed, 29 Apr 2026 04:07:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 87A363F870; Wed, 29 Apr 2026 07:07:25 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 718C141B32; Wed, 29 Apr 2026 07:01:00 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id ADC203F2EF; Wed, 29 Apr 2026 07:00:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 878353F83C for ; Wed, 29 Apr 2026 07:00:34 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-UyybKwGtNpux64sI23Nvag-1; Wed, 29 Apr 2026 07:00:32 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0ACFF18004AD for ; Wed, 29 Apr 2026 11:00:32 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.17]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 47003300019F for ; Wed, 29 Apr 2026 11:00:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777460434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qBat0/5bHrqv3/+n351wDd1+ylsBljnc7BKOMpdTXM0=; b=b6u0ZP9tFwY93g3gDa8tOG3gYK4f6HY47DWX27Q0jUozPx2MmT10cPzek4zD3sHUq7L3CC wGaaFnsfMbYFJ33RjNnvo8JpSMIflWbEuN36yzjwJEiHds6u+h5OEhKZOaBsax7HO9F2O/ 5eaOzs+1QBmNmXhpokcehFrEooFLY30= X-MC-Unique: UyybKwGtNpux64sI23Nvag-1 X-Mimecast-MFC-AGG-ID: UyybKwGtNpux64sI23Nvag_1777460432 To: devel@lists.libvirt.org Subject: [PATCH 4/4] vsh: cmdComplete: Don't exit when connecting to the daemon fails Date: Wed, 29 Apr 2026 13:00:24 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5sYMmDpEDpSY32RshuK_OxeiQk-L2l0bBNQM3YvU3os_1777460432 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Y5XWG4W7KTOXXUSTYG67N62YMA3WZ4TU X-Message-ID-Hash: Y5XWG4W7KTOXXUSTYG67N62YMA3WZ4TU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1777460851381154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Invoke the 'connHandler' without checking return value. 'virsh complete' can provide useful completions even when the daemon connection is broken. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tools/vsh.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index c84d17a332..ccf2f21d64 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3584,8 +3584,11 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd) ctl->stderr_closed =3D true; } - if (!(hooks && hooks->connHandler && hooks->connHandler(ctl))) - return false; + /* Attempt connecting so that we can also do completions based on e.g. + * object names work. Failure to connect is not fatal because we want + * at least argument completion */ + if (hooks && hooks->connHandler) + ignore_value(hooks->connHandler(ctl)); vshReadlineInit(ctl); --=20 2.54.0