From nobody Wed Apr 15 07:00:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1775586469; cv=none; d=zohomail.com; s=zohoarc; b=dwfWEqN074sIbWc3WY0Kg4mx2NUIxSuBb8OCxfnpDHF8r6QmTiOBzLUocC5A4pC/jDcUtAOC9cMCHyQvA3YGVifATcXndUexlYJewMcLuLJfn/5K+0CwdgddiheOfYMi7e73451XuwC3hf4my5VSYYWyZXFgswYSzOQnTWQ8qoM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775586469; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=afkPxJIQr2uryxHGh0m+BEC5/WnUgO/8x1RDqskXr6E=; b=WaW+dHD9LjXGUZRbjks+a8V/ZGRMfcUeVCceY5BTvBxoXglz1MQObnTsG9GhbJviejVlKXMnHQL0K0uawuFdvvVxkCYlmlatZxd/+62UaRfZ1J1FziTIinwjR5vOErUaF081X0WulEYmdtdL5lPZ5F69d+u17DBTx7sfQvxVGX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1775586469550971.6637800502214; Tue, 7 Apr 2026 11:27:49 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B9F673F8AB; Tue, 7 Apr 2026 14:27:48 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 51106418E2; Tue, 7 Apr 2026 14:26:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6B01D3F2F3; Tue, 7 Apr 2026 14:26:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AEBBB3F2FA for ; Tue, 7 Apr 2026 14:26:24 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-uQUhcXO0O7uUKyKpMyKebg-1; Tue, 07 Apr 2026 14:26:23 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 27929195608F for ; Tue, 7 Apr 2026 18:26:22 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.44.49.56]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 65FEE1800576 for ; Tue, 7 Apr 2026 18:26:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775586384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=afkPxJIQr2uryxHGh0m+BEC5/WnUgO/8x1RDqskXr6E=; b=fHRHk0zsEAGTaoaEUVfynnK+JZ+F9FbVUZVM0xcVSuQbHimSHuyfKObs9FPG8Wa77EyYD3 FYkJzlNhquNTt/3W5tt5RMj/BPWsNQHv8+p/5VVuKFgtM2tMh/BJ42kxhJ/oKbC/ALTGCC 770jrr2lRsy8VYZ8VhD09EZvUBmHUuQ= X-MC-Unique: uQUhcXO0O7uUKyKpMyKebg-1 X-Mimecast-MFC-AGG-ID: uQUhcXO0O7uUKyKpMyKebg_1775586382 To: devel@lists.libvirt.org Subject: [PATCH 1/4] qemuBlockStorageSourceGetNFSProps: Fix memory handeling Date: Tue, 7 Apr 2026 20:26:15 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tiKCPw20klA5G63hJIBPFt1IKD8tC2MYxTIsj6dYOyA_1775586382 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 35TEASEQDRQXULGXC4BEIIIXHAE6V6K3 X-Message-ID-Hash: 35TEASEQDRQXULGXC4BEIIIXHAE6V6K3 X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1775586470635158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina We would leak ret if the remaining two virJSONValueObjectAdd() calls would fail but it will not happen with current code. Fixes: c7570bbef89b20058095270e07fad0dcc8f60e7a Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/qemu/qemu_block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 9b43279797..7986db8e76 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -433,7 +433,7 @@ static virJSONValue * qemuBlockStorageSourceGetNFSProps(virStorageSource *src) { g_autoptr(virJSONValue) server =3D NULL; - virJSONValue *ret =3D NULL; + g_autoptr(virJSONValue) ret =3D NULL; =20 if (!(server =3D qemuBlockStorageSourceBuildJSONNFSServer(&src->hosts[= 0]))) return NULL; @@ -458,7 +458,7 @@ qemuBlockStorageSourceGetNFSProps(virStorageSource *src) virJSONValueObjectAdd(&ret, "i:group", src->nfs_gid, NULL) < 0) return NULL; =20 - return ret; + return g_steal_pointer(&ret); } =20 =20 --=20 2.53.0 From nobody Wed Apr 15 07:00:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1775586505; cv=none; d=zohomail.com; s=zohoarc; b=knYHJzP50JqGBV3DY2M1Jq2IMBSIfEyAPbPtRSPtIB3/lyYrPg+aLJ4zuT7jYvg8zONlPW3isg8WV0VvwDOSNK8M2lyf4pfLDAWCwxCMQK3EO5xcS5lvBIBxdMvFoYISofADTzBKvwFYdDdEymnt7/pbOYNtZODavy4OoE07dLo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775586505; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=i28hukGj2bv8MXpFWKz2H+9LHHRR2+IXzX98cwjzM6g=; b=iuBKBfQw+Ggu4RbIasoucqcTZA+fKI42dgm27jqcTkXY6SGjv+9f8kbEJvhIUmLw/QrWyXgQR3jwwAOxjonDagtkfPrcxwqdCxM7Cz47L+V+srUSGjIDkoZylMMnER+n8OXbQ0NvFYZrCFsHsg2V+wwvWxTtr4KnLvB01ZIcqaM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1775586505020958.1266770661297; Tue, 7 Apr 2026 11:28:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 20CDC418AD; Tue, 7 Apr 2026 14:28:24 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 760A63F95A; Tue, 7 Apr 2026 14:26:33 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5B9A73F2EF; Tue, 7 Apr 2026 14:26:26 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D18F93F2FA for ; Tue, 7 Apr 2026 14:26:25 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-iyHQ4QjkPWyNY7cF8AU63Q-1; Tue, 07 Apr 2026 14:26:24 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F23318002CA for ; Tue, 7 Apr 2026 18:26:23 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.44.49.56]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90111180035F for ; Tue, 7 Apr 2026 18:26:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775586385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i28hukGj2bv8MXpFWKz2H+9LHHRR2+IXzX98cwjzM6g=; b=d0VLNMOyzuySDCwGjh84VHek1V/gGEkOJ9IXGYOlPmp4P9WCveS6hEeFO6Bq6FzJQK+W9e 72w2uUjOD5X/qA3/0jGEnZXtiEQLZT9y/0didP8Vb9hAFlMIFNPTvzZ0xwtH06P2PSkMDd +NzbK9avt+oMRZNzKR7jhhRufIvHU8E= X-MC-Unique: iyHQ4QjkPWyNY7cF8AU63Q-1 X-Mimecast-MFC-AGG-ID: iyHQ4QjkPWyNY7cF8AU63Q_1775586383 To: devel@lists.libvirt.org Subject: [PATCH 2/4] nodeDeviceEventSubmit: Fix memory leak Date: Tue, 7 Apr 2026 20:26:16 +0200 Message-ID: <6f2796ee483ec06939fb13d1af52b7aebbfe34e0.1775586330.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Lm9ay36od4n0vzKProjvtBzous3B1797GLcKkDtAT6U_1775586383 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6W453DODQRYCKQ6FBN42JB6RVSGBLL6Y X-Message-ID-Hash: 6W453DODQRYCKQ6FBN42JB6RVSGBLL6Y X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1775586506803158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina In case driver is null we would leak memory allocated in event. Fixes: b56458d443ba1d890d336535b5840252cbb9df4b Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/node_device/node_device_udev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 89aca2d4d6..104433fb88 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -183,7 +183,7 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(nodeDeviceEvent, nodeDevi= ceEventFree); */ static int nodeDeviceEventSubmit(nodeDeviceEventType eventType, void *data= , virFreeCallback dataFreeFunc) { - nodeDeviceEvent *event =3D g_new0(nodeDeviceEvent, 1); + nodeDeviceEvent *event =3D NULL; udevEventData *priv =3D NULL; =20 if (!driver) @@ -191,6 +191,7 @@ static int nodeDeviceEventSubmit(nodeDeviceEventType ev= entType, void *data, virF =20 priv =3D driver->privateData; =20 + event =3D g_new0(nodeDeviceEvent, 1); event->eventType =3D eventType; event->data =3D data; event->dataFreeFunc =3D dataFreeFunc; --=20 2.53.0 From nobody Wed Apr 15 07:00:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1775586536; cv=none; d=zohomail.com; s=zohoarc; b=EhQIrTo6Gt3n8+FtQrEBWV5oNsTHpmc84KeEblRstSzgKE/8UowqHK3AKwb1LeqAtZ4X/B+LVsmVy3o33k0TfAWwazdkEe3HR0MnQiEq9661zjLvUZUVHSmTVqnj45cbzYV3IPFPZKKWf4LbG5KiCxp9k1w4SyfDI2sy35PLSog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775586536; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=JOm4KhnRdUlyFMmYAyRC3IWJ4CmwkhHHBfARvdUI4L4=; b=Y3VTWV19edBAV9FSrFpkVd7QGMlJ5xN3Yp2VICjFJGvjvbeWlTRnjYt7cy5nmA9qdIsQHC10mgNgb+mJx+LudgIxIXJa2XXT+c0KYZfnKzVZV62QCT8WPFtobk0U1S1Nc/sOmKACMX4+DrdroyYPgBt/cubQ4RrbZrSvCQkexWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1775586536537361.46160082775646; Tue, 7 Apr 2026 11:28:56 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BFDB53F8B4; Tue, 7 Apr 2026 14:28:55 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 6517541A7F; Tue, 7 Apr 2026 14:26:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1649E3F2FA; Tue, 7 Apr 2026 14:26:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D08193F2EF for ; Tue, 7 Apr 2026 14:26:26 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-kxxh5JimN42xfkcGFRKcgQ-1; Tue, 07 Apr 2026 14:26:25 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C33E18005B8 for ; Tue, 7 Apr 2026 18:26:24 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.44.49.56]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BA5BA180035F for ; Tue, 7 Apr 2026 18:26:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775586386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOm4KhnRdUlyFMmYAyRC3IWJ4CmwkhHHBfARvdUI4L4=; b=CA7w1t6HTKGKXkwYzF2bWc0SEx6+VBrwLTY0VyMWW6ocBs+JYvJw+yVE8rol5rSheHRLyF JbTqE1EQqkO8MnrrvSSM1veXTn1WznLQRwzehfuDsh4NQXdaiNKuTq9k7gYaSCk2Or3PAL XzEd/ktkvYlksv2Vd5oKgXqrkbVlo3k= X-MC-Unique: kxxh5JimN42xfkcGFRKcgQ-1 X-Mimecast-MFC-AGG-ID: kxxh5JimN42xfkcGFRKcgQ_1775586384 To: devel@lists.libvirt.org Subject: [PATCH 3/4] virStorageVolPoolRefreshDataFree: Fix memory leak Date: Tue, 7 Apr 2026 20:26:17 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2dYpSR2SKVSWQQyLtq6LaZP8dzysix-v4_f0tAFz0ms_1775586384 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FDZW6W74K7ORCPQ4EFSGHMC6V2HBNNUU X-Message-ID-Hash: FDZW6W74K7ORCPQ4EFSGHMC6V2HBNNUU X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1775586538715154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina When vol_path was added it missed adding free as well. Fixes: 03e750f35d6d8cc39dcdeb893b96e732bd2315ef Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/storage/storage_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index e19e032427..22ce462a63 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2259,6 +2259,7 @@ virStorageVolPoolRefreshDataFree(void *opaque) virStorageVolStreamInfo *cbdata =3D opaque; =20 g_free(cbdata->pool_name); + g_free(cbdata->vol_path); g_free(cbdata); } =20 --=20 2.53.0 From nobody Wed Apr 15 07:00:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1775586566; cv=none; d=zohomail.com; s=zohoarc; b=TIWqK9v0iffUOilpkaql2tquX0kgaGuYk1jL4EF/ITlVi2IXvx8siz6FERaHzHjOXQ8Qgm4qOvSu7DVH8JPLA7445+mZi79lP1qXILGgd7wcpxs+FvGJz0ywgW0indPeXK0wEAty/JFQ0JyzzgMeGSHRv3l8oYv59fl/TQw2HAU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775586566; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Du9j+8MWzuAxrQTMnrBGGi08mYeZciswqOwRi2uDDf4=; b=V7upm8sSWsBt1xZB1R/muiJ802T6JTgFxkDfQD91GbkWjc1LWBaIMmajxxEv1FLnJ3H8Cyl7L7cZBPDZwESqLAqLiBbCXwuavxgmXvwNLcYQadnVIDxJ5ZnD2zYAo8P7QIO2jAH347BNnxCiyqJ6TiRrnoTdUrxbY58nrwt7suk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177558656615464.72619409377262; Tue, 7 Apr 2026 11:29:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 62FF13F8AF; Tue, 7 Apr 2026 14:29:25 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id AAA9441AD5; Tue, 7 Apr 2026 14:26:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8B8643F2FA; Tue, 7 Apr 2026 14:26:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 14C3D3F2F3 for ; Tue, 7 Apr 2026 14:26:28 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-W_cKdu2AOba5gWFGdTl5BQ-1; Tue, 07 Apr 2026 14:26:26 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BD58A19560AF for ; Tue, 7 Apr 2026 18:26:25 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.44.49.56]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E5EFD1800351 for ; Tue, 7 Apr 2026 18:26:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775586387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Du9j+8MWzuAxrQTMnrBGGi08mYeZciswqOwRi2uDDf4=; b=JP9KDgbYkaNXyL/oxBXGv2yxII65ETACs/1MB0jzxLuATDQSuKoxolncZWWvJXiUshSd1J IlDu3pE/baaiXWjbuJiZTcmJsbV8XFqBg0vc5zSFUp15qDySPGVjXpX4iVCHuCx3XfLdxk +1h8GDK7YUiwffSwhGKClpaeM8T2/fE= X-MC-Unique: W_cKdu2AOba5gWFGdTl5BQ-1 X-Mimecast-MFC-AGG-ID: W_cKdu2AOba5gWFGdTl5BQ_1775586385 To: devel@lists.libvirt.org Subject: [PATCH 4/4] qemuDomainSetThrottleGroup: Fix memory leak Date: Tue, 7 Apr 2026 20:26:18 +0200 Message-ID: <613f5eb88425510e88ea0ecdd0fffc912464d685.1775586330.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uZP0JbPSEwWJoRbz4g7eLtoxQA3oUkKB_yD2CJXlepo_1775586385 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4DSD6A23ZPZYTB5AWTAAPUCWM4RA2T2A X-Message-ID-Hash: 4DSD6A23ZPZYTB5AWTAAPUCWM4RA2T2A X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1775586567051158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina The commit missed freeing group_name in info and conf_info structs. Fixes: 937f300c5626eca91da1f29e33c3621b457626df Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 861795724a..2d31d4aa31 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20579,6 +20579,8 @@ qemuDomainSetThrottleGroup(virDomainPtr dom, virDomainObjEndJob(vm); =20 cleanup: + VIR_FREE(info.group_name); + VIR_FREE(conf_info.group_name); virDomainObjEndAPI(&vm); virTypedParamsFree(eventParams, eventNparams); return ret; --=20 2.53.0