From nobody Thu Apr 2 18:53:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774547513; cv=none; d=zohomail.com; s=zohoarc; b=ktUzEMXYPYean7bF14SqcygZE3/WO7sfbZw3dJo1cf3o3U1vNYyGTANJqHu3L5FNswCGbrla5coS9mdIXcmlETweZftw6i0mQPTdmiJSKbaewIiRhsF2oVV2nnvqhkvNz5f2CxHE1rT1z3urebNg54a6OPV3DagKiSPU8F39wcY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774547513; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=m0Z3BKUi+Irq0cXhzBdzbaipyY3O/OJQMHeYeVfDnPU=; b=UWot5h+d0vkCinFFpOL1xgG6T4vVSHaIPVazg8LRtekxzg8+vbmLpQ/FWU4BDdaEyXU0CZnhIl0V6m+IKrXNC1ZOhJKX/TkQfpRpVo90Opaef6Ka7REo4WE/wL4b+IU/XjW6Z6zoVYRq/vMd4xVjL6HpWXAqbXdEBw5czBUpID8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774547513003417.9142261201723; Thu, 26 Mar 2026 10:51:53 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 30FD93FA2D; Thu, 26 Mar 2026 13:51:52 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 27421418C8; Thu, 26 Mar 2026 13:50:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 979F83F309; Thu, 26 Mar 2026 13:50:30 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 088EB3F27C for ; Thu, 26 Mar 2026 13:50:29 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-EpLHGoM6Ooec9UtNhSSyBA-1; Thu, 26 Mar 2026 13:50:28 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BED019560A2 for ; Thu, 26 Mar 2026 17:50:27 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 63D8A1955D71 for ; Thu, 26 Mar 2026 17:50:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774547429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0Z3BKUi+Irq0cXhzBdzbaipyY3O/OJQMHeYeVfDnPU=; b=GDTYJ2/Wox7cXJexIqHxdmRBu/qxQMS7A7ptMFwEE0lTvb4UboOQDjAKpehLZavTmH31+L +RgtVQaXsRVGRNLTUQ+SdXh/VN7fh0g0YGCGYW6GhdWKsrlBErcJ/fdQ+8cxkBuNfTabid 68V6sJpnZlf8ZPX2duc/ns2kelk33Rg= X-MC-Unique: EpLHGoM6Ooec9UtNhSSyBA-1 X-Mimecast-MFC-AGG-ID: EpLHGoM6Ooec9UtNhSSyBA_1774547427 To: devel@lists.libvirt.org Subject: [PATCH 1/3] qemu: driver: Don't leak 'qemu_driver->backupPorts' Date: Thu, 26 Mar 2026 18:50:21 +0100 Message-ID: <5e191e3ea85a3a519a2a8b4de29c9b0d8023dd79.1774547384.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PFrVNm26ik20OgDQjuH97DYrKgKnPTv9IT-OIafPUPE_1774547427 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LWYG2UKPCXXDU5ZYG74UJK4SUQD2WOFM X-Message-ID-Hash: LWYG2UKPCXXDU5ZYG74UJK4SUQD2WOFM X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774547515084158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa =3D=3D2413993=3D=3D 23 (16 direct, 7 indirect) bytes in 1 blocks are defin= itely lost in loss record 1,238 of 4,225 =3D=3D2413993=3D=3D at 0x48FC683: calloc (vg_replace_malloc.c:1678) =3D=3D2413993=3D=3D by 0x4ED0A51: g_malloc0 (in /usr/lib64/libglib-2.0.= so.0.8600.4) =3D=3D2413993=3D=3D by 0x49A62CF: virPortAllocatorRangeNew (virportallo= cator.c:104) =3D=3D2413993=3D=3D by 0xEA35F27: qemuStateInitialize (qemu_driver.c:72= 3) =3D=3D2413993=3D=3D by 0x4BABC76: virStateInitialize (libvirt.c:667) =3D=3D2413993=3D=3D by 0x40148D4: daemonRunStateInit (remote_daemon.c:5= 83) =3D=3D2413993=3D=3D by 0x49BB8A5: virThreadHelper (virthread.c:256) =3D=3D2413993=3D=3D by 0x52DD463: start_thread (in /usr/lib64/libc.so.6) =3D=3D2413993=3D=3D by 0x5360413: clone (in /usr/lib64/libc.so.6) Fixes: 36cf50f85b9c8f3351332dc5302401e4b06176e1 Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ca26356a03..861795724a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1037,6 +1037,7 @@ qemuStateCleanup(void) virLockManagerPluginUnref(qemu_driver->lockManager); virSysinfoDefFree(qemu_driver->hostsysinfo); virPortAllocatorRangeFree(qemu_driver->migrationPorts); + virPortAllocatorRangeFree(qemu_driver->backupPorts); virPortAllocatorRangeFree(qemu_driver->webSocketPorts); virPortAllocatorRangeFree(qemu_driver->rdpPorts); virPortAllocatorRangeFree(qemu_driver->remotePorts); --=20 2.53.0 From nobody Thu Apr 2 18:53:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774547581; cv=none; d=zohomail.com; s=zohoarc; b=ZZUbawJvDiEO1unozrzPzF0azuBF7LhacVIp7x/7o5SPbDPbGRgjnkO690UzNQQfGxEMVxxVChmZILSHL/ii6YAF0ffkheKSnpP0SLKqFm0CBDTm4hFmsEHi7WAe6wf+Mc3A4cQ88dSWsPEJW8k696kSYtR0anO1KCKZzEm4NK4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774547581; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=/vcIz9hvwqtx22w812t48/EsaPgz+Pj2xZTxweCkN28=; b=Po7QXbH51PF84btUD9WhuNYV5Vk0sbEBTY/ubT32x4bZlBMUgs8Y1VFClUtsP4Air+UnPEtYRtKVLLGN1jW43LAyajCr4cksVoSBPX2qzf15Ph8PXS5mn/vARbqQQdQBbd6MEzpL4JvuaWb127GOaDKXekMjggoqIr6UQaxRvMI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774547581746952.2246919369009; Thu, 26 Mar 2026 10:53:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 190653F366; Thu, 26 Mar 2026 13:53:01 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A4C544199E; Thu, 26 Mar 2026 13:50:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 43D573FD2B; Thu, 26 Mar 2026 13:50:43 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A09103F365 for ; Thu, 26 Mar 2026 13:50:32 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-YmeNWyC2NUKbu1yZxC93aA-1; Thu, 26 Mar 2026 13:50:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9117919560AA for ; Thu, 26 Mar 2026 17:50:28 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B154A1955D84 for ; Thu, 26 Mar 2026 17:50:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774547432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/vcIz9hvwqtx22w812t48/EsaPgz+Pj2xZTxweCkN28=; b=CMkc+xdzosYn/PBNaaqJnU6xlcS5drEw1zBtNL0ZGfUeFZLolJDESqk1inZOokkh5kyxc4 goGroNoNCx8ZSUw9eMf2nXdKKk2EnKkBdxNUn6icy4FzMEBTEFYClY7xyts0p0+0RCcChB zpEz6VnstWFNIMDrXuYPpKBaUwznMRw= X-MC-Unique: YmeNWyC2NUKbu1yZxC93aA-1 X-Mimecast-MFC-AGG-ID: YmeNWyC2NUKbu1yZxC93aA_1774547428 To: devel@lists.libvirt.org Subject: [PATCH 2/3] secret: config: Don't leak 'cfg->secretsEncryptionKey' Date: Thu, 26 Mar 2026 18:50:22 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jju4A3NuvmzqwSK7Z0JlcwVFX5Go3hbZTnhGFB0R3YY_1774547428 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3SXUDPYZ2FMWJ5S4WA3BPPERK5E2OSZW X-Message-ID-Hash: 3SXUDPYZ2FMWJ5S4WA3BPPERK5E2OSZW X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774547584746154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa =3D=3D2413993=3D=3D 8,193 bytes in 1 blocks are definitely lost in loss re= cord 4,201 of 4,225 =3D=3D2413993=3D=3D at 0x48FC897: realloc (vg_replace_malloc.c:1804) =3D=3D2413993=3D=3D by 0x4ED0B0A: g_realloc (in /usr/lib64/libglib-2.0.= so.0.8600.4) =3D=3D2413993=3D=3D by 0x494112B: virReallocN (viralloc.c:52) =3D=3D2413993=3D=3D by 0x49684F6: saferead_lim (virfile.c:1511) =3D=3D2413993=3D=3D by 0x4968C8B: virFileReadLimFD (virfile.c:1587) =3D=3D2413993=3D=3D by 0x4968D2C: virFileReadAll (virfile.c:1613) =3D=3D2413993=3D=3D by 0xC2CC488: virGetSecretsEncryptionKey (secret_co= nfig.c:93) =3D=3D2413993=3D=3D by 0xC2CC488: virSecretDaemonConfigNew (secret_conf= ig.c:162) =3D=3D2413993=3D=3D by 0xC2CADFD: secretStateInitialize (secret_driver.= c:533) =3D=3D2413993=3D=3D by 0x4BABC76: virStateInitialize (libvirt.c:667) =3D=3D2413993=3D=3D by 0x40148D4: daemonRunStateInit (remote_daemon.c:5= 83) =3D=3D2413993=3D=3D by 0x49BB8A5: virThreadHelper (virthread.c:256) =3D=3D2413993=3D=3D by 0x52DD463: start_thread (in /usr/lib64/libc.so.6) Fixes: 1c86748cf140a8710d6d8ec3ab3a2bd10ceeac67 Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/secret/secret_config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/secret/secret_config.c b/src/secret/secret_config.c index 84514ac5d5..01db4bbe33 100644 --- a/src/secret/secret_config.c +++ b/src/secret/secret_config.c @@ -175,5 +175,6 @@ virSecretDaemonConfigDispose(void *obj) virSecretDaemonConfig *cfg =3D obj; virSecureErase(cfg->secretsEncryptionKey, cfg->secretsKeyLen); + g_free(cfg->secretsEncryptionKey); g_free(cfg->secretsEncryptionKeyPath); } --=20 2.53.0 From nobody Thu Apr 2 18:53:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774547551; cv=none; d=zohomail.com; s=zohoarc; b=mxSx0yKu/tRdzZVZosyOiVYdvOdyAkcQyqNQd2nJdow8SaeWpNEsN2JrCTh2jgBQZMDu2zJsN2foibu/i4y54AxV5/6fuVj+JiOUPQXWy3/9nOBAWpAYIVXDlDlOwEIbt3A247znk96NkJ/BzRu9K1acl9GFhzLxUQ7cvABOktk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774547551; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=o0VoYQSoeKULvteh51kIFxupyVQCjD7DQRAX4SaLbkc=; b=BTcb3BEYEhIV446ABdZnSm/lJ2vpaiYA+Fn2sad0eQFQHhlaJurW0jdx+mz/b+WMHd802qul/5nOmuDspEiKigGI33RlsNkB+R2Et6gZGIa+hTnt3EJudKSwj+xZpcLnu/0DR1GFp/9fepxxEGk8st8jbjr5hsv3Gj0OgeQuR2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774547551207988.8426606966553; Thu, 26 Mar 2026 10:52:31 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6489E3F345; Thu, 26 Mar 2026 13:52:30 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 95DF941954; Thu, 26 Mar 2026 13:50:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 12E413F8A0; Thu, 26 Mar 2026 13:50:43 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9AAFB3F363 for ; Thu, 26 Mar 2026 13:50:32 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-L-5z2BisNNq1TAD6882yfQ-1; Thu, 26 Mar 2026 13:50:30 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C9BB2195608C for ; Thu, 26 Mar 2026 17:50:29 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0DC491955D84 for ; Thu, 26 Mar 2026 17:50:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774547432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o0VoYQSoeKULvteh51kIFxupyVQCjD7DQRAX4SaLbkc=; b=TbkWnniMF5eEz+V6+IUmMsGyMowihyFaohy0q9LTrMmJE6Nedr4bxcnSGfPxtEYo/SsyRP zH/j/XWuvHfiYYGzISULAEDtmYPrfJ7k5F0jHHXx0Wk6J/D0zmcGDNlYC87EvLT1tUDYhp beor2Hj/IWQ+ZprBAcotB4NWGNq4cAI= X-MC-Unique: L-5z2BisNNq1TAD6882yfQ-1 X-Mimecast-MFC-AGG-ID: L-5z2BisNNq1TAD6882yfQ_1774547429 To: devel@lists.libvirt.org Subject: [PATCH 3/3] util: file: Shrink buffer returned from 'saferead_lim' to actual size Date: Thu, 26 Mar 2026 18:50:23 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FgmAQVIzF9Or_pFz0YzlK-PUtRdMNbOEdRu_34uvkik_1774547429 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: U7R45WCKK4TSBW3PSFKM6U4SA7E5IQJP X-Message-ID-Hash: U7R45WCKK4TSBW3PSFKM6U4SA7E5IQJP X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774547553257158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The bufer resizing algorithm resizes the buffer in increments of the value of the 'BUFSIZ' macro. On linux it's currently 8k. In case when the caller wants to retain the buffer for long time with little data read this creates massive overhead. Realloc the buffer to actual size before returning it to the user. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/util/virfile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virfile.c b/src/util/virfile.c index 91d5853481..fbcaf15429 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1523,6 +1523,7 @@ saferead_lim(int fd, size_t max_len, size_t *length) break; buf[size] =3D '\0'; *length =3D size; + VIR_REALLOC_N(buf, size + 1); return buf; } } --=20 2.53.0