From nobody Fri Apr 3 08:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363396; cv=none; d=zohomail.com; s=zohoarc; b=Dv2YPsiZJuXkNU5bUpRLLQxe406ozkJyMnLDhihqqBhyi9/sZV2UQGgdanL1TeP9OEDMFqMkiulChGHvaDjTpF/DvvhWL3L/NCkoZStLVrR8Dk60qkiqItFwx6IFCiQ9VIrYsvBnwj9+/wfnbxzm8C5U5Idy6hZAxVuh2CPsTQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363396; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=eJpznMUoc0miPIXmErUDT+Yk7iJDVYLZF1q8Dv0ByaU=; b=AnfA9a75HPy7upfi2szDY6KILJ7ZESGtdq+EpSVHtFi4j9QFOXq1F0oqUssXW/9kOkrSSahvV01YIllW0wPY0uHai4IbBxMt97Ag4gqVTBiKsj0/5zSoIaWDWRxIaEFIky04+HDFSgvxJj8Uk7PyDlhfkFbGw5GK1If3Vn945Bw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774363396334782.1481990125027; Tue, 24 Mar 2026 07:43:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C05323F890; Tue, 24 Mar 2026 10:43:15 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id AFB563F8A5; Tue, 24 Mar 2026 10:42:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 765613F28F; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 475B13F252 for ; Tue, 24 Mar 2026 10:42:31 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-sX-6LDCVMyOHVLP01VYDqA-1; Tue, 24 Mar 2026 10:42:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C94B195609F for ; Tue, 24 Mar 2026 14:42:28 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B081E1955D71 for ; Tue, 24 Mar 2026 14:42:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eJpznMUoc0miPIXmErUDT+Yk7iJDVYLZF1q8Dv0ByaU=; b=RJfcesdaFCDYdDsWV9xv5012XFNyKuVeyP9ZT7OHjOI8Q3YnsdlVRipww4smrpR1Ta/y2D f7DFkxbcOYuA9a9IcIqkqfgHBRk4fWEytNRldSYFutx4Dr9Q2a+q8CkITSyZrX2McH7rlV O1niiJROoCaYpa5gYFWI5pKQQnW/sH8= X-MC-Unique: sX-6LDCVMyOHVLP01VYDqA-1 X-Mimecast-MFC-AGG-ID: sX-6LDCVMyOHVLP01VYDqA_1774363348 To: devel@lists.libvirt.org Subject: [PATCH 1/4] virDomainGetBlockInfo: Log 'disk' argument Date: Tue, 24 Mar 2026 15:42:21 +0100 Message-ID: <30d37f9f8060caf944d730ee053615b4b8eb6fbd.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XmzhYaAfVY3-5EwPNBw163INCzGcP6E6Lt5nIabJBoI_1774363348 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CS3LUZLB3SUBMTOW3WMI7MDYBLSPR7EY X-Message-ID-Hash: CS3LUZLB3SUBMTOW3WMI7MDYBLSPR7EY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363399470154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The 'disk' argument was forgotten in the VIR_DOMAIN_DEBUG statement so the logs don't contain which disk the caller wanted the stats for. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-domain.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6b8783d57f..cc19a214ce 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6681,12 +6681,15 @@ virDomainMemoryPeek(virDomainPtr dom, * Since: 0.8.1 */ int -virDomainGetBlockInfo(virDomainPtr domain, const char *disk, - virDomainBlockInfoPtr info, unsigned int flags) +virDomainGetBlockInfo(virDomainPtr domain, + const char *disk, + virDomainBlockInfoPtr info, + unsigned int flags) { virConnectPtr conn; - VIR_DOMAIN_DEBUG(domain, "info=3D%p, flags=3D0x%x", info, flags); + VIR_DOMAIN_DEBUG(domain, "disk=3D'%s', info=3D%p, flags=3D0x%x", + disk, info, flags); virResetLastError(); --=20 2.53.0 From nobody Fri Apr 3 08:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363437; cv=none; d=zohomail.com; s=zohoarc; b=Ymf8bwHGtd/o2PkC7cdzmgPrL3BNAuwXEOAXFvW4LmJrGVq53aERyq2eBnDLQLVZcq+b/ootrOzyd0Hi76GZ2r9FocGzjOg1GHbQJ51i1/OExREkgpHpYaCITzZ9IlEwJjjsNW6+cCRpYhq/8zG/ILgBJEAdnRP36lLYVxgtgCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363437; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=hFsj+vkMDFRB7Oo4XAQgor/pSCV7oFUu5pCkTRjpzUs=; b=ezu0DySqlXhPKepRODckInTJvDpxjBESSnfbn+hNzl2rLr05J/ed0bQOfG3thTsPb2byaffbmogDkkQIkby3kLjSbxJc9xWrjMeZC0NfuV1D8I6FqQqk3zcs1hezQfWGQAzCwXtBnhXRaRrpxVAH0S0V02oadgzYlXQNr3avDdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774363437001271.2908077432837; Tue, 24 Mar 2026 07:43:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 177F33F2F8; Tue, 24 Mar 2026 10:43:56 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B264F3F362; Tue, 24 Mar 2026 10:42:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B68523F280; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 38F863F282 for ; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-VcAuKZKHOTSIkZ6m_NpRtA-1; Tue, 24 Mar 2026 10:42:30 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3E70195608C for ; Tue, 24 Mar 2026 14:42:29 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC5751955D71 for ; Tue, 24 Mar 2026 14:42:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFsj+vkMDFRB7Oo4XAQgor/pSCV7oFUu5pCkTRjpzUs=; b=SSGqpIO/lkhlv6BlLduTpkoG25baE7x9pmD1TBKT6SkJyxvtyrDhjgoRD5ID1/m8Ei6vN8 LAw2yOEz2oywb5oaNJfcffc1dpZk7fdWNbOEH36hVmN66BYdigFRlx+xveGBzy83zrkYGQ r0kMYrejevE4QIbedblYOGPvfDXBSQY= X-MC-Unique: VcAuKZKHOTSIkZ6m_NpRtA-1 X-Mimecast-MFC-AGG-ID: VcAuKZKHOTSIkZ6m_NpRtA_1774363350 To: devel@lists.libvirt.org Subject: [PATCH 2/4] qemuDomainGetStatsBlockExportDisk: Export stats also for 'dataStore' Date: Tue, 24 Mar 2026 15:42:22 +0100 Message-ID: <4c3fa111e6aaf8c833db74eae8ecf7d97964f389.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MVQZsOV99l9mzFXfkg7VnYcJqIvoxqzaPFad7l-9GNE_1774363350 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KUBWT4PG7MCA6X3IK75NUTBS5DSMBPMF X-Message-ID-Hash: KUBWT4PG7MCA6X3IK75NUTBS5DSMBPMF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363442196154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa For qcow2 disk images backed by another storage for storing the actual blocks (the 'data-file' feature) we forgot to export stats in the bulk stats API. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6fa6170b6f..d92269d3b6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17906,6 +17906,20 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef= *disk, if (!visitBacking) break; + + if (virStorageSourceIsBacking(n->dataFileStore)) { + qemuDomainGetStatsBlockExportHeader(disk, n->dataFileStore, + *recordnr, params); + + qemuDomainGetStatsOneBlock(cfg, dom, params, + qemuBlockStorageSourceGetEffectiveN= odename(n->dataFileStore), + n->dataFileStore, + *recordnr, stats); + + qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSo= urceGetStorageNodename(n->dataFileStore), + stats, *recordnr, = params); + (*recordnr)++; + } } /* in blockdev mode where we can properly and uniquely identify images= we --=20 2.53.0 From nobody Fri Apr 3 08:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363502; cv=none; d=zohomail.com; s=zohoarc; b=AeAwQk9nsJT/wMtbbEk/FNmlDKhja0SAoDebZhVNKe8pouDCd/ulM996nVFy8dQwQaJQPjXqSjQNoSiIc9LWMOmsf1CK2ZSiO5eORAs52MDwJwGxQj2lhhISi5SIzU6tKo241ksCBT9WFpydjMdn59OORZ5z951YfE7gMpxZGPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363502; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=rAPaB5ClfS7jdTsuH0aD8+yTEozgBEbI/RmMVVBOajQ=; b=DBPPh8ajaqhyUqMRT1r6M/fRfp6XhVpTzlNvq29gTF+ZWwLTSlJehdq/yyI88iw6otzoOCeGt1SlEEpoZSonzRxVC+GBlAtCNjUwDM7F6y4rkLN6xCQqED68/ZV2b6phNFFuyDV5fWDjWIarLihgab2TQSRMogh9elwgIbXN+Eg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774363502422181.26571773258013; Tue, 24 Mar 2026 07:45:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 672953F28B; Tue, 24 Mar 2026 10:45:01 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5C0A841987; Tue, 24 Mar 2026 10:42:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id CEAEB3F27C; Tue, 24 Mar 2026 10:42:33 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 56ADD3F252 for ; Tue, 24 Mar 2026 10:42:33 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-VV7XmE0jP9e9AnKGUZy9Tg-1; Tue, 24 Mar 2026 10:42:31 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F1ECC195609D for ; Tue, 24 Mar 2026 14:42:30 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 441291955D71 for ; Tue, 24 Mar 2026 14:42:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAPaB5ClfS7jdTsuH0aD8+yTEozgBEbI/RmMVVBOajQ=; b=MXxWMkz4QkrwGoGngDbn83Dxd59ZoyJOxe8c7qggbbT9IddXb5nbQ/vKV/BLPk1+HcAzIu Ewx9Wy5bckI+jPgNDZrIS4myM2QkGL48KSLJ0bg86ODsxnsIyCnar3aIccISsiLJG1srgp NgGBYJ/2gTuzFBXBJMhdaClm0LoRTtY= X-MC-Unique: VV7XmE0jP9e9AnKGUZy9Tg-1 X-Mimecast-MFC-AGG-ID: VV7XmE0jP9e9AnKGUZy9Tg_1774363351 To: devel@lists.libvirt.org Subject: [PATCH 3/4] qemu: monitor: Separate stats from capacity properties in qemuBlockStats Date: Tue, 24 Mar 2026 15:42:23 +0100 Message-ID: <484292e17fb0395abe6ece7a44db9fcfcf38ec0e.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oydpVEvaxv8pKdHlGrnOmyW45TTRchsp5rCutdwsM20_1774363351 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HMGO4723LXJXPNHQS4DUTIFSKLRJWLPZ X-Message-ID-Hash: HMGO4723LXJXPNHQS4DUTIFSKLRJWLPZ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363504087158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_monitor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index d3611d9713..34a345942f 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -851,6 +851,7 @@ struct _qemuBlockStats { unsigned long long wr_total_times; unsigned long long flush_req; unsigned long long flush_total_times; + unsigned long long capacity; unsigned long long physical; --=20 2.53.0 From nobody Fri Apr 3 08:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363540; cv=none; d=zohomail.com; s=zohoarc; b=ka0Qisl/DCRasyAMcSEASKBSpNpWbC8MeHk3Ltgkxl7/O688qXHtW7yKq79lxrygEOSR7GsXcpGQdOwutH/2h3rtsMkzUWQe/c/Qw64TPugnw/sw6aH9OlIyQgJ9gWqxskEzrQtnMmUkcL0774mnmg3RAcPFm6FHJ6Mml13YZlI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363540; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=UwrPPvJBH2ZuBVzZNHqlg1dLLC0VAheBP7bEglT0Z5o=; b=RMDjvkLsmg30xUgUt9kU4BVgU9oy7az1nZgxPcigOSVSwbgEcRRhNQQqWCpVZwMoVQg/8lWpjlloNh9q7W1e3ediiQgR50eVZzSP7bastFzQlvRCiG4VqLLQros49tpFnhFaxrPRCZRA9dXSmKmzVyXAY0gctQjElHzTbHqHhnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177436354046769.00213158428403; Tue, 24 Mar 2026 07:45:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 827613F33E; Tue, 24 Mar 2026 10:45:39 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8D4393F342; Tue, 24 Mar 2026 10:42:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 337763F881; Tue, 24 Mar 2026 10:42:55 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0AE443F835 for ; Tue, 24 Mar 2026 10:42:36 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-CR0H2x2DOTm1nYBDVIWmCw-1; Tue, 24 Mar 2026 10:42:33 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 559E3195608B for ; Tue, 24 Mar 2026 14:42:32 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 70AD41955D71 for ; Tue, 24 Mar 2026 14:42:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwrPPvJBH2ZuBVzZNHqlg1dLLC0VAheBP7bEglT0Z5o=; b=HPLHXvEHgxzqp6L/g12ewmu6HcvRevY0OfdZHDywwMC2anGjI80Ieb4bJDAv6gyfZjDo+d Garb5/99h/D36aIrLTqeY97rE3SJgChuXVAapn2EMKtKidACMdv+bo069nD4E70S0x7XnG 5rS18d0MhsqYLjkTqLr5KtS4pLNTSWg= X-MC-Unique: CR0H2x2DOTm1nYBDVIWmCw-1 X-Mimecast-MFC-AGG-ID: CR0H2x2DOTm1nYBDVIWmCw_1774363352 To: devel@lists.libvirt.org Subject: [PATCH 4/4] qemuDomainGetBlockInfo: Add debug statement when updating disk physical size Date: Tue, 24 Mar 2026 15:42:24 +0100 Message-ID: <08ff65aee75a92001351a5b1209ca6836c5a7f31.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BgdU6Puqec8E1BWdDH3e1mUrhZAUJWKBBmo6fBucnnQ_1774363352 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6HECSYH6K3Q5M5FVS3X3DYFYVL6WRV7J X-Message-ID-Hash: 6HECSYH6K3Q5M5FVS3X3DYFYVL6WRV7J X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363542511158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Update of the physical size fetches it from stat()-ing the file on disk, which is not visible in the logs so the information can't be pieced back together as it's the case with the data fetched from the qemu monitor. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d92269d3b6..f4805a93ca 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10664,6 +10664,7 @@ qemuDomainGetBlockInfo(virDomainPtr dom, info->allocation =3D entry->physical; if (qemuDomainStorageUpdatePhysical(cfg, vm, disk->src) =3D=3D 0) { + VIR_DEBUG("updating physical disk size to '%llu'", disk->src->= physical); info->physical =3D disk->src->physical; } else { info->physical =3D entry->physical; --=20 2.53.0