From nobody Fri Apr 3 17:32:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774303120; cv=none; d=zohomail.com; s=zohoarc; b=dYcyfhgINB2zHaZJVy2fedLsDxEVOX8maF3IITSww8FwATZhTzBCCRTXvufLZwesYJT7NSeH0PDGQxaoGqMMcujQV49NjOSBU8+u0Ch98iXX9X5OIxIsAWrrOQILk/JB2IFp4jWLYkV2hG/BtxcJlgnDbSSZ6AZW/W71HBEGK8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774303120; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Fbg3MoBI3Sae2rybSMSCFYXsQmTwM/+uWfkYdx5ZgEo=; b=SXA3TML4jHjkb5FZTtqy2w0WDxN68m4HKx/nvf8ACYyUY4f6SEKvGF6Y0UFIC9ITShjfDc0xmXk7gmRNrIZ8sf02hC3m/JKox2oD8lTxVGnRyjXmixYqHQxJbq2FsbR71bX/Y4S5i+QIytnbvtlv9dOlz+N4EdfurCLnLFzQc5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774303120815512.8563351098527; Mon, 23 Mar 2026 14:58:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F09303F348; Mon, 23 Mar 2026 17:58:39 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1A1AB3F303; Mon, 23 Mar 2026 17:57:30 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C9A863F280; Mon, 23 Mar 2026 17:57:23 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 54A613F292 for ; Mon, 23 Mar 2026 17:57:23 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-tVWp_MFWPJOAYxEoKwqOBA-1; Mon, 23 Mar 2026 17:57:21 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A8A11800561 for ; Mon, 23 Mar 2026 21:57:20 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D64D619560B1 for ; Mon, 23 Mar 2026 21:57:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774303043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fbg3MoBI3Sae2rybSMSCFYXsQmTwM/+uWfkYdx5ZgEo=; b=Sq7E31G8eEvBxavf90fQQsQZU3wpmnI77UII1HDFOF0J2lncxCSLtiy3arljUq1mR8ZYwj 90F6zGPVA/LP2tgy30zpz2qQO24vgvWkJWuNLd7WJ3JBq4PtHN5s8x60U+f1+v10X85XhZ e25Tg3CTCeIVs4mwWBMNqVoMSNrwXDo= X-MC-Unique: tVWp_MFWPJOAYxEoKwqOBA-1 X-Mimecast-MFC-AGG-ID: tVWp_MFWPJOAYxEoKwqOBA_1774303040 To: devel@lists.libvirt.org Subject: [PATCH v2 1/2] qemuMigrationSrcBeginXML: Don't call 'qemuMigrationSrcBeginPhaseBlockDirtyBitmaps' with offline VM Date: Mon, 23 Mar 2026 22:57:16 +0100 Message-ID: <29c135ad7f8a8fef302454aefd549feb4448511a.1774302819.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WWXiZeFGai33KQUwUmjEBGZXusovTcdpG3Sju7VX-G4_1774303040 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CSBXHU4J66UM6VH2KSKZC3EPBPKMBXJ7 X-Message-ID-Hash: CSBXHU4J66UM6VH2KSKZC3EPBPKMBXJ7 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774303122767158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Commit a4f610ff3fe190058f1 made the call to 'qemuMigrationSrcBeginPhaseBlockDirtyBitmaps' inside 'qemuMigrationSrcBeginXML' unconditional. This unfortunately means that it was called also with 'VIR_MIGRATE_OFFLINE'. Attempting to enter the monitor in such case results in an error: error: operation failed: domain is no longer running Restrict the call only to non-offline migration. Fixes: a4f610ff3fe190058f18baea18b095d0bc69441b Resolves: https://redhat.atlassian.net/browse/RHEL-156800 Closes: https://gitlab.com/libvirt/libvirt/-/work_items/865 Signed-off-by: Peter Krempa Reviewed-by: Jiri Denemark --- src/qemu/qemu_migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index fec808ccfb..cd4ddde897 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2692,7 +2692,8 @@ qemuMigrationSrcBeginXML(virDomainObj *vm, if (!(mig =3D qemuMigrationCookieNew(vm->def, priv->origname))) return NULL; - if (qemuMigrationSrcBeginPhaseBlockDirtyBitmaps(mig, vm) < 0) + if (!(flags & VIR_MIGRATE_OFFLINE) && + qemuMigrationSrcBeginPhaseBlockDirtyBitmaps(mig, vm) < 0) return NULL; if (qemuMigrationCookieFormat(mig, driver, vm, --=20 2.53.0 From nobody Fri Apr 3 17:32:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774303152; cv=none; d=zohomail.com; s=zohoarc; b=bEGSc7rwiMHXW+ty4b/kEiheeA3lI0EWA9OfwuzZlHsQNXu5lOdK0bsIJ8mRNlKZjfmO5zmDvZI/Q022MFxFlqpQXJynKNcmOAxAqcK1mFZdQzxjo5XlaxpnkH/G3nwDnZlwFkAjqsuZ0XoLVZIxtR9SdWcOvaS+JsqxLoQXRro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774303152; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=odtOl1GeLu+cKZtoniO5cv2Rw98H3PfjVb5e7b5ipb0=; b=at9dxG5WChrEDxcgLSjbT01zxcajgB1o+icsNzsih1YCnEedgaZbtzynUHSKsqomzXPIo2EMX2PULAZFVkZFp4gtavJQABN2CJ1oqyb7a/eWniTpc6TwkfMRT9dSLaz4gGhhuAyf2+7wg5aQwTgFC5KVbWP4tHpMRrkCDNfMdcw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177430315268586.97035266154091; Mon, 23 Mar 2026 14:59:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 17A373F2FA; Mon, 23 Mar 2026 17:59:12 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 239D2418FE; Mon, 23 Mar 2026 17:57:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 053323F2F3; Mon, 23 Mar 2026 17:57:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 814223F292 for ; Mon, 23 Mar 2026 17:57:24 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-96deNs4ZNw2tJcY6PxgVJQ-1; Mon, 23 Mar 2026 17:57:22 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 16DFF19560A2 for ; Mon, 23 Mar 2026 21:57:22 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 04AC419560B1 for ; Mon, 23 Mar 2026 21:57:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774303044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odtOl1GeLu+cKZtoniO5cv2Rw98H3PfjVb5e7b5ipb0=; b=QNk3aGl5l/kX1wjXaGnoOBbVEth0WuXhMO+Nkybqg4FvRkDDrEK7qqHQwGA6fndCsMFwLl YBW0f8lVV1+XwH9NqxRmaxY65F7cTfL4/oB6Sey6ZtKtzYickPwJ05UvZjwUv4mYt8ePMH ox97mpvOPlpjrVFjiZdzrk5k36w5Iyg= X-MC-Unique: 96deNs4ZNw2tJcY6PxgVJQ-1 X-Mimecast-MFC-AGG-ID: 96deNs4ZNw2tJcY6PxgVJQ_1774303042 To: devel@lists.libvirt.org Subject: [PATCH v2 2/2] qemuMigrationSrcBeginPhase: Don't call 'qemuBlockNodesEnsureActive' with offline VM Date: Mon, 23 Mar 2026 22:57:17 +0100 Message-ID: <21a34a026c3dbd2f7f4243980c4ac3dd70a1a9b6.1774302819.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nvSe67PItfK21b6WWDJHhkEKSmX2TkhgIu3eXX1P0Xg_1774303042 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CYYWHOJPY2BX2JON6NCK5PXA5XBTDGSZ X-Message-ID-Hash: CYYWHOJPY2BX2JON6NCK5PXA5XBTDGSZ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774303153681154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Commits 7b5566ce67b18a and f879d5f40385358 ( v11.8.0-92-gf879d5f403 ) moved around code for re-activating block backends after migration. While previously it was done when migration failed now we do it when we need qemu to do some block operations. 'qemuBlockNodesEnsureActive' is thus called also when 'VIR_MIGRATE_OFFLINE' is used. This doesn't cause failure similar to previous patch only due to a conincidence as 'qemuCaps' wasn't initialized yet and thus we assume that QEMU doesn't support 'blockdev-set-active' and skip all monitor code. Make the code more robust and explicit by calling 'qemuBlockNodesEnsureActive' only on active VMs during migration. Fixes: 7b5566ce67b18a2bebe68fdb07e046f25185f8d3 Signed-off-by: Peter Krempa Reviewed-by: Jiri Denemark --- src/qemu/qemu_migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index cd4ddde897..c0fa4623a4 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2871,7 +2871,8 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, vm->newDef && !qemuDomainVcpuHotplugIsInOrder(vm->newDef))) cookieFlags |=3D QEMU_MIGRATION_COOKIE_CPU_HOTPLUG; - if (qemuBlockNodesEnsureActive(vm, vm->job->asyncJob) < 0) + if (virDomainObjIsActive(vm) && + qemuBlockNodesEnsureActive(vm, vm->job->asyncJob) < 0) return NULL; return qemuMigrationSrcBeginXML(vm, xmlin, --=20 2.53.0