From nobody Mon Mar 23 23:24:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774016296; cv=none; d=zohomail.com; s=zohoarc; b=dRX9YxUpuyzL71F4pvLFIbryDYMj3lAmxaudC57LB1k7Ukl3EIcCDQSrdbrgFYC89xjV+BZOTs8cj8tYBNS70eWqlQ6dSWtIVBC74/KT/6fCS41GWGa1LLGNvi3CYSJqawIPJkwIDZmg8aCvW4S5mwqVsrk3NAmkWTYVbBRWbV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774016296; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=rb5rD8yV4uNpmLbwxWedEeyHOr37UbwjGUHfdDKoJlk=; b=JDAsC8yX6OkQ0P6ZxAebGXqeU44jRhZwiGZOCYV32lr1cEOZB1WVnxAQpMNPQlK7An+CYv2pnQK098xDygwO3jJ0FuYr0QSUVA9XwVLGTVkf8dInyfj+wYdDYjoXg1U9B0N9pReDGQl7dhMCodo6Kjv/PnHMwtiCD4I6dVJv/Qo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774016296272702.1720665077233; Fri, 20 Mar 2026 07:18:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 972EF41862; Fri, 20 Mar 2026 10:18:13 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 598F541B0B; Fri, 20 Mar 2026 10:16:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EAE5A3F290; Fri, 20 Mar 2026 10:16:44 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7A8944180D for ; Fri, 20 Mar 2026 10:16:44 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-4_UhPse_PNKBJPXbyA94xA-1; Fri, 20 Mar 2026 10:16:42 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 324B5180047F for ; Fri, 20 Mar 2026 14:16:42 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6AF3D30001A1 for ; Fri, 20 Mar 2026 14:16:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774016204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rb5rD8yV4uNpmLbwxWedEeyHOr37UbwjGUHfdDKoJlk=; b=isZnv44M5kKvIgxCmm8HRTvYwZARt5KhWDkFttnrZyEL2Ms5HXAi3eVtdsVCVy1XP9tXq9 Cfxcj1GX5Bmy9tgdWsaCTO4Cl5fEYCAlKuqICWMZdJorEpKk0fwhMPpFa7JDOwjZ1UUiq9 XX+EbviGVclFbDwcHP/LpILMoxEZ1Fs= X-MC-Unique: 4_UhPse_PNKBJPXbyA94xA-1 X-Mimecast-MFC-AGG-ID: 4_UhPse_PNKBJPXbyA94xA_1774016202 To: devel@lists.libvirt.org Subject: [PATCH 1/3] qemu: backup: Move setup of VIR_STORAGE_NET_HOST_TRANS_FD to qemuBackupPrepare Date: Fri, 20 Mar 2026 15:16:36 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wc3WLQ9iPeOQq2jntxbYiCd2SK3DuqDowYaDoDgTyeQ_1774016202 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KKZL4RJR66XUOAFMSPFIRXKLJIP3WXM3 X-Message-ID-Hash: KKZL4RJR66XUOAFMSPFIRXKLJIP3WXM3 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774016298694154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Consolidate the code under qemuBackupPrepare. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_backup.c | 52 +++++++++++++++++++++--------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index ddab4be34b..65a083ea74 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -60,7 +60,8 @@ qemuDomainGetBackup(virDomainObj *vm) static int qemuBackupPrepare(qemuDomainObjPrivate *priv, - virDomainBackupDef *def) + virDomainBackupDef *def, + qemuFDPassDirect **fdpass) { if (def->type =3D=3D VIR_DOMAIN_BACKUP_TYPE_PULL) { @@ -86,7 +87,29 @@ qemuBackupPrepare(qemuDomainObjPrivate *priv, /* TODO: Do we need to mess with selinux? */ break; - case VIR_STORAGE_NET_HOST_TRANS_FD: + case VIR_STORAGE_NET_HOST_TRANS_FD: { + virDomainFDTuple *fdt =3D NULL; + VIR_AUTOCLOSE fdcopy =3D -1; + + if (!(fdt =3D virHashLookup(priv->fds, def->server->fdgroup)))= { + virReportError(VIR_ERR_INVALID_ARG, + _("file descriptor group '%1$s' was not ass= ociated with the domain"), + def->server->fdgroup); + return -1; + } + + if (fdt->nfds !=3D 1) { + virReportError(VIR_ERR_INVALID_ARG, + _("file descriptor group '%1$s' must contai= n only 1 file descriptor for NBD server"), + def->server->fdgroup); + return -1; + } + + def->server->qemu_fdname =3D g_strdup("libvirt-backup-nbd"); + fdcopy =3D dup(fdt->fds[0]); + *fdpass =3D qemuFDPassDirectNew(def->server->qemu_fdname, &fdc= opy); + } + break; case VIR_STORAGE_NET_HOST_TRANS_RDMA: @@ -837,7 +860,7 @@ qemuBackupBegin(virDomainObj *vm, goto endjob; } - if (qemuBackupPrepare(priv, def) < 0) + if (qemuBackupPrepare(priv, def, &fdpass) < 0) goto endjob; if (qemuBackupBeginPrepareTLS(vm, cfg, def, &tlsProps, &tlsSecretProps= ) < 0) @@ -874,29 +897,6 @@ qemuBackupBegin(virDomainObj *vm, priv->backup =3D g_steal_pointer(&def); - if (pull && priv->backup->server->fdgroup) { - virDomainFDTuple *fdt =3D NULL; - VIR_AUTOCLOSE fdcopy =3D -1; - - if (!(fdt =3D virHashLookup(priv->fds, priv->backup->server->fdgro= up))) { - virReportError(VIR_ERR_INVALID_ARG, - _("file descriptor group '%1$s' was not associa= ted with the domain"), - priv->backup->server->fdgroup); - goto endjob; - } - - if (fdt->nfds !=3D 1) { - virReportError(VIR_ERR_INVALID_ARG, - _("file descriptor group '%1$s' must contain on= ly 1 file descriptor for NBD server"), - priv->backup->server->fdgroup); - goto endjob; - } - - priv->backup->server->qemu_fdname =3D g_strdup("libvirt-backup-nbd= "); - fdcopy =3D dup(fdt->fds[0]); - fdpass =3D qemuFDPassDirectNew(priv->backup->server->qemu_fdname, = &fdcopy); - } - if (qemuDomainObjEnterMonitorAsync(vm, VIR_ASYNC_JOB_BACKUP) < 0) goto endjob; --=20 2.53.0 From nobody Mon Mar 23 23:24:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774016344; cv=none; d=zohomail.com; s=zohoarc; b=hUkUn5xElEKNWk2X6k/9RjjZjiwkLEVPcjc6fhYYAsQaWGZbe79tYToW62ZC2EdWSM0eLKzn+9bD0aPDcVlxuHw3u5+esYwv45/nguJPEI6jzqUN9QWEkaUOxeNuVFJYEdg60Ce5mFGK1ExNN3qoPfW0NosGSYkUXsmes3xUqQM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774016344; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=S2XOIRHJVhQ5f/ojuFzqQeZzh+y9ggOUY3Vtxph5i0Y=; b=j5c4chYySDfl8AQXeFqwlA4GASPbbjXY9W/7wmtIJ2V4A+c3oTPswzL0wlKHstqq/+6JrqriF79uJzI1ds1H1rYRdZhqjLKxY1Yl0eQN5HOdzCHKh6caf1lQohh6FNcI9/sav1RGVvWavNNBHB7l7qeGD5LPJkeL1Mxr8h65kQI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774016344062642.2562294546618; Fri, 20 Mar 2026 07:19:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3252C41A55; Fri, 20 Mar 2026 10:19:03 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8B43841B87; Fri, 20 Mar 2026 10:16:50 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2B93041818; Fri, 20 Mar 2026 10:16:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AB1154180D for ; Fri, 20 Mar 2026 10:16:45 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-vNQCLdwMPkaoZF1vPM_2_w-1; Fri, 20 Mar 2026 10:16:44 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3385B1800345 for ; Fri, 20 Mar 2026 14:16:43 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8317B30002DF for ; Fri, 20 Mar 2026 14:16:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774016205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S2XOIRHJVhQ5f/ojuFzqQeZzh+y9ggOUY3Vtxph5i0Y=; b=Ap9jsaVqsOLZ6wHZx4zAILWkxyZD5XN7h+4kVvsaGenmowLCYhQDMtepeeXNqA+JknIFBl I6j678vuNc6xaHcPvKp1dKvIisoQtBOlLa6+hwkx3wjHWqBA/xlqu3K5GAMq46v9hZU6eE RG/5rKqortp88AHKjKmzOWiNLsSCSCI= X-MC-Unique: vNQCLdwMPkaoZF1vPM_2_w-1 X-Mimecast-MFC-AGG-ID: vNQCLdwMPkaoZF1vPM_2_w_1774016203 To: devel@lists.libvirt.org Subject: [PATCH 2/3] qemu: conf: Don't use VIR_ERR_INTERNAL_ERROR for config file parsing errors Date: Fri, 20 Mar 2026 15:16:37 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wmsvHU9WRUpDKrh-aeNFv7eG2RkbyxsZHK8Uv1VP3d8_1774016203 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: W75PNSDJQPKNGSDXH3BGJLJZJ43RXBLH X-Message-ID-Hash: W75PNSDJQPKNGSDXH3BGJLJZJ43RXBLH X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774016345591158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa When parsing port ranges for the port allocator VIR_ERR_INTERNAL_ERROR is not the right error code for errors on the user-supplied numbers. Use VIR_ERR_CONF_SYNTAX instead. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_conf.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index d43e0c2b97..712422f995 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -626,7 +626,7 @@ virQEMUDriverConfigLoadRemoteDisplayEntry(virQEMUDriver= Config *cfg, /* if the port is too low, we can't get the display name * to tell to vnc (usually subtract 5700, e.g. localhost:1 * for port 5701) */ - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_websocket_port_min: port must be gr= eater than or equal to %2$d"), filename, QEMU_WEBSOCKET_PORT_MIN); return -1; @@ -636,14 +636,14 @@ virQEMUDriverConfigLoadRemoteDisplayEntry(virQEMUDriv= erConfig *cfg, return -1; if (cfg->webSocketPortMax > QEMU_WEBSOCKET_PORT_MAX || cfg->webSocketPortMax < cfg->webSocketPortMin) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_websocket_port_max: port must be b= etween the minimal port and %2$d"), filename, QEMU_WEBSOCKET_PORT_MAX); return -1; } if (cfg->webSocketPortMin > cfg->webSocketPortMax) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_websocket_port_min: min port must = not be greater than max port"), filename); return -1; @@ -655,7 +655,7 @@ virQEMUDriverConfigLoadRemoteDisplayEntry(virQEMUDriver= Config *cfg, /* if the port is too low, we can't get the display name * to tell to vnc (usually subtract 5900, e.g. localhost:1 * for port 5901) */ - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_display_port_min: port must be grea= ter than or equal to %2$d"), filename, QEMU_REMOTE_PORT_MIN); return -1; @@ -665,14 +665,14 @@ virQEMUDriverConfigLoadRemoteDisplayEntry(virQEMUDriv= erConfig *cfg, return -1; if (cfg->remotePortMax > QEMU_REMOTE_PORT_MAX || cfg->remotePortMax < cfg->remotePortMin) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_display_port_max: port must be bet= ween the minimal port and %2$d"), filename, QEMU_REMOTE_PORT_MAX); return -1; } if (cfg->remotePortMin > cfg->remotePortMax) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: remote_display_port_min: min port must no= t be greater than max port"), filename); return -1; @@ -979,7 +979,7 @@ virQEMUDriverConfigLoadNetworkEntry(virQEMUDriverConfig= *cfg, if (virConfGetValueUInt(conf, "migration_port_min", &cfg->migrationPor= tMin) < 0) return -1; if (cfg->migrationPortMin <=3D 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: migration_port_min: port must be greater t= han 0"), filename); return -1; @@ -989,7 +989,7 @@ virQEMUDriverConfigLoadNetworkEntry(virQEMUDriverConfig= *cfg, return -1; if (cfg->migrationPortMax > 65535 || cfg->migrationPortMax < cfg->migrationPortMin) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: migration_port_max: port must be between = the minimal port %2$d and 65535"), filename, cfg->migrationPortMin); return -1; @@ -998,7 +998,7 @@ virQEMUDriverConfigLoadNetworkEntry(virQEMUDriverConfig= *cfg, if (virConfGetValueUInt(conf, "backup_port_min", &cfg->backupPortMin) = < 0) return -1; if (cfg->backupPortMin <=3D 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: backup_port_min: port must be greater than= 0"), filename); return -1; @@ -1008,7 +1008,7 @@ virQEMUDriverConfigLoadNetworkEntry(virQEMUDriverConf= ig *cfg, return -1; if (cfg->backupPortMax > 65535 || cfg->backupPortMax < cfg->backupPortMin) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_CONF_SYNTAX, _("%1$s: backup_port_max: port must be between the= minimal port %2$d and 65535"), filename, cfg->backupPortMin); return -1; --=20 2.53.0 From nobody Mon Mar 23 23:24:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774016376; cv=none; d=zohomail.com; s=zohoarc; b=U07CwbFsWU4uG/nHIfIFZhjb85OnW0IrH3EWu2g6Xt+l2VUKWx4jdCC0r3kcjfAJ322ebRdLc5oypzq1IxmVYm1HhTCT0ezW4gUKYZOHBYpx87Nyc8RbNO7cSLnjhyuekwM7+oJZFAmjYKiR3r+fMB69B8KZWhgzKw1Gx+JqMCs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774016376; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=XIeKpINBAIQ/lGcODwVMCaQR7foH7HmXGNwJsFALifs=; b=LZ8525wklRv19uYP6l0ZCSJK4xyxq6rtPxBjPkpo3tgkgTc2BKJ6dWfnpGqp5+J1ip5HUh4yRmxqSK4njrrwKbSzZffGqA9b/YvsQa8uk9nPQbG9RheBBw7XecSKWoOq1dgiVEH1Wx8p763L5S9dou6danTfHAQTGAJF32hjsQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774016376721429.81353580606356; Fri, 20 Mar 2026 07:19:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA0E041880; Fri, 20 Mar 2026 10:19:35 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 4EE0841BD8; Fri, 20 Mar 2026 10:17:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 71C8841ACD; Fri, 20 Mar 2026 10:16:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5C564418BD for ; Fri, 20 Mar 2026 10:16:47 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-kb2EjmBKM8KtbQ7wKAHEjw-1; Fri, 20 Mar 2026 10:16:45 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 92B7D19560BF for ; Fri, 20 Mar 2026 14:16:44 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AB1DA30001A1 for ; Fri, 20 Mar 2026 14:16:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774016206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XIeKpINBAIQ/lGcODwVMCaQR7foH7HmXGNwJsFALifs=; b=W6hG4GMGz4vWbJdeCqzmbIxfSzmMLB1QKSI/7HmDRFPqR3G179+HqkrfpinpJp7yZBUKjb dRs++oPka5qCoaBSeNHFWMpIcR76EcW93HFpCYoh/WnEb6dk3ysbEv0D2JCVqPUAT92UX+ 6GMqRuDQdMS/LFt0G74yERhGTseQGeQ= X-MC-Unique: kb2EjmBKM8KtbQ7wKAHEjw-1 X-Mimecast-MFC-AGG-ID: kb2EjmBKM8KtbQ7wKAHEjw_1774016204 To: devel@lists.libvirt.org Subject: [PATCH 3/3] qemuTranslateSnapshotDiskSourcePool: Use proper error code Date: Fri, 20 Mar 2026 15:16:38 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kWHP4LMoS5K34ZANWoW4-vhyHevwIhnTBpLouceLiIo_1774016204 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IT4TQZHAXU2HE3BAYFE5FCN6XYLI6C3H X-Message-ID-Hash: IT4TQZHAXU2HE3BAYFE5FCN6XYLI6C3H X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774016377695158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The operation is not implemented so it's not really an internal error. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 712422f995..b2ced2baf0 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1808,7 +1808,7 @@ qemuTranslateSnapshotDiskSourcePool(virDomainSnapshot= DiskDef *def) if (def->src->type !=3D VIR_STORAGE_TYPE_VOLUME) return 0; - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("Snapshots are not yet supported with 'pool' volumes"= )); return -1; } --=20 2.53.0