From nobody Tue Mar 3 03:04:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772183086; cv=none; d=zohomail.com; s=zohoarc; b=eqV2nzSxEEeCb4SP5fEh+gwz33PsIL0pidBhuqodBQyrNXwxtWHFn+VFpCRcgltRohUI3RIIUAkjIuUdVr7OBSY2QchkO9POQqAz/CjFu9EKnQxFK3/3iROtgu9Y0725Z23ToNOmBUCX3+bXMd9bitbo/QEC61I3xpVrPuxPhqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772183086; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=xLVYEOmcL8uTJUmnWnatwLZjQQsSVHPOANjfylH9mvs=; b=kJfnZs9t/F53Z7Bo7gVqiTNcc78fpdyC5YZORyG2RfXOnYd0jdtgyWPdjFJk8zDgR6GQloDb0FGwhl6qSpwpcFlNVIkxRxzOl2m9DqcJRLJ341UhPcuDN8yQYpC/vGKs5uhvrvSAfNJNHvyH3lyJhbv3HOEvg8urdnwkqEnLAo4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772183086346725.2923446549772; Fri, 27 Feb 2026 01:04:46 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 617BE41D65; Fri, 27 Feb 2026 04:04:45 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id CA43841E2F; Fri, 27 Feb 2026 04:03:13 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id D58C33F97E; Fri, 27 Feb 2026 04:03:08 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7597D417D0 for ; Fri, 27 Feb 2026 04:03:08 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-ahtTtOu6Pdmna6ybPd1f9Q-1; Fri, 27 Feb 2026 04:03:06 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A131218002E6 for ; Fri, 27 Feb 2026 09:03:05 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 100CA19560B5 for ; Fri, 27 Feb 2026 09:03:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772182988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLVYEOmcL8uTJUmnWnatwLZjQQsSVHPOANjfylH9mvs=; b=P+K3qT1UpMX4RbUple9sVJnjd2Yf67UrZRNPu/YYF+iB6huMMfDcorERMxDE6sEuvfhmZS 6M840PENN/BoXD4YqYCND15Rjn2mplnNMiKaOjyLgbsAi9WmH6cICZAqm0rFHXe3SFx2go jPqgV9Hpz0aPn3uGH5D1t65flu/1ADs= X-MC-Unique: ahtTtOu6Pdmna6ybPd1f9Q-1 X-Mimecast-MFC-AGG-ID: ahtTtOu6Pdmna6ybPd1f9Q_1772182985 To: devel@lists.libvirt.org Subject: [PATCH 1/4] virpcimock: Create sriov_totalvfs file and virtfnN symlinks Date: Fri, 27 Feb 2026 10:02:56 +0100 Message-ID: <6b65355bbd523cb17de19570a2c9bbcf1f5667dc.1772182866.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UckORSNN2UAolhR3cUmGt7Pug5wlXTtufHwsP_9m4io_1772182985 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3W27YHUA7EOSQ745IISGTM5PLMCL5I6T X-Message-ID-Hash: 3W27YHUA7EOSQ745IISGTM5PLMCL5I6T X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772183088281158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik In case of an SRIOV device the sysfs struct looks like this: -r--r--r--. 1 root root 4096 Feb 26 14:40 /sys/bus/pci/devices/0000:82:00.0= /sriov_totalvfs lrwxrwxrwx. 1 root root 0 Feb 25 22:51 /sys/bus/pci/devices/0000:82:00.0= /virtfn0 -> ../0000:82:10.0 lrwxrwxrwx. 1 root root 0 Feb 25 22:51 /sys/bus/pci/devices/0000:82:00.0= /virtfn1 -> ../0000:82:10.4 lrwxrwxrwx. 1 root root 0 Feb 25 22:51 /sys/bus/pci/devices/0000:82:00.0= /virtfn2 -> ../0000:82:11.0 lrwxrwxrwx. 1 root root 0 Feb 25 22:51 /sys/bus/pci/devices/0000:82:00.0= /virtfn3 -> ../0000:82:11.4 Of course, there is much more, I've just picked up files that our code touches during hotplug of an . The first file 'sriov_totalvfs' contains the maximum number of VFs supported. Then, for each VF created there's 'virtfnN' symlink to individual VFs. Teach our virpcimock to create the file and symlinks. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 50 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index ca345f37a3..c59359b889 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -141,6 +141,8 @@ struct pciDevice { int device; int klass; int iommuGroup; + int sriovTotalvfs; + unsigned int virtfnCount; const char *physfn; struct pciDriver *driver; /* Driver attached. NULL if attached to no= driver */ struct pciVPD vpd; @@ -439,6 +441,38 @@ pci_device_create_iommu(const struct pciDevice *dev, } =20 =20 +static void +register_vf(struct pciDevice *vf) +{ + struct pciDeviceAddress pfAddr; + struct pciDevice *pf; + g_autofree char *relPath =3D NULL; + g_autofree char *pfPath =3D NULL; + g_autofree char *virtfnName =3D NULL; + + if (pci_address_parse(&pfAddr, vf->physfn) < 0) + ABORT("Unable to parse PCI address %s", vf->physfn); + + if (!(pf =3D pci_device_find_by_id(&pfAddr))) { + ABORT("Unable to find PF for VF %s", vf->physfn); + } + + relPath =3D g_strdup_printf("../" ADDR_STR_FMT, + vf->addr.domain, + vf->addr.bus, + vf->addr.device, + vf->addr.function); + + virtfnName =3D g_strdup_printf("virtfn%u", pf->virtfnCount); + + pfPath =3D pci_device_get_path(pf, NULL, true); + + make_symlink(pfPath, virtfnName, relPath); + + pf->virtfnCount++; +} + + static void pci_device_new_from_stub(const struct pciDevice *data) { @@ -537,6 +571,14 @@ pci_device_new_from_stub(const struct pciDevice *data) =20 make_symlink(devsympath, devid, tmp); =20 + if (dev->sriovTotalvfs) { + if (g_snprintf(tmp, sizeof(tmp), "%d\n", dev->sriovTotalvfs) < 0) { + ABORT("@tmp overflow"); + } + + make_file(devpath, "sriov_totalvfs", tmp, -1); + } + if (dev->physfn) { if (g_snprintf(tmp, sizeof(tmp), "%s%s/devices/%s", fakerootdir, @@ -544,6 +586,8 @@ pci_device_new_from_stub(const struct pciDevice *data) ABORT("@tmp overflow"); } make_symlink(devpath, "physfn", tmp); + + register_vf(dev); } =20 if (dev->vpd.data && dev->vpd.vpd_len) @@ -1043,12 +1087,14 @@ init_env(void) MAKE_PCI_DEVICE("0000:0a:01.0", 0x8086, 0x0047, 8); MAKE_PCI_DEVICE("0000:0a:02.0", 0x8286, 0x0048, 8); MAKE_PCI_DEVICE("0000:0a:03.0", 0x8386, 0x0048, 8); - MAKE_PCI_DEVICE("0000:06:12.0", 0x8086, 0x0047, 9); + MAKE_PCI_DEVICE("0000:06:12.0", 0x8086, 0x0047, 9, + .sriovTotalvfs =3D 7); MAKE_PCI_DEVICE("0000:06:12.1", 0x8086, 0x0047, 10, .physfn =3D "0000:06:12.0"); /* Virtual Function */ MAKE_PCI_DEVICE("0000:06:12.2", 0x8086, 0x0047, 11, .physfn =3D "0000:06:12.0"); /* Virtual Function */ - MAKE_PCI_DEVICE("0021:de:1f.0", 0x8086, 0x0047, 12); + MAKE_PCI_DEVICE("0021:de:1f.0", 0x8086, 0x0047, 12, + .sriovTotalvfs =3D 7); MAKE_PCI_DEVICE("0021:de:1f.1", 0x8086, 0x0047, 13, .physfn =3D "0021:de:1f.0"); /* Virtual Function */ =20 --=20 2.52.0 From nobody Tue Mar 3 03:04:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772183159; cv=none; d=zohomail.com; s=zohoarc; b=CQ9T7wM06gEqDnrgGvqfqvHTHhVStvrf6/uZePHo286BTKpjg/m7fwhvBGFXYfuz7VeYbQPAdWVbGJ7ClfaQfD6F7ozPPmbFgNoJZVuoKTjsLLvrJBG7mGovvAzAVL2telD6O53n6bjGXDi8Z2ruOSzON/hiVwRW/eyMT/qiEzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772183159; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=rL12Ok5bYeYMePRYrkg96cC9GzTx4QbyVhgNC3ypJGA=; b=c90ky3LuxCDv1JNA4G/MluZ1c/XnMcheuaCCQSAiacgaJix+tj23Q7zgnlf+vuh+COoR3AbnGrXvaAy4df2wTV4LkAJQa8yPy1j17UegKRiBJnndNqsWJiLJyUQf55wNj2sphhuQIyPHc1P017PIqOAbrvlrcLV1CkRAHOXuDdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772183159465898.3754310835833; Fri, 27 Feb 2026 01:05:59 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id ADB8041D42; Fri, 27 Feb 2026 04:05:58 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id CB24442412; Fri, 27 Feb 2026 04:03:23 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id D46BB41D8D; Fri, 27 Feb 2026 04:03:19 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C1A8941D19 for ; Fri, 27 Feb 2026 04:03:10 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-KFqw9Md_MeeGkra6UfG0-Q-1; Fri, 27 Feb 2026 04:03:07 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 962721956059 for ; Fri, 27 Feb 2026 09:03:06 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 054C619560B5 for ; Fri, 27 Feb 2026 09:03:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772182990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rL12Ok5bYeYMePRYrkg96cC9GzTx4QbyVhgNC3ypJGA=; b=IDUYViLLoz94A+4UaFi2FXTZotxs8iwGz5+hyDaQJgqzsAgJgUkna9PSJXbGZyy7Iiuy2C SACGvcWaWUvyMPs11R0pLdjFSyxSaDiyNchc0SdHUjdfZWhLvxSh4YeVXj4QOvqQgSjHTY yyMI6SGs+uGRv0F0TEkGepB7rPEtP+8= X-MC-Unique: KFqw9Md_MeeGkra6UfG0-Q-1 X-Mimecast-MFC-AGG-ID: KFqw9Md_MeeGkra6UfG0-Q_1772182986 To: devel@lists.libvirt.org Subject: [PATCH 2/4] virpcimock: Create net/ subdir for devices Date: Fri, 27 Feb 2026 10:02:57 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oPvfmNlpabI3BSyewG1NVLRgLlAaSauTncQw3JFXQdg_1772182986 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5I5K6HXT6QCZOLDOC7UQH6XNQCIGSNK5 X-Message-ID-Hash: 5I5K6HXT6QCZOLDOC7UQH6XNQCIGSNK5 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772183160559158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik A PCI device that is a network interface card also has 'net/' subdir with interface name it corresponds to. For instance: # ls -l /sys/bus/pci/devices/0000\:00\:1f.6/net/ total 0 drwxr-xr-x 5 root root 0 Feb 26 16:51 eth0 Allow setting interface name for PCI devices. Now, in real life the net/$IFNAME/ is a directory, but since our code opens net/ dir and then just reads dentries creating file instead of full blown dir is okay. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 32 +++++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index c59359b889..22d2354ebe 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -144,6 +144,7 @@ struct pciDevice { int sriovTotalvfs; unsigned int virtfnCount; const char *physfn; + const char *netName; struct pciDriver *driver; /* Driver attached. NULL if attached to no= driver */ struct pciVPD vpd; }; @@ -590,6 +591,18 @@ pci_device_new_from_stub(const struct pciDevice *data) register_vf(dev); } =20 + if (dev->netName) { + if (g_snprintf(tmp, sizeof(tmp), "%s/net", devpath) < 0) { + ABORT("@tmp overflow"); + } + + if (g_mkdir_with_parents(tmp, 0777) < 0) + ABORT("Unable to create: %s", tmp); + + /* In real sysfs this is a dir, but for test purposes a file is ok= ay. */ + make_file(tmp, dev->netName, dev->netName, -1); + } + if (dev->vpd.data && dev->vpd.vpd_len) make_file(devpath, "vpd", dev->vpd.data, dev->vpd.vpd_len); =20 @@ -1072,8 +1085,10 @@ init_env(void) pci_device_new_from_stub(&dev); \ } while (0) =20 - MAKE_PCI_DEVICE("0000:00:00.0", 0x8086, 0x0044, 0); - MAKE_PCI_DEVICE("0000:00:01.0", 0x8086, 0x0044, 1); + MAKE_PCI_DEVICE("0000:00:00.0", 0x8086, 0x0044, 0, + .netName =3D "wlan0"); + MAKE_PCI_DEVICE("0000:00:01.0", 0x8086, 0x0044, 1, + .netName =3D "wlan1"); MAKE_PCI_DEVICE("0000:00:02.0", 0x8086, 0x0046, 2); MAKE_PCI_DEVICE("0000:00:03.0", 0x8086, 0x0048, 3); MAKE_PCI_DEVICE("0001:00:00.0", 0x1014, 0x03b9, 4, .klass =3D 0x060400= ); @@ -1088,15 +1103,18 @@ init_env(void) MAKE_PCI_DEVICE("0000:0a:02.0", 0x8286, 0x0048, 8); MAKE_PCI_DEVICE("0000:0a:03.0", 0x8386, 0x0048, 8); MAKE_PCI_DEVICE("0000:06:12.0", 0x8086, 0x0047, 9, - .sriovTotalvfs =3D 7); + .sriovTotalvfs =3D 7, .netName =3D "enp1s0f0"); MAKE_PCI_DEVICE("0000:06:12.1", 0x8086, 0x0047, 10, - .physfn =3D "0000:06:12.0"); /* Virtual Function */ + .physfn =3D "0000:06:12.0", /* Virtual Function */ + .netName =3D "enp1s0f1"); MAKE_PCI_DEVICE("0000:06:12.2", 0x8086, 0x0047, 11, - .physfn =3D "0000:06:12.0"); /* Virtual Function */ + .physfn =3D "0000:06:12.0", /* Virtual Function */ + .netName =3D "enp1s0f2"); MAKE_PCI_DEVICE("0021:de:1f.0", 0x8086, 0x0047, 12, - .sriovTotalvfs =3D 7); + .sriovTotalvfs =3D 7, .netName =3D "enp2s0f0"); MAKE_PCI_DEVICE("0021:de:1f.1", 0x8086, 0x0047, 13, - .physfn =3D "0021:de:1f.0"); /* Virtual Function */ + .physfn =3D "0021:de:1f.0", /* Virtual Function */ + .netName =3D "enp2s0f1"); =20 MAKE_PCI_DEVICE("0000:01:00.0", 0x1cc1, 0x8201, 14, .klass =3D 0x01080= 2); MAKE_PCI_DEVICE("0000:02:00.0", 0x1cc1, 0x8201, 15, .klass =3D 0x01080= 2); --=20 2.52.0 From nobody Tue Mar 3 03:04:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772183121; cv=none; d=zohomail.com; s=zohoarc; b=X7LeFbZoTyhP7Pus11/0GW8RzhpGq+kmXzfpRCgzYtLK4IitB1/yWPjKJWMZbvjIbRs38hblDz0NgfRjZJZaMBrejORSQ+syMBhr7tURGFeGj4n88AUfcnGnH+HnyCGuTttO5F43FVwngNKOgJafAuGW66S5xo+rmovZ82UxBdE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772183121; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=xPuv30NK5+RDNfa2vorNDZ0jD/gUmMgDH1yMb+3PXwY=; b=X5epPRbcNoRkivc0t09wDGmQLl2xTdFV1RbvSmEWao9z2qbIb0pSwNusNG6xyRJD+iFia/IBaCEwZaTp6YGALOv+kKtHeF0xTLGdMOMSXuHkaNJ1TVbd2As8FB0ATjk7bRHDkTlcvLm+RyB8oyOz8QrwgP5cj/1sbv65DYmyyUc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772183121718729.3520204625398; Fri, 27 Feb 2026 01:05:21 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A613541D8D; Fri, 27 Feb 2026 04:05:20 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9DFAC423DA; Fri, 27 Feb 2026 04:03:22 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 68CDA41D3B; Fri, 27 Feb 2026 04:03:17 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B143741AE5 for ; Fri, 27 Feb 2026 04:03:10 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-EeV_dM0jNrSJyW6nHSnTOg-1; Fri, 27 Feb 2026 04:03:08 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95D8A19560A1 for ; Fri, 27 Feb 2026 09:03:07 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0251319560B5 for ; Fri, 27 Feb 2026 09:03:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772182990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xPuv30NK5+RDNfa2vorNDZ0jD/gUmMgDH1yMb+3PXwY=; b=M7tVPxeuN1+aZHIdyEHyF1bMGHUjiOTPrZzciffj7Qb3khAcoyo62jneRtTEMluDM9O371 ZN9E8TU+KmTDnZoPtxrY5IkILqoTGs3aYB2Q06N8nu+ezVPSJ1YMhIYWW5OgniWgChBJi7 4d1XiPVXX+Hz46tp6nSAoP+JSovk0K8= X-MC-Unique: EeV_dM0jNrSJyW6nHSnTOg-1 X-Mimecast-MFC-AGG-ID: EeV_dM0jNrSJyW6nHSnTOg_1772182987 To: devel@lists.libvirt.org Subject: [PATCH 3/4] virnetdevmock: Mock virNetDevSaveNetConfig() and virNetDevSetNetConfig() Date: Fri, 27 Feb 2026 10:02:58 +0100 Message-ID: <6ce24124692ecbd5b0db6466f1b5af559cf914ef.1772182866.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4CH_3ZVC2-VHOPN9uI95ornX_5lA5JhQfLSYK9zQWkM_1772182987 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CBWUTJFKBRCTXWTZOYTVL5TT2XZQXAQW X-Message-ID-Hash: CBWUTJFKBRCTXWTZOYTVL5TT2XZQXAQW X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772183122345158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik We really don't want our test suite talking to kernel and setting various attributes on NICs. Signed-off-by: Michal Privoznik --- src/util/virnetdev.h | 5 +++-- tests/virnetdevmock.c | 22 ++++++++++++++++++++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index 1da1795487..424d4c0e52 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -248,7 +248,8 @@ int virNetDevGetVirtualFunctions(const char *pfname, int virNetDevSaveNetConfig(const char *linkdev, int vf, const char *stateDir, bool saveVlan) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3) G_GNUC_WARN_UNUSED_RESULT; + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3) G_GNUC_WARN_UNUSED_RESULT + ATTRIBUTE_MOCKABLE; =20 int virNetDevReadNetConfig(const char *linkdev, int vf, @@ -265,7 +266,7 @@ virNetDevSetNetConfig(const char *linkdev, int vf, const virNetDevVlan *vlan, const virMacAddr *MAC, bool setVLan) - ATTRIBUTE_NONNULL(1) G_GNUC_WARN_UNUSED_RESULT; + ATTRIBUTE_NONNULL(1) G_GNUC_WARN_UNUSED_RESULT ATTRIBUTE_MOCKABLE; =20 int virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname, int *vf) diff --git a/tests/virnetdevmock.c b/tests/virnetdevmock.c index 910009d80c..c45b89288b 100644 --- a/tests/virnetdevmock.c +++ b/tests/virnetdevmock.c @@ -33,6 +33,28 @@ virNetDevSysfsFile(char **pf_sysfs_device_link, NET_DEV_TEST_DATA_PREFIX, ifna= me, file); return 0; } + + +int +virNetDevSaveNetConfig(const char *linkdev G_GNUC_UNUSED, + int vf G_GNUC_UNUSED, + const char *stateDir G_GNUC_UNUSED, + bool saveVlan G_GNUC_UNUSED) +{ + return 0; +} + + +int +virNetDevSetNetConfig(const char *linkdev G_GNUC_UNUSED, + int vf G_GNUC_UNUSED, + const virMacAddr *adminMAC G_GNUC_UNUSED, + const virNetDevVlan *vlan G_GNUC_UNUSED, + const virMacAddr *MAC G_GNUC_UNUSED, + bool setVLan G_GNUC_UNUSED) +{ + return 0; +} #else /* Nothing to override on non-__linux__ platforms */ #endif --=20 2.52.0 From nobody Tue Mar 3 03:04:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772183201; cv=none; d=zohomail.com; s=zohoarc; b=EoUtyMr0LO3QX075yEf7P6Ecv83P0tAskNAF1kVeeUCSE6Osjq/jDRUH4e1PY2swWOzAFQuhq/J0mq1Lv5hnQbq6TQCq/wPN7d5jk80s8MIW+oAE8pCfLW4fPfpqZfyG2pEgrOymzGbmDvc8IyC95ikcXheJtZ5+GmfbnnACi8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772183201; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=OCF1XRS8v2OmX/fo45BA4YyUtP4RquOlLUm1tP57/jU=; b=lwntfLNzMfxYMxDjEZbbSXcRyiZaTqi8X1DwWSLOS+nEVlR9wCMA8+nsqRcL5ChEa6hpy1Y9cy/YNz6J/Oq5ofjXu/SajwCk/F4HAOx9U2QD7sMQjo67P6gkBESwucySkBU0RSD0LlVqT8Mh9K+1vP7zK2YyE3Xjri04kQfnY3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772183201511493.43453386850524; Fri, 27 Feb 2026 01:06:41 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 833CC41D4D; Fri, 27 Feb 2026 04:06:40 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0231643E0A; Fri, 27 Feb 2026 04:03:39 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id E430441E39; Fri, 27 Feb 2026 04:03:33 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 077B141D8E for ; Fri, 27 Feb 2026 04:03:12 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-gLBlPcLtMhaM72egDCa8dQ-1; Fri, 27 Feb 2026 04:03:09 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 929351800579 for ; Fri, 27 Feb 2026 09:03:08 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F394C19560B5 for ; Fri, 27 Feb 2026 09:03:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772182991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OCF1XRS8v2OmX/fo45BA4YyUtP4RquOlLUm1tP57/jU=; b=I9orAqG5jydaZGaAL1PXktgmmlYdi+1ZDCYLkNfJoggoqR4rOVjQcu355PfQAkj5MzY6TN 9xMetffW+q2Z37hguvJmmV7g+P7wM25UfFB6GOPgGbiLErC0h6OmyVapnClGuRxLV23D1R RYhlKlyCFeAGWIyuBBoz9iwswD25VGo= X-MC-Unique: gLBlPcLtMhaM72egDCa8dQ-1 X-Mimecast-MFC-AGG-ID: gLBlPcLtMhaM72egDCa8dQ_1772182988 To: devel@lists.libvirt.org Subject: [PATCH 4/4] qemuhotplugtest: Introduce interface-hostdev test case Date: Fri, 27 Feb 2026 10:02:59 +0100 Message-ID: <7fee163eb9243347a73faeabe231485e9adcd52e.1772182866.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LFhxJZ9mjFKS30440dQpMSQOVqwl8MS3WqQvkTDunXk_1772182988 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: U252U3QVXW2IQNLK7RO2LUFJPM4WCUMA X-Message-ID-Hash: U252U3QVXW2IQNLK7RO2LUFJPM4WCUMA X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772183202853158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik While our qemuhotplugtest already does a PCI hotplug and unlpug ("hostdev-pci") there is another way to hotplug a PCI device, esp. if it's a NIC: . This has been missing and as shown in v12.1.0-rc1-4-gfe782ed334 can be potentially dangerous as some different paths are taken. Introduce a test case for interface-hostdev. Signed-off-by: Michal Privoznik --- tests/qemuhotplugtest.c | 7 ++- .../qemuhotplug-interface-hostdev.xml | 6 ++ ...emuhotplug-base-live+interface-hostdev.xml | 63 +++++++++++++++++++ 3 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-interface-host= dev.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+inte= rface-hostdev.xml diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 58413b6e0d..3367804ed0 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -697,6 +697,10 @@ mymain(void) DO_TEST_DETACH("ppc64", "pseries-base-live", "hostdev-pci", false, fal= se, "device_del", QMP_DEVICE_DELETED("hostdev0") QMP_OK); =20 + DO_TEST_ATTACH("x86_64", "base-live", "interface-hostdev", false, true, + "device_add", QMP_OK); + DO_TEST_DETACH("x86_64", "base-live", "interface-hostdev", false, fals= e, + "device_del", QMP_DEVICE_DELETED("hostdev0") QMP_OK); DO_TEST_ATTACH("x86_64", "base-live", "interface-vdpa", false, true, "query-fdsets", "{\"return\":[{\"fdset-id\":99999}]}", "add-fd", "{ \"return\": { \"fdset-id\": 1, \"fd\": 95 = }}", @@ -803,4 +807,5 @@ VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virpci"), VIR_TEST_MOCK("domaincaps"), VIR_TEST_MOCK("virprocess"), - VIR_TEST_MOCK("qemuhotplug")); + VIR_TEST_MOCK("qemuhotplug"), + VIR_TEST_MOCK("virnetdev")); diff --git a/tests/qemuhotplugtestdevices/qemuhotplug-interface-hostdev.xml= b/tests/qemuhotplugtestdevices/qemuhotplug-interface-hostdev.xml new file mode 100644 index 0000000000..0eb7a1df1a --- /dev/null +++ b/tests/qemuhotplugtestdevices/qemuhotplug-interface-hostdev.xml @@ -0,0 +1,6 @@ + + +
+ + + diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-base-live+interface-h= ostdev.xml b/tests/qemuhotplugtestdomains/qemuhotplug-base-live+interface-h= ostdev.xml new file mode 100644 index 0000000000..13288f7711 --- /dev/null +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-live+interface-hostdev.= xml @@ -0,0 +1,63 @@ + + hotplug + d091ea82-29e6-2e34-3005-f02617b36e87 + 4194304 + 4194304 + 4 + + hvm + + + + + + + + + qemu64 + + + destroy + restart + restart + + /usr/bin/qemu-system-x86_64 + + +
+ + + +
+ + + +
+ + + + + + +
+ + + + + +
+ + +
+ + + + + + + +